reactos/wine
1
0
Fork 0
mirror of https://github.com/reactos/wine.git synced 2025-01-21 03:15:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "advapi32: Free descriptor if it isn't returned from GetSecurityInfo().".

Browse Source 
This reverts commit dbd76575ef8353484afa0b0d2da95760c26f34fe.

According to MSDN, ppSecurityDescriptor must not be NULL if any of the
SID or ACL parameters are non-NULL.  This is wrong, and native
GetSecurityInfo will happily return those pointers, leaving one unable
to free the original security descriptor.
This commit is contained in:
James Hawkins 2010-01-14 11:35:09 -08:00 committed by Alexandre Julliard
parent 539da1b073
commit 72158ac286
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dlls/advapi32/security.c
View File

@ -3118,8 +3118,11 @@ DWORD WINAPI GetSecurityInfo(
}
if (ppSecurityDescriptor)
*ppSecurityDescriptor = sd;
else
LocalFree(sd);
/* The security descriptor (sd) cannot be freed if ppSecurityDescriptor is
* NULL, because native happily returns the SIDs and ACLs that are requested
* in this case.
*/
return ERROR_SUCCESS;
}