reactos/wine
1
0
Fork 0
mirror of https://github.com/reactos/wine.git synced 2025-02-07 20:57:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

user32: Fix arithmetic overflow in GetThumbVal.

Browse Source
This commit is contained in:
Alexander Kochetkov 2010-01-09 15:24:44 +03:00 committed by Alexandre Julliard
parent a1e134961d
commit 8037de9f02
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dlls/user32/scroll.c
View File

@ -317,6 +317,7 @@ static UINT SCROLL_GetThumbVal( SCROLLBAR_INFO *infoPtr, RECT *rect,
{
INT thumbSize;
INT pixels = vertical ? rect->bottom-rect->top : rect->right-rect->left;
INT range;
if ((pixels -= 2*(GetSystemMetrics(SM_CXVSCROLL) - SCROLL_ARROW_THUMB_OVERLAP)) <= 0)
return infoPtr->minVal;
@ -333,9 +334,12 @@ static UINT SCROLL_GetThumbVal( SCROLLBAR_INFO *infoPtr, RECT *rect,
pos = max( 0, pos - (GetSystemMetrics(SM_CXVSCROLL) - SCROLL_ARROW_THUMB_OVERLAP) );
if (pos > pixels) pos = pixels;
if (!infoPtr->page) pos *= infoPtr->maxVal - infoPtr->minVal;
else pos *= infoPtr->maxVal - infoPtr->minVal - infoPtr->page + 1;
return infoPtr->minVal + ((pos + pixels / 2) / pixels);
if (!infoPtr->page)
range = infoPtr->maxVal - infoPtr->minVal;
else
range = infoPtr->maxVal - infoPtr->minVal - infoPtr->page + 1;
return infoPtr->minVal + MulDiv(pos, range, pixels);
}
/***********************************************************************