reactos/wine
1
0
Fork 0
mirror of https://github.com/reactos/wine.git synced 2024-11-25 04:39:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mshtml: Use stored nsdoc in IHTMLOptionElementFactory::create.

Browse Source
This commit is contained in:
Jacek Caban 2008-10-09 15:26:01 -05:00 committed by Alexandre Julliard
parent c3ea7272a3
commit 8162797af0
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
dlls/mshtml/htmloption.c
View File

@ -448,7 +448,6 @@ static HRESULT WINAPI HTMLOptionElementFactory_create(IHTMLOptionElementFactory
IHTMLOptionElement **optelem)
{
HTMLOptionElementFactory *This = HTMLOPTFACTORY_THIS(iface);
nsIDOMDocument *nsdoc;
nsIDOMElement *nselem;
nsAString option_str;
nsresult nsres;
@ -456,21 +455,18 @@ static HRESULT WINAPI HTMLOptionElementFactory_create(IHTMLOptionElementFactory
static const PRUnichar optionW[] = {'O','P','T','I','O','N',0};
TRACE("(%p)->(v v v v %p)\n", This, optelem);
TRACE("(%p)->(%s %s %s %s %p)\n", This, debugstr_variant(&text), debugstr_variant(&value),
debugstr_variant(&defaultselected), debugstr_variant(&selected), optelem);
*optelem = NULL;
if(!This->doc->nscontainer)
return E_FAIL;
nsres = nsIWebNavigation_GetDocument(This->doc->nscontainer->navigation, &nsdoc);
if(NS_FAILED(nsres)) {
ERR("GetDocument failed: %08x\n", nsres);
return E_FAIL;
if(!This->doc->nsdoc) {
WARN("NULL nsdoc\n");
return E_UNEXPECTED;
}
*optelem = NULL;
nsAString_Init(&option_str, optionW);
nsres = nsIDOMDocument_CreateElement(nsdoc, &option_str, &nselem);
nsIDOMDocument_Release(nsdoc);
nsres = nsIDOMHTMLDocument_CreateElement(This->doc->nsdoc, &option_str, &nselem);
nsAString_Finish(&option_str);
if(NS_FAILED(nsres)) {
ERR("CreateElement failed: %08x\n", nsres);