From a457ee0a3d011029e6e666da0e1722cd90e3cb49 Mon Sep 17 00:00:00 2001
From: Peter Berg Larsen <pebl@math.ku.dk>
Date: Tue, 6 Jan 2004 21:36:10 +0000
Subject: [PATCH] %[a-z] and %[z-a] are interpreted as equivalent to
 %[abcde...z]. Added some scanf tests.

---
 dlls/msvcrt/scanf.h       | 14 +++++++++-----
 dlls/msvcrt/tests/scanf.c | 15 ++++++++++++++-
 2 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/dlls/msvcrt/scanf.h b/dlls/msvcrt/scanf.h
index 2d0225f204..88c954b62f 100644
--- a/dlls/msvcrt/scanf.h
+++ b/dlls/msvcrt/scanf.h
@@ -444,13 +444,17 @@ int _FUNCTION_ {
 			format++;
 		    }
                     while(*format && (*format != ']')) {
+			/* According to:
+			 * http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore98/html/_crt_scanf_width_specification.asp
+			 * "Note that %[a-z] and %[z-a] are interpreted as equivalent to %[abcde...z]." */
 			if((*format == '-') && (*(format + 1) != ']')) {
-			    int n = 0;
-			    for(;(n + *(format - 1)) < *(format + 1); n++)
-				RtlSetBits(&bitMask, n + *(format - 1), 1);
+			    if ((*(format - 1)) < *(format + 1))
+				RtlSetBits(&bitMask, *(format - 1) +1 , *(format + 1) - *(format - 1));
+			    else
+				RtlSetBits(&bitMask, *(format + 1)    , *(format - 1) - *(format + 1));			      
 			    format++;
-			}
-			RtlSetBits(&bitMask, *format, 1);
+			} else
+			    RtlSetBits(&bitMask, *format, 1);
 			format++;
 		    }
                     /* read until char is not suitable */
diff --git a/dlls/msvcrt/tests/scanf.c b/dlls/msvcrt/tests/scanf.c
index ee16c57008..f8fe5ceffa 100644
--- a/dlls/msvcrt/tests/scanf.c
+++ b/dlls/msvcrt/tests/scanf.c
@@ -57,19 +57,32 @@ static void test_sscanf( void )
     ok( sscanf(buffer, format, &result) == 1, "sscanf failed" );
     ok( result == 12, "sscanf reads %x instead of %x", result, 12 );
 
-    /*Check float */
+    /* Check float */
     ret = sprintf(buffer,"%f %f",res1, res2);
     ret = sscanf(buffer,"%f%f",&res11, &res12);
     ok( (res11 == res1) && (res12 == res2), "Error reading floats");
+
+    /* check strings */
     ret = sprintf(buffer," %s", pname);
     ret = sscanf(buffer,"%*c%[^\n]",buffer1);
     ok( ret == 1, "Error with format \"%s\"","%*c%[^\n]");
     ok( strncmp(pname,buffer1,strlen(buffer1)) == 0, "Error with \"%s\" \"%s\"",pname, buffer1);
+
+    ret = sscanf("abcefgdh","%*[a-cg-e]%c",&buffer[0]);
+    ok( ret == 1, "Error with format \"%s\"","%*[a-cg-e]%c");
+    ok( buffer[0] == 'd', "Error with \"abcefgdh\" \"%c\"", buffer[0]);
+
+    ret = sscanf("abcefgdh","%*[a-cd-dg-e]%c",&buffer[0]);
+    ok( ret == 1, "Error with format \"%s\"","%*[a-cd-dg-e]%c");
+    ok( buffer[0] == 'h', "Error with \"abcefgdh\" \"%c\"", buffer[0]);
+
+    /* check digits */
     ret = sprintf(buffer,"%d:%d:%d",hour,min,sec);
     ret = sscanf(buffer,"%d%n",&number,&number_so_far);
     ok(ret == 1 , "problem with format arg \"%%d%%n\"");
     ok(number == hour,"Read wrong arg %d instead of %d",number, hour);
     ok(number_so_far == 2,"Read wrong arg for \"%%n\" %d instead of 2",number_so_far);
+
     ret = sscanf(buffer+2,"%*c%n",&number_so_far);
     ok(ret == 0 , "problem with format arg \"%%*c%%n\"");
     ok(number_so_far == 1,"Read wrong arg for \"%%n\" %d instead of 2",number_so_far);