From a4ec0593547920a9bb13b799d3f3795278efba01 Mon Sep 17 00:00:00 2001 From: Dmitry Timoshkov Date: Fri, 6 Sep 2013 17:03:03 +0900 Subject: [PATCH] ntdll/tests: Add some tests for negative file offsets. --- dlls/ntdll/tests/file.c | 181 +++++++++++++++++++++++++++++++++++++--- 1 file changed, 168 insertions(+), 13 deletions(-) diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index cde299cafa..86f8a77893 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls/ntdll/tests/file.c @@ -1921,13 +1921,14 @@ static void test_NtCreateFile(void) static void test_read_write(void) { - static const char contents[] = "1234567890abcd"; + static const char contents[14] = "1234567890abcd"; char buf[256]; HANDLE hfile; OVERLAPPED ovl; IO_STATUS_BLOCK iob; - DWORD ret, bytes, status; + DWORD ret, bytes, status, off; LARGE_INTEGER offset; + LONG i; iob.Status = -1; iob.Information = -1; @@ -1964,10 +1965,38 @@ static void test_read_write(void) iob.Status = -1; iob.Information = -1; - status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents, sizeof(contents), NULL, NULL); + status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents, 7, NULL, NULL); ok(status == STATUS_SUCCESS, "NtWriteFile error %#x\n", status); ok(iob.Status == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#x\n", iob.Status); - ok(iob.Information == sizeof(contents), "expected sizeof(contents), got %lu\n", iob.Information); + ok(iob.Information == 7, "expected 7, got %lu\n", iob.Information); + + SetFilePointer(hfile, 0, NULL, FILE_BEGIN); + + iob.Status = -1; + iob.Information = -1; + offset.QuadPart = (LONGLONG)-1 /* FILE_WRITE_TO_END_OF_FILE */; + status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents + 7, sizeof(contents) - 7, &offset, NULL); +todo_wine + ok(status == STATUS_SUCCESS, "NtWriteFile error %#x\n", status); +todo_wine + ok(iob.Status == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#x\n", iob.Status); +todo_wine + ok(iob.Information == sizeof(contents) - 7, "expected sizeof(contents)-7, got %lu\n", iob.Information); + + /* FIXME: Remove once Wine is fixed */ + if (status != STATUS_SUCCESS) + { + iob.Status = -1; + iob.Information = -1; + offset.QuadPart = 7; + status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents + 7, sizeof(contents) - 7, &offset, NULL); + ok(status == STATUS_SUCCESS, "NtWriteFile error %#x\n", status); + ok(iob.Status == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#x\n", iob.Status); + ok(iob.Information == sizeof(contents) - 7, "expected sizeof(contents)-7, got %lu\n", iob.Information); + } + + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == sizeof(contents), "expected sizeof(contents), got %u\n", off); bytes = 0xdeadbeef; SetLastError(0xdeadbeef); @@ -1985,6 +2014,19 @@ static void test_read_write(void) ok(bytes == sizeof(contents), "bytes %u\n", bytes); ok(!memcmp(contents, buf, sizeof(contents)), "file contents mismatch\n"); + for (i = -20; i < -1; i++) + { + if (i == -2) continue; + + iob.Status = -1; + iob.Information = -1; + offset.QuadPart = (LONGLONG)i; + status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents, sizeof(contents), &offset, NULL); + ok(status == STATUS_INVALID_PARAMETER, "%d: expected STATUS_INVALID_PARAMETER, got %#x\n", i, status); + ok(iob.Status == -1, "expected -1, got %#x\n", iob.Status); + ok(iob.Information == -1, "expected -1, got %ld\n", iob.Information); + } + SetFilePointer(hfile, sizeof(contents) - 4, NULL, FILE_BEGIN); iob.Status = -1; @@ -1995,6 +2037,18 @@ static void test_read_write(void) ok(iob.Status == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#x\n", iob.Status); ok(iob.Information == 4, "expected 4, got %lu\n", iob.Information); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == sizeof(contents), "expected sizeof(contents), got %u\n", off); + + iob.Status = -1; + iob.Information = -1; + status = pNtReadFile(hfile, 0, NULL, NULL, &iob, buf, sizeof(buf), NULL, NULL); + ok(status == STATUS_END_OF_FILE, "expected STATUS_END_OF_FILE, got %#x\n", status); +todo_wine + ok(iob.Status == STATUS_END_OF_FILE, "expected STATUS_END_OF_FILE, got %#x\n", iob.Status); +todo_wine + ok(iob.Information == 0, "expected 0, got %lu\n", iob.Information); + SetFilePointer(hfile, 0, NULL, FILE_BEGIN); bytes = 0; @@ -2005,6 +2059,9 @@ static void test_read_write(void) ok(!memcmp(contents, buf, sizeof(contents) - 4), "file contents mismatch\n"); ok(!memcmp(buf + sizeof(contents) - 4, "DCBA", 4), "file contents mismatch\n"); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == sizeof(contents), "expected sizeof(contents), got %u\n", off); + SetFilePointer(hfile, 0, NULL, FILE_BEGIN); bytes = 0; @@ -2013,6 +2070,9 @@ static void test_read_write(void) ok(ret, "WriteFile error %d\n", GetLastError()); ok(bytes == sizeof(contents), "bytes %u\n", bytes); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == sizeof(contents), "expected sizeof(contents), got %u\n", off); + iob.Status = -1; iob.Information = -1; status = pNtReadFile(hfile, 0, NULL, NULL, &iob, buf, sizeof(buf), NULL, NULL); @@ -2022,6 +2082,19 @@ todo_wine todo_wine ok(iob.Information == 0, "expected 0, got %lu\n", iob.Information); + for (i = -20; i < 0; i++) + { + if (i == -2) continue; + + iob.Status = -1; + iob.Information = -1; + offset.QuadPart = (LONGLONG)i; + status = pNtReadFile(hfile, 0, NULL, NULL, &iob, buf, sizeof(buf), &offset, NULL); + ok(status == STATUS_INVALID_PARAMETER, "%d: expected STATUS_INVALID_PARAMETER, got %#x\n", i, status); + ok(iob.Status == -1, "expected -1, got %#x\n", iob.Status); + ok(iob.Information == -1, "expected -1, got %ld\n", iob.Information); + } + iob.Status = -1; iob.Information = -1; offset.QuadPart = (LONGLONG)-2 /* FILE_USE_FILE_POINTER_POSITION */; @@ -2041,6 +2114,9 @@ todo_wine ok(bytes == sizeof(contents), "bytes %u\n", bytes); ok(!memcmp(contents, buf, sizeof(contents)), "file contents mismatch\n"); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == sizeof(contents), "expected sizeof(contents), got %u\n", off); + iob.Status = -1; iob.Information = -1; status = pNtReadFile(hfile, 0, NULL, NULL, &iob, buf, sizeof(buf), NULL, NULL); @@ -2059,6 +2135,9 @@ todo_wine ok(iob.Information == sizeof(contents), "expected sizeof(contents), got %lu\n", iob.Information); ok(!memcmp(contents, buf, sizeof(contents)), "file contents mismatch\n"); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == sizeof(contents), "expected sizeof(contents), got %u\n", off); + iob.Status = -1; iob.Information = -1; offset.QuadPart = sizeof(contents) - 4; @@ -2067,6 +2146,9 @@ todo_wine ok(iob.Status == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#x\n", iob.Status); ok(iob.Information == 4, "expected 4, got %lu\n", iob.Information); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == sizeof(contents), "expected sizeof(contents), got %u\n", off); + iob.Status = -1; iob.Information = -1; offset.QuadPart = 0; @@ -2077,6 +2159,9 @@ todo_wine ok(!memcmp(contents, buf, sizeof(contents) - 4), "file contents mismatch\n"); ok(!memcmp(buf + sizeof(contents) - 4, "DCBA", 4), "file contents mismatch\n"); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == sizeof(contents), "expected sizeof(contents), got %u\n", off); + S(U(ovl)).Offset = sizeof(contents) - 4; S(U(ovl)).OffsetHigh = 0; ovl.hEvent = 0; @@ -2086,6 +2171,9 @@ todo_wine ok(ret, "WriteFile error %d\n", GetLastError()); ok(bytes == 4, "bytes %u\n", bytes); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == sizeof(contents), "expected sizeof(contents), got %u\n", off); + S(U(ovl)).Offset = 0; S(U(ovl)).OffsetHigh = 0; ovl.Internal = -1; @@ -2101,6 +2189,9 @@ todo_wine ok(!memcmp(contents, buf, sizeof(contents) - 4), "file contents mismatch\n"); ok(!memcmp(buf + sizeof(contents) - 4, "ABCD", 4), "file contents mismatch\n"); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == sizeof(contents), "expected sizeof(contents), got %u\n", off); + CloseHandle(hfile); hfile = create_temp_file(FILE_FLAG_OVERLAPPED); @@ -2120,6 +2211,20 @@ todo_wine ok(iob.Status == -1, "expected -1, got %#x\n", iob.Status); ok(iob.Information == -1, "expected -1, got %ld\n", iob.Information); + for (i = -20; i < -1; i++) + { + /* FIXME: Remove once Wine is fixed */ + if (i == -2) continue; + + iob.Status = -1; + iob.Information = -1; + offset.QuadPart = (LONGLONG)i; + status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents, sizeof(contents), &offset, NULL); + ok(status == STATUS_INVALID_PARAMETER, "%d: expected STATUS_INVALID_PARAMETER, got %#x\n", i, status); + ok(iob.Status == -1, "expected -1, got %#x\n", iob.Status); + ok(iob.Information == -1, "expected -1, got %ld\n", iob.Information); + } + iob.Status = -1; iob.Information = -1; offset.QuadPart = (LONGLONG)-2 /* FILE_USE_FILE_POINTER_POSITION */; @@ -2155,6 +2260,9 @@ todo_wine ret = WaitForSingleObject(hfile, 3000); ok(ret == WAIT_OBJECT_0, "WaitForSingleObject error %d\n", ret); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + bytes = 0xdeadbeef; SetLastError(0xdeadbeef); ret = ReadFile(hfile, buf, sizeof(buf), &bytes, NULL); @@ -2169,13 +2277,16 @@ todo_wine ok(iob.Status == -1, "expected -1, got %#x\n", iob.Status); ok(iob.Information == -1, "expected -1, got %ld\n", iob.Information); - iob.Status = -1; - iob.Information = -1; - offset.QuadPart = (LONGLONG)-2 /* FILE_USE_FILE_POINTER_POSITION */; - status = pNtReadFile(hfile, 0, NULL, NULL, &iob, buf, sizeof(buf), &offset, NULL); - ok(status == STATUS_INVALID_PARAMETER, "expected STATUS_INVALID_PARAMETER, got %#x\n", status); - ok(iob.Status == -1, "expected -1, got %#x\n", iob.Status); - ok(iob.Information == -1, "expected -1, got %ld\n", iob.Information); + for (i = -20; i < 0; i++) + { + iob.Status = -1; + iob.Information = -1; + offset.QuadPart = (LONGLONG)i; + status = pNtReadFile(hfile, 0, NULL, NULL, &iob, buf, sizeof(buf), &offset, NULL); + ok(status == STATUS_INVALID_PARAMETER, "%d: expected STATUS_INVALID_PARAMETER, got %#x\n", i, status); + ok(iob.Status == -1, "expected -1, got %#x\n", iob.Status); + ok(iob.Information == -1, "expected -1, got %ld\n", iob.Information); + } offset.QuadPart = sizeof(contents); S(U(ovl)).Offset = offset.u.LowPart; @@ -2203,6 +2314,9 @@ todo_wine ok((NTSTATUS)ovl.Internal == STATUS_END_OF_FILE, "expected STATUS_END_OF_FILE, got %#lx\n", ovl.Internal); ok(ovl.InternalHigh == 0, "expected 0, got %lu\n", ovl.InternalHigh); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + bytes = 0xdeadbeef; ret = GetOverlappedResult(hfile, &ovl, &bytes, TRUE); ok(!ret, "GetOverlappedResult should report FALSE\n"); @@ -2211,6 +2325,9 @@ todo_wine ok((NTSTATUS)ovl.Internal == STATUS_END_OF_FILE, "expected STATUS_END_OF_FILE, got %#lx\n", ovl.Internal); ok(ovl.InternalHigh == 0, "expected 0, got %lu\n", ovl.InternalHigh); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + iob.Status = -1; iob.Information = -1; offset.QuadPart = sizeof(contents); @@ -2219,6 +2336,9 @@ todo_wine ok(iob.Status == STATUS_END_OF_FILE, "expected STATUS_END_OF_FILE, got %#x\n", iob.Status); ok(iob.Information == 0, "expected 0, got %lu\n", iob.Information); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + S(U(ovl)).Offset = offset.u.LowPart; S(U(ovl)).OffsetHigh = offset.u.HighPart; ovl.Internal = iob.Status; @@ -2232,7 +2352,8 @@ todo_wine ok((NTSTATUS)ovl.Internal == STATUS_END_OF_FILE, "expected STATUS_END_OF_FILE, got %#lx\n", ovl.Internal); ok(ovl.InternalHigh == 0, "expected 0, got %lu\n", ovl.InternalHigh); - SetFilePointer(hfile, 0, NULL, FILE_BEGIN); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); S(U(ovl)).Offset = 0; S(U(ovl)).OffsetHigh = 0; @@ -2248,6 +2369,9 @@ todo_wine ok((NTSTATUS)ovl.Internal == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#lx\n", ovl.Internal); ok(ovl.InternalHigh == sizeof(contents), "expected sizeof(contents), got %lu\n", ovl.InternalHigh); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + bytes = 0xdeadbeef; ret = GetOverlappedResult(hfile, &ovl, &bytes, TRUE); ok(ret, "GetOverlappedResult error %d\n", GetLastError()); @@ -2256,17 +2380,30 @@ todo_wine ok(ovl.InternalHigh == sizeof(contents), "expected sizeof(contents), got %lu\n", ovl.InternalHigh); ok(!memcmp(contents, buf, sizeof(contents)), "file contents mismatch\n"); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + + SetFilePointer(hfile, sizeof(contents) - 4, NULL, FILE_BEGIN); + SetEndOfFile(hfile); + SetFilePointer(hfile, 0, NULL, FILE_BEGIN); + iob.Status = -1; iob.Information = -1; - offset.QuadPart = sizeof(contents) - 4; + offset.QuadPart = (LONGLONG)-1 /* FILE_WRITE_TO_END_OF_FILE */; status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, "DCBA", 4, &offset, NULL); ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* before Vista */, "expected STATUS_PENDING, got %#x\n", status); ok(iob.Status == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#x\n", iob.Status); ok(iob.Information == 4, "expected 4, got %lu\n", iob.Information); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + ret = WaitForSingleObject(hfile, 3000); ok(ret == WAIT_OBJECT_0, "WaitForSingleObject error %d\n", ret); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + iob.Status = -1; iob.Information = -1; offset.QuadPart = 0; @@ -2275,11 +2412,17 @@ todo_wine ok(iob.Status == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#x\n", iob.Status); ok(iob.Information == sizeof(contents), "expected sizeof(contents), got %lu\n", iob.Information); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + ret = WaitForSingleObject(hfile, 3000); ok(ret == WAIT_OBJECT_0, "WaitForSingleObject error %d\n", ret); ok(!memcmp(contents, buf, sizeof(contents) - 4), "file contents mismatch\n"); ok(!memcmp(buf + sizeof(contents) - 4, "DCBA", 4), "file contents mismatch\n"); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + S(U(ovl)).Offset = sizeof(contents) - 4; S(U(ovl)).OffsetHigh = 0; ovl.Internal = -1; @@ -2294,6 +2437,9 @@ todo_wine ok((NTSTATUS)ovl.Internal == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#lx\n", ovl.Internal); ok(ovl.InternalHigh == 4, "expected 4, got %lu\n", ovl.InternalHigh); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + bytes = 0xdeadbeef; ret = GetOverlappedResult(hfile, &ovl, &bytes, TRUE); ok(ret, "GetOverlappedResult error %d\n", GetLastError()); @@ -2301,6 +2447,9 @@ todo_wine ok((NTSTATUS)ovl.Internal == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#lx\n", ovl.Internal); ok(ovl.InternalHigh == 4, "expected 4, got %lu\n", ovl.InternalHigh); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + S(U(ovl)).Offset = 0; S(U(ovl)).OffsetHigh = 0; ovl.Internal = -1; @@ -2315,6 +2464,9 @@ todo_wine ok((NTSTATUS)ovl.Internal == STATUS_SUCCESS, "expected STATUS_SUCCESS, got %#lx\n", ovl.Internal); ok(ovl.InternalHigh == sizeof(contents), "expected sizeof(contents), got %lu\n", ovl.InternalHigh); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + bytes = 0xdeadbeef; ret = GetOverlappedResult(hfile, &ovl, &bytes, TRUE); ok(ret, "GetOverlappedResult error %d\n", GetLastError()); @@ -2324,6 +2476,9 @@ todo_wine ok(!memcmp(contents, buf, sizeof(contents) - 4), "file contents mismatch\n"); ok(!memcmp(buf + sizeof(contents) - 4, "ABCD", 4), "file contents mismatch\n"); + off = SetFilePointer(hfile, 0, NULL, FILE_CURRENT); + ok(off == 0, "expected 0, got %u\n", off); + CloseHandle(hfile); }