reactos/wine
1
0
Fork 0
mirror of https://github.com/reactos/wine.git synced 2024-11-24 20:30:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

dplayx: Fix a possible memory leak on error path (Coverity).

Browse Source 
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Nikolay Sivov 2015-11-22 18:31:20 +03:00 committed by Alexandre Julliard
parent 3acac5b221
commit bd9701add8
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
dlls/dplayx/dplay.c
View File

@ -1593,17 +1593,12 @@ static HRESULT DP_IF_CreatePlayer( IDirectPlayImpl *This, void *lpMsgHdr, DPID *
player total */
lpPData = DP_CreatePlayer( This, lpidPlayer, lpPlayerName, dwCreateFlags,
hEvent, bAnsi );
if( lpPData == NULL )
{
return DPERR_CANTADDPLAYER;
}
/* Create the list object and link it in */
lpPList = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof( *lpPList ) );
if( lpPList == NULL )
if( !lpPData || !lpPList )
{
FIXME( "Memory leak\n" );
HeapFree( GetProcessHeap(), 0, lpPData );
HeapFree( GetProcessHeap(), 0, lpPList );
return DPERR_CANTADDPLAYER;
}