reactos/wine
1
0
Fork 0
mirror of https://github.com/reactos/wine.git synced 2025-02-17 19:39:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

msi: An empty string is equivalent to nil, so handle this in the optimised WHERE_execute path.

Browse Source
This commit is contained in:
Robert Shearman 2006-06-05 01:41:04 +01:00 committed by Alexandre Julliard
parent c9779ca16b
commit d70db020a6
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
dlls/msi/where.c
View File

@ -265,11 +265,17 @@ static UINT WHERE_execute( struct tagMSIVIEW *view, MSIRECORD *record )
if ((col_cond->type == EXPR_COL_NUMBER_STRING) && (val_cond->type == EXPR_SVAL))
{
col = col_cond->u.col_number;
r = msi_string2idW(wv->db->strings, val_cond->u.sval, &value);
if (r != ERROR_SUCCESS)
/* special case for "" - translate it into nil */
if (!val_cond->u.sval[0])
value = 0;
else
{
TRACE("no id for %s, assuming it doesn't exist in the table\n", debugstr_w(wv->cond->u.expr.right->u.sval));
return ERROR_SUCCESS;
r = msi_string2idW(wv->db->strings, val_cond->u.sval, &value);
if (r != ERROR_SUCCESS)
{
TRACE("no id for %s, assuming it doesn't exist in the table\n", debugstr_w(wv->cond->u.expr.right->u.sval));
return ERROR_SUCCESS;
}
}
do