diff --git a/dlls/d3d8/cubetexture.c b/dlls/d3d8/cubetexture.c index 84a1e412ba..895f20d6a2 100644 --- a/dlls/d3d8/cubetexture.c +++ b/dlls/d3d8/cubetexture.c @@ -57,9 +57,11 @@ static ULONG WINAPI IDirect3DCubeTexture8Impl_Release(LPDIRECT3DCUBETEXTURE8 ifa if (ref == 0) { TRACE("Releasing child %p\n", This->wineD3DCubeTexture); - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); IWineD3DCubeTexture_Destroy(This->wineD3DCubeTexture, D3D8CB_DestroySurface); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + IUnknown_Release(This->parentDevice); HeapFree(GetProcessHeap(), 0, This); } @@ -73,14 +75,15 @@ static HRESULT WINAPI IDirect3DCubeTexture8Impl_GetDevice(LPDIRECT3DCUBETEXTURE8 HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DCubeTexture_GetDevice(This->wineD3DCubeTexture, &wined3d_device); if (SUCCEEDED(hr)) { IWineD3DDevice_GetParent(wined3d_device, (IUnknown **)ppDevice); IWineD3DDevice_Release(wined3d_device); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); + return hr; } @@ -89,9 +92,10 @@ static HRESULT WINAPI IDirect3DCubeTexture8Impl_SetPrivateData(LPDIRECT3DCUBETEX HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DCubeTexture_SetPrivateData(This->wineD3DCubeTexture,refguid,pData,SizeOfData,Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -100,9 +104,10 @@ static HRESULT WINAPI IDirect3DCubeTexture8Impl_GetPrivateData(LPDIRECT3DCUBETEX HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DCubeTexture_GetPrivateData(This->wineD3DCubeTexture,refguid,pData,pSizeOfData); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -111,9 +116,10 @@ static HRESULT WINAPI IDirect3DCubeTexture8Impl_FreePrivateData(LPDIRECT3DCUBETE HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DCubeTexture_FreePrivateData(This->wineD3DCubeTexture,refguid); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -122,9 +128,10 @@ static DWORD WINAPI IDirect3DCubeTexture8Impl_SetPriority(LPDIRECT3DCUBETEXTURE8 DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DCubeTexture_SetPriority(This->wineD3DCubeTexture, PriorityNew); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -133,9 +140,10 @@ static DWORD WINAPI IDirect3DCubeTexture8Impl_GetPriority(LPDIRECT3DCUBETEXTURE8 DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DCubeTexture_GetPriority(This->wineD3DCubeTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -143,9 +151,9 @@ static void WINAPI IDirect3DCubeTexture8Impl_PreLoad(LPDIRECT3DCUBETEXTURE8 ifac IDirect3DCubeTexture8Impl *This = (IDirect3DCubeTexture8Impl *)iface; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DCubeTexture_PreLoad(This->wineD3DCubeTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); } static D3DRESOURCETYPE WINAPI IDirect3DCubeTexture8Impl_GetType(LPDIRECT3DCUBETEXTURE8 iface) { @@ -153,9 +161,10 @@ static D3DRESOURCETYPE WINAPI IDirect3DCubeTexture8Impl_GetType(LPDIRECT3DCUBETE D3DRESOURCETYPE type; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); type = IWineD3DCubeTexture_GetType(This->wineD3DCubeTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return type; } @@ -165,9 +174,10 @@ static DWORD WINAPI IDirect3DCubeTexture8Impl_SetLOD(LPDIRECT3DCUBETEXTURE8 ifac DWORD lod; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); lod = IWineD3DCubeTexture_SetLOD(This->wineD3DCubeTexture, LODNew); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return lod; } @@ -176,9 +186,10 @@ static DWORD WINAPI IDirect3DCubeTexture8Impl_GetLOD(LPDIRECT3DCUBETEXTURE8 ifac DWORD lod; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); lod = IWineD3DCubeTexture_GetLOD((LPDIRECT3DBASETEXTURE8) This); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return lod; } @@ -187,9 +198,10 @@ static DWORD WINAPI IDirect3DCubeTexture8Impl_GetLevelCount(LPDIRECT3DCUBETEXTUR DWORD cnt; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); cnt = IWineD3DCubeTexture_GetLevelCount(This->wineD3DCubeTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return cnt; } @@ -201,9 +213,9 @@ static HRESULT WINAPI IDirect3DCubeTexture8Impl_GetLevelDesc(LPDIRECT3DCUBETEXTU TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DCubeTexture_GetLevelDesc(This->wineD3DCubeTexture, Level, &wined3ddesc); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (SUCCEEDED(hr)) { @@ -227,13 +239,14 @@ static HRESULT WINAPI IDirect3DCubeTexture8Impl_GetCubeMapSurface(LPDIRECT3DCUBE TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hrc = IWineD3DCubeTexture_GetCubeMapSurface(This->wineD3DCubeTexture, (WINED3DCUBEMAP_FACES) FaceType, Level, &mySurface); if (hrc == D3D_OK && NULL != ppCubeMapSurface) { IWineD3DCubeTexture_GetParent(mySurface, (IUnknown **)ppCubeMapSurface); IWineD3DCubeTexture_Release(mySurface); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hrc; } @@ -242,9 +255,10 @@ static HRESULT WINAPI IDirect3DCubeTexture8Impl_LockRect(LPDIRECT3DCUBETEXTURE8 HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DCubeTexture_LockRect(This->wineD3DCubeTexture, (WINED3DCUBEMAP_FACES) FaceType, Level, (WINED3DLOCKED_RECT *) pLockedRect, pRect, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -253,9 +267,10 @@ static HRESULT WINAPI IDirect3DCubeTexture8Impl_UnlockRect(LPDIRECT3DCUBETEXTURE HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DCubeTexture_UnlockRect(This->wineD3DCubeTexture, (WINED3DCUBEMAP_FACES) FaceType, Level); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -264,9 +279,10 @@ static HRESULT WINAPI IDirect3DCubeTexture8Impl_AddDirtyRect(LPDIRECT3DCUBETEXTU HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DCubeTexture_AddDirtyRect(This->wineD3DCubeTexture, (WINED3DCUBEMAP_FACES) FaceType, pDirtyRect); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } diff --git a/dlls/d3d8/d3d8_main.c b/dlls/d3d8/d3d8_main.c index 02d9bae8e2..3a2eac2c46 100644 --- a/dlls/d3d8/d3d8_main.c +++ b/dlls/d3d8/d3d8_main.c @@ -24,15 +24,6 @@ #include "d3d8_private.h" #include "wine/debug.h" -static CRITICAL_SECTION_DEBUG d3d8_cs_debug = -{ - 0, 0, &d3d8_cs, - { &d3d8_cs_debug.ProcessLocksList, - &d3d8_cs_debug.ProcessLocksList }, - 0, 0, { (DWORD_PTR)(__FILE__ ": d3d8_cs") } -}; -CRITICAL_SECTION d3d8_cs = { &d3d8_cs_debug, -1, 0, 0, 0, 0 }; - WINE_DEFAULT_DEBUG_CHANNEL(d3d8); HRESULT WINAPI D3D8GetSWInfo(void) { @@ -48,7 +39,8 @@ IDirect3D8* WINAPI Direct3DCreate8(UINT SDKVersion) { IDirect3D8Impl* object; TRACE("SDKVersion = %x\n", SDKVersion); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirect3D8Impl)); object->lpVtbl = &Direct3D8_Vtbl; @@ -56,7 +48,8 @@ IDirect3D8* WINAPI Direct3DCreate8(UINT SDKVersion) { object->WineD3D = WineDirect3DCreate(8, (IUnknown *)object); TRACE("Created Direct3D object @ %p, WineObj @ %p\n", object, object->WineD3D); - LeaveCriticalSection(&d3d8_cs); + + wined3d_mutex_unlock(); if (!object->WineD3D) { diff --git a/dlls/d3d8/d3d8_private.h b/dlls/d3d8/d3d8_private.h index a3aeff1aff..e916f141e7 100644 --- a/dlls/d3d8/d3d8_private.h +++ b/dlls/d3d8/d3d8_private.h @@ -122,9 +122,6 @@ typedef struct IDirect3DVertexShaderDeclarationImpl IDirect3DVertexShaderDeclara /* Advance declaration of structures to satisfy compiler */ typedef struct IDirect3DVertexShader8Impl IDirect3DVertexShader8Impl; -/* Global critical section */ -extern CRITICAL_SECTION d3d8_cs; - /* =========================================================================== The interfaces themselves =========================================================================== */ diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index 2e854f7b1b..a5658af2e0 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -299,7 +299,9 @@ static ULONG WINAPI IDirect3DDevice8Impl_Release(LPDIRECT3DDEVICE8 iface) { unsigned i; TRACE("Releasing wined3d device %p\n", This->WineD3DDevice); - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); + This->inDestruction = TRUE; for(i = 0; i < This->numConvertedDecls; i++) { @@ -311,7 +313,8 @@ static ULONG WINAPI IDirect3DDevice8Impl_Release(LPDIRECT3DDEVICE8 iface) { IWineD3DDevice_Release(This->WineD3DDevice); HeapFree(GetProcessHeap(), 0, This->handle_table.entries); HeapFree(GetProcessHeap(), 0, This); - LeaveCriticalSection(&d3d8_cs); + + wined3d_mutex_unlock(); } return ref; } @@ -322,9 +325,11 @@ static HRESULT WINAPI IDirect3DDevice8Impl_TestCooperativeLevel(LPDIRECT3DDEVICE HRESULT hr; TRACE("(%p) : Relay\n", This); - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hr = IWineD3DDevice_TestCooperativeLevel(This->WineD3DDevice); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -333,9 +338,11 @@ static UINT WINAPI IDirect3DDevice8Impl_GetAvailableTextureMem(LPDIRECT3DDEVICE HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hr = IWineD3DDevice_GetAvailableTextureMem(This->WineD3DDevice); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -344,9 +351,11 @@ static HRESULT WINAPI IDirect3DDevice8Impl_ResourceManagerDiscardBytes(LPDIRECT3 HRESULT hr; TRACE("(%p) : Relay bytes(%d)\n", This, Bytes); - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hr = IWineD3DDevice_EvictManagedResources(This->WineD3DDevice); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -361,7 +370,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetDirect3D(LPDIRECT3DDEVICE8 iface, return D3DERR_INVALIDCALL; } - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetDirect3D(This->WineD3DDevice, &pWineD3D); if (hr == D3D_OK && pWineD3D != NULL) { @@ -371,8 +380,9 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetDirect3D(LPDIRECT3DDEVICE8 iface, FIXME("Call to IWineD3DDevice_GetDirect3D failed\n"); *ppD3D8 = NULL; } + wined3d_mutex_unlock(); + TRACE("(%p) returning %p\n",This , *ppD3D8); - LeaveCriticalSection(&d3d8_cs); return hr; } @@ -391,9 +401,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetDeviceCaps(LPDIRECT3DDEVICE8 iface return D3DERR_INVALIDCALL; /* well this is what MSDN says to return */ } - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hrc = IWineD3DDevice_GetDeviceCaps(This->WineD3DDevice, pWineCaps); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + fixup_caps(pWineCaps); WINECAPSTOD3D8CAPS(pCaps, pWineCaps) HeapFree(GetProcessHeap(), 0, pWineCaps); @@ -407,9 +418,9 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetDisplayMode(LPDIRECT3DDEVICE8 ifac HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetDisplayMode(This->WineD3DDevice, 0, (WINED3DDISPLAYMODE *) pMode); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (SUCCEEDED(hr)) pMode->Format = d3dformat_from_wined3dformat(pMode->Format); @@ -421,9 +432,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetCreationParameters(LPDIRECT3DDEVIC HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetCreationParameters(This->WineD3DDevice, (WINED3DDEVICE_CREATION_PARAMETERS *) pParameters); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -437,9 +449,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetCursorProperties(LPDIRECT3DDEVICE8 return WINED3DERR_INVALIDCALL; } - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetCursorProperties(This->WineD3DDevice,XHotSpot,YHotSpot,pSurface->wineD3DSurface); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -447,9 +460,9 @@ static void WINAPI IDirect3DDevice8Impl_SetCursorPosition(LPDIRECT3DDEVICE8 ifac IDirect3DDevice8Impl *This = (IDirect3DDevice8Impl *)iface; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DDevice_SetCursorPosition(This->WineD3DDevice, XScreenSpace, YScreenSpace, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); } static BOOL WINAPI IDirect3DDevice8Impl_ShowCursor(LPDIRECT3DDEVICE8 iface, BOOL bShow) { @@ -457,9 +470,10 @@ static BOOL WINAPI IDirect3DDevice8Impl_ShowCursor(LPDIRECT3DDEVICE8 iface, BOOL BOOL ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DDevice_ShowCursor(This->WineD3DDevice, bShow); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -502,10 +516,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CreateAdditionalSwapChain(LPDIRECT3DD localParameters.PresentationInterval = pPresentationParameters->FullScreen_PresentationInterval; localParameters.AutoRestoreDisplayMode = TRUE; - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hrc = IWineD3DDevice_CreateSwapChain(This->WineD3DDevice, &localParameters, &object->wineD3DSwapChain, (IUnknown *)object, SURFACE_OPENGL); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); pPresentationParameters->BackBufferWidth = localParameters.BackBufferWidth; pPresentationParameters->BackBufferHeight = localParameters.BackBufferHeight; @@ -557,9 +571,9 @@ static HRESULT WINAPI IDirect3DDevice8Impl_Reset(LPDIRECT3DDEVICE8 iface, D3DPRE localParameters.PresentationInterval = pPresentationParameters->FullScreen_PresentationInterval; localParameters.AutoRestoreDisplayMode = TRUE; - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_Reset(This->WineD3DDevice, &localParameters); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); pPresentationParameters->BackBufferWidth = localParameters.BackBufferWidth; pPresentationParameters->BackBufferHeight = localParameters.BackBufferHeight; @@ -583,9 +597,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_Present(LPDIRECT3DDEVICE8 iface, CONS HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_Present(This->WineD3DDevice, pSourceRect, pDestRect, hDestWindowOverride, pDirtyRegion); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -596,13 +611,14 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetBackBuffer(LPDIRECT3DDEVICE8 iface TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); rc = IWineD3DDevice_GetBackBuffer(This->WineD3DDevice, 0, BackBuffer, (WINED3DBACKBUFFER_TYPE) Type, &retSurface); if (rc == D3D_OK && NULL != retSurface && NULL != ppBackBuffer) { IWineD3DSurface_GetParent(retSurface, (IUnknown **)ppBackBuffer); IWineD3DSurface_Release(retSurface); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return rc; } @@ -611,9 +627,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetRasterStatus(LPDIRECT3DDEVICE8 ifa HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetRasterStatus(This->WineD3DDevice, 0, (WINED3DRASTER_STATUS *) pRasterStatus); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -622,9 +639,9 @@ static void WINAPI IDirect3DDevice8Impl_SetGammaRamp(LPDIRECT3DDEVICE8 iface, DW TRACE("(%p) Relay\n", This); /* Note: D3DGAMMARAMP is compatible with WINED3DGAMMARAMP */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DDevice_SetGammaRamp(This->WineD3DDevice, 0, Flags, (CONST WINED3DGAMMARAMP *) pRamp); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); } static void WINAPI IDirect3DDevice8Impl_GetGammaRamp(LPDIRECT3DDEVICE8 iface, D3DGAMMARAMP* pRamp) { @@ -632,9 +649,9 @@ static void WINAPI IDirect3DDevice8Impl_GetGammaRamp(LPDIRECT3DDEVICE8 iface, D3 TRACE("(%p) Relay\n", This); /* Note: D3DGAMMARAMP is compatible with WINED3DGAMMARAMP */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DDevice_GetGammaRamp(This->WineD3DDevice, 0, (WINED3DGAMMARAMP *) pRamp); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); } static HRESULT WINAPI IDirect3DDevice8Impl_CreateTexture(LPDIRECT3DDEVICE8 iface, UINT Width, UINT Height, UINT Levels, DWORD Usage, @@ -656,10 +673,11 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CreateTexture(LPDIRECT3DDEVICE8 iface object->lpVtbl = &Direct3DTexture8_Vtbl; object->ref = 1; - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hrc = IWineD3DDevice_CreateTexture(This->WineD3DDevice, Width, Height, Levels, Usage & WINED3DUSAGE_MASK, wined3dformat_from_d3dformat(Format), Pool, &object->wineD3DTexture, (IUnknown *)object); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (FAILED(hrc)) { /* free up object */ @@ -696,11 +714,12 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CreateVolumeTexture(LPDIRECT3DDEVICE8 object->lpVtbl = &Direct3DVolumeTexture8_Vtbl; object->ref = 1; - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hrc = IWineD3DDevice_CreateVolumeTexture(This->WineD3DDevice, Width, Height, Depth, Levels, Usage & WINED3DUSAGE_MASK, wined3dformat_from_d3dformat(Format), Pool, &object->wineD3DVolumeTexture, (IUnknown *)object); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (hrc != D3D_OK) { @@ -737,10 +756,11 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CreateCubeTexture(LPDIRECT3DDEVICE8 i object->lpVtbl = &Direct3DCubeTexture8_Vtbl; object->ref = 1; - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hr = IWineD3DDevice_CreateCubeTexture(This->WineD3DDevice, EdgeLength, Levels, Usage & WINED3DUSAGE_MASK, wined3dformat_from_d3dformat(Format), Pool, &object->wineD3DCubeTexture, (IUnknown *)object); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (hr != D3D_OK){ @@ -774,10 +794,12 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CreateVertexBuffer(LPDIRECT3DDEVICE8 object->lpVtbl = &Direct3DVertexBuffer8_Vtbl; object->ref = 1; - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hrc = IWineD3DDevice_CreateVertexBuffer(This->WineD3DDevice, Size, Usage & WINED3DUSAGE_MASK, 0 /* fvf for ddraw only */, (WINED3DPOOL)Pool, &object->wineD3DVertexBuffer, (IUnknown *)object); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + object->fvf = FVF; if (D3D_OK != hrc) { @@ -812,10 +834,11 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CreateIndexBuffer(LPDIRECT3DDEVICE8 i object->ref = 1; object->format = wined3dformat_from_d3dformat(Format); TRACE("Calling wined3d create index buffer\n"); - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hrc = IWineD3DDevice_CreateIndexBuffer(This->WineD3DDevice, Length, Usage & WINED3DUSAGE_MASK, (WINED3DPOOL)Pool, &object->wineD3DIndexBuffer, (IUnknown *)object); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (D3D_OK != hrc) { @@ -863,11 +886,12 @@ static HRESULT IDirect3DDevice8Impl_CreateSurface(LPDIRECT3DDEVICE8 iface, UINT TRACE("(%p) : w(%d) h(%d) fmt(%d) surf@%p\n", This, Width, Height, Format, *ppSurface); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hrc = IWineD3DDevice_CreateSurface(This->WineD3DDevice, Width, Height, wined3dformat_from_d3dformat(Format), Lockable, Discard, Level, &object->wineD3DSurface, Usage & WINED3DUSAGE_MASK, (WINED3DPOOL)Pool, MultiSample, MultisampleQuality, SURFACE_OPENGL, (IUnknown *)object); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + if (hrc != D3D_OK || NULL == object->wineD3DSurface) { /* free up object */ FIXME("(%p) call to IWineD3DDevice_CreateSurface failed\n", This); @@ -931,7 +955,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CopyRects(LPDIRECT3DDEVICE8 iface, ID /* Check that the source texture is in WINED3DPOOL_SYSTEMMEM and the destination texture is in WINED3DPOOL_DEFAULT */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DSurface_GetDesc(Source->wineD3DSurface, &winedesc); srcFormat = winedesc.format; srcWidth = winedesc.width; @@ -946,7 +970,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CopyRects(LPDIRECT3DDEVICE8 iface, ID /* Check that the source and destination formats match */ if (srcFormat != destFormat && WINED3DFMT_UNKNOWN != destFormat) { WARN("(%p) source %p format must match the dest %p format, returning WINED3DERR_INVALIDCALL\n", iface, pSourceSurface, pDestinationSurface); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return WINED3DERR_INVALIDCALL; } else if (WINED3DFMT_UNKNOWN == destFormat) { TRACE("(%p) : Converting destination surface from WINED3DFMT_UNKNOWN to the source format\n", iface); @@ -970,7 +994,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CopyRects(LPDIRECT3DDEVICE8 iface, ID } } } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return hr; } @@ -980,9 +1004,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_UpdateTexture(LPDIRECT3DDEVICE8 iface HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_UpdateTexture(This->WineD3DDevice, ((IDirect3DBaseTexture8Impl *)pSourceTexture)->wineD3DBaseTexture, ((IDirect3DBaseTexture8Impl *)pDestinationTexture)->wineD3DBaseTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -998,9 +1023,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetFrontBuffer(LPDIRECT3DDEVICE8 ifac return D3DERR_INVALIDCALL; } - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetFrontBufferData(This->WineD3DDevice, 0, destSurface->wineD3DSurface); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1012,7 +1038,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetRenderTarget(LPDIRECT3DDEVICE8 ifa HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetDepthStencilSurface(This->WineD3DDevice, &original_ds); if (hr == WINED3D_OK || hr == WINED3DERR_NOTFOUND) @@ -1024,7 +1050,8 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetRenderTarget(LPDIRECT3DDEVICE8 ifa } if (original_ds) IWineD3DSurface_Release(original_ds); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1038,7 +1065,8 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetRenderTarget(LPDIRECT3DDEVICE8 i if (ppRenderTarget == NULL) { return D3DERR_INVALIDCALL; } - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hr = IWineD3DDevice_GetRenderTarget(This->WineD3DDevice, 0, &pRenderTarget); if (hr == D3D_OK && pRenderTarget != NULL) { @@ -1048,7 +1076,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetRenderTarget(LPDIRECT3DDEVICE8 i FIXME("Call to IWineD3DDevice_GetRenderTarget failed\n"); *ppRenderTarget = NULL; } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return hr; } @@ -1063,7 +1091,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetDepthStencilSurface(LPDIRECT3DDE return D3DERR_INVALIDCALL; } - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr=IWineD3DDevice_GetDepthStencilSurface(This->WineD3DDevice,&pZStencilSurface); if (hr == WINED3D_OK) { IWineD3DSurface_GetParent(pZStencilSurface,(IUnknown**)ppZStencilSurface); @@ -1073,7 +1101,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetDepthStencilSurface(LPDIRECT3DDE FIXME("Call to IWineD3DDevice_GetDepthStencilSurface failed with 0x%08x\n", hr); *ppZStencilSurface = NULL; } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return hr; } @@ -1083,9 +1111,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_BeginScene(LPDIRECT3DDEVICE8 iface) { HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_BeginScene(This->WineD3DDevice); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1094,9 +1123,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_EndScene(LPDIRECT3DDEVICE8 iface) { HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_EndScene(This->WineD3DDevice); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1106,9 +1136,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_Clear(LPDIRECT3DDEVICE8 iface, DWORD TRACE("(%p) Relay\n" , This); /* Note: D3DRECT is compatible with WINED3DRECT */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_Clear(This->WineD3DDevice, Count, (CONST WINED3DRECT*) pRects, Flags, Color, Z, Stencil); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1118,9 +1149,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetTransform(LPDIRECT3DDEVICE8 iface, TRACE("(%p) Relay\n" , This); /* Note: D3DMATRIX is compatible with WINED3DMATRIX */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetTransform(This->WineD3DDevice, State, (CONST WINED3DMATRIX*) lpMatrix); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1130,9 +1162,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetTransform(LPDIRECT3DDEVICE8 iface, TRACE("(%p) Relay\n" , This); /* Note: D3DMATRIX is compatible with WINED3DMATRIX */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetTransform(This->WineD3DDevice, State, (WINED3DMATRIX*) pMatrix); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1142,9 +1175,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_MultiplyTransform(LPDIRECT3DDEVICE8 i TRACE("(%p) Relay\n" , This); /* Note: D3DMATRIX is compatible with WINED3DMATRIX */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_MultiplyTransform(This->WineD3DDevice, State, (CONST WINED3DMATRIX*) pMatrix); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1154,9 +1188,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetViewport(LPDIRECT3DDEVICE8 iface, TRACE("(%p) Relay\n" , This); /* Note: D3DVIEWPORT8 is compatible with WINED3DVIEWPORT */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetViewport(This->WineD3DDevice, (const WINED3DVIEWPORT *)pViewport); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1166,9 +1201,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetViewport(LPDIRECT3DDEVICE8 iface, TRACE("(%p) Relay\n" , This); /* Note: D3DVIEWPORT8 is compatible with WINED3DVIEWPORT */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetViewport(This->WineD3DDevice, (WINED3DVIEWPORT *)pViewport); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1178,9 +1214,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetMaterial(LPDIRECT3DDEVICE8 iface, TRACE("(%p) Relay\n" , This); /* Note: D3DMATERIAL8 is compatible with WINED3DMATERIAL */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetMaterial(This->WineD3DDevice, (const WINED3DMATERIAL *)pMaterial); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1190,9 +1227,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetMaterial(LPDIRECT3DDEVICE8 iface, TRACE("(%p) Relay\n" , This); /* Note: D3DMATERIAL8 is compatible with WINED3DMATERIAL */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetMaterial(This->WineD3DDevice, (WINED3DMATERIAL *)pMaterial); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1202,9 +1240,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetLight(LPDIRECT3DDEVICE8 iface, DWO TRACE("(%p) Relay\n" , This); /* Note: D3DLIGHT8 is compatible with WINED3DLIGHT */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetLight(This->WineD3DDevice, Index, (const WINED3DLIGHT *)pLight); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1214,9 +1253,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetLight(LPDIRECT3DDEVICE8 iface, DWO TRACE("(%p) Relay\n" , This); /* Note: D3DLIGHT8 is compatible with WINED3DLIGHT */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetLight(This->WineD3DDevice, Index, (WINED3DLIGHT *)pLight); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1225,9 +1265,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_LightEnable(LPDIRECT3DDEVICE8 iface, HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetLightEnable(This->WineD3DDevice, Index, Enable); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1236,9 +1277,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetLightEnable(LPDIRECT3DDEVICE8 ifac HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetLightEnable(This->WineD3DDevice, Index, pEnable); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1247,9 +1289,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetClipPlane(LPDIRECT3DDEVICE8 iface, HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetClipPlane(This->WineD3DDevice, Index, pPlane); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1258,9 +1301,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetClipPlane(LPDIRECT3DDEVICE8 iface, HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetClipPlane(This->WineD3DDevice, Index, pPlane); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1269,9 +1313,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetRenderState(LPDIRECT3DDEVICE8 ifac HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetRenderState(This->WineD3DDevice, State, Value); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1280,9 +1325,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetRenderState(LPDIRECT3DDEVICE8 ifac HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetRenderState(This->WineD3DDevice, State, pValue); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1291,9 +1337,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_BeginStateBlock(LPDIRECT3DDEVICE8 ifa HRESULT hr; TRACE("(%p)\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_BeginStateBlock(This->WineD3DDevice); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1308,11 +1355,11 @@ static HRESULT WINAPI IDirect3DDevice8Impl_EndStateBlock(LPDIRECT3DDEVICE8 iface /* Tell wineD3D to endstateblock before anything else (in case we run out * of memory later and cause locking problems) */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_EndStateBlock(This->WineD3DDevice , &wineD3DStateBlock); if (hr != D3D_OK) { WARN("IWineD3DDevice_EndStateBlock returned an error\n"); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return hr; } @@ -1324,7 +1371,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_EndStateBlock(LPDIRECT3DDEVICE8 iface object->wineD3DStateBlock = wineD3DStateBlock; *pToken = d3d8_allocate_handle(&This->handle_table, object, D3D8_HANDLE_SB); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (*pToken == D3D8_INVALID_HANDLE) { @@ -1346,16 +1393,17 @@ static HRESULT WINAPI IDirect3DDevice8Impl_ApplyStateBlock(LPDIRECT3DDEVICE8 ifa TRACE("(%p) %#x Relay\n", This, Token); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); pSB = d3d8_get_object(&This->handle_table, Token - 1, D3D8_HANDLE_SB); if (!pSB) { WARN("Invalid handle (%#x) passed.\n", Token); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return D3DERR_INVALIDCALL; } hr = IWineD3DStateBlock_Apply(pSB->wineD3DStateBlock); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1366,16 +1414,17 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CaptureStateBlock(LPDIRECT3DDEVICE8 i TRACE("(%p) %#x Relay\n", This, Token); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); pSB = d3d8_get_object(&This->handle_table, Token - 1, D3D8_HANDLE_SB); if (!pSB) { WARN("Invalid handle (%#x) passed.\n", Token); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return D3DERR_INVALIDCALL; } hr = IWineD3DStateBlock_Capture(pSB->wineD3DStateBlock); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1385,9 +1434,9 @@ static HRESULT WINAPI IDirect3DDevice8Impl_DeleteStateBlock(LPDIRECT3DDEVICE8 if TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); pSB = d3d8_free_handle(&This->handle_table, Token - 1, D3D8_HANDLE_SB); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (!pSB) { @@ -1430,19 +1479,19 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CreateStateBlock(IDirect3DDevice8 *if object->lpVtbl = &Direct3DStateBlock8_Vtbl; object->ref = 1; - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_CreateStateBlock(This->WineD3DDevice, (WINED3DSTATEBLOCKTYPE)Type, &object->wineD3DStateBlock, (IUnknown *)object); if (FAILED(hr)) { - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); ERR("IWineD3DDevice_CreateStateBlock failed, hr %#x\n", hr); HeapFree(GetProcessHeap(), 0, object); return hr; } *handle = d3d8_allocate_handle(&This->handle_table, object, D3D8_HANDLE_SB); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (*handle == D3D8_INVALID_HANDLE) { @@ -1462,9 +1511,11 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetClipStatus(LPDIRECT3DDEVICE8 iface HRESULT hr; TRACE("(%p) Relay\n" , This); /* FIXME: Verify that D3DCLIPSTATUS8 ~= WINED3DCLIPSTATUS */ - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hr = IWineD3DDevice_SetClipStatus(This->WineD3DDevice, (const WINED3DCLIPSTATUS *)pClipStatus); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1473,9 +1524,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetClipStatus(LPDIRECT3DDEVICE8 iface HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetClipStatus(This->WineD3DDevice, (WINED3DCLIPSTATUS *)pClipStatus); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1490,7 +1542,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetTexture(LPDIRECT3DDEVICE8 iface, D return D3DERR_INVALIDCALL; } - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); rc = IWineD3DDevice_GetTexture(This->WineD3DDevice, Stage, &retTexture); if (rc == D3D_OK && NULL != retTexture) { IWineD3DBaseTexture_GetParent(retTexture, (IUnknown **)ppTexture); @@ -1499,7 +1551,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetTexture(LPDIRECT3DDEVICE8 iface, D FIXME("Call to get texture (%d) failed (%p)\n", Stage, retTexture); *ppTexture = NULL; } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return rc; } @@ -1509,10 +1561,11 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetTexture(LPDIRECT3DDEVICE8 iface, D HRESULT hr; TRACE("(%p) Relay %d %p\n" , This, Stage, pTexture); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetTexture(This->WineD3DDevice, Stage, pTexture==NULL ? NULL : ((IDirect3DBaseTexture8Impl *)pTexture)->wineD3DBaseTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1560,12 +1613,11 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetTextureStageState(LPDIRECT3DDEVI HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); - + wined3d_mutex_lock(); if (l->sampler_state) hr = IWineD3DDevice_GetSamplerState(This->WineD3DDevice, Stage, l->state, pValue); else hr = IWineD3DDevice_GetTextureStageState(This->WineD3DDevice, Stage, l->state, pValue); + wined3d_mutex_unlock(); - LeaveCriticalSection(&d3d8_cs); return hr; } @@ -1575,12 +1627,11 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetTextureStageState(LPDIRECT3DDEVICE HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); - + wined3d_mutex_lock(); if (l->sampler_state) hr = IWineD3DDevice_SetSamplerState(This->WineD3DDevice, Stage, l->state, Value); else hr = IWineD3DDevice_SetTextureStageState(This->WineD3DDevice, Stage, l->state, Value); + wined3d_mutex_unlock(); - LeaveCriticalSection(&d3d8_cs); return hr; } @@ -1589,9 +1640,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_ValidateDevice(LPDIRECT3DDEVICE8 ifac HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_ValidateDevice(This->WineD3DDevice, pNumPasses); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1606,9 +1658,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetPaletteEntries(LPDIRECT3DDEVICE8 i HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetPaletteEntries(This->WineD3DDevice, PaletteNumber, pEntries); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1617,9 +1670,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetPaletteEntries(LPDIRECT3DDEVICE8 i HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetPaletteEntries(This->WineD3DDevice, PaletteNumber, pEntries); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1628,9 +1682,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetCurrentTexturePalette(LPDIRECT3DDE HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetCurrentTexturePalette(This->WineD3DDevice, PaletteNumber); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1639,9 +1694,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetCurrentTexturePalette(LPDIRECT3D HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetCurrentTexturePalette(This->WineD3DDevice, PaletteNumber); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1650,11 +1706,12 @@ static HRESULT WINAPI IDirect3DDevice8Impl_DrawPrimitive(LPDIRECT3DDEVICE8 iface HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DDevice_SetPrimitiveType(This->WineD3DDevice, PrimitiveType); hr = IWineD3DDevice_DrawPrimitive(This->WineD3DDevice, StartVertex, vertex_count_from_primitive_count(PrimitiveType, PrimitiveCount)); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1664,11 +1721,12 @@ static HRESULT WINAPI IDirect3DDevice8Impl_DrawIndexedPrimitive(LPDIRECT3DDEVICE HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DDevice_SetPrimitiveType(This->WineD3DDevice, PrimitiveType); hr = IWineD3DDevice_DrawIndexedPrimitive(This->WineD3DDevice, MinVertexIndex, NumVertices, startIndex, vertex_count_from_primitive_count(PrimitiveType, primCount)); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1677,12 +1735,13 @@ static HRESULT WINAPI IDirect3DDevice8Impl_DrawPrimitiveUP(LPDIRECT3DDEVICE8 ifa HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DDevice_SetPrimitiveType(This->WineD3DDevice, PrimitiveType); hr = IWineD3DDevice_DrawPrimitiveUP(This->WineD3DDevice, vertex_count_from_primitive_count(PrimitiveType, PrimitiveCount), pVertexStreamZeroData, VertexStreamZeroStride); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1694,12 +1753,13 @@ static HRESULT WINAPI IDirect3DDevice8Impl_DrawIndexedPrimitiveUP(LPDIRECT3DDEVI HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DDevice_SetPrimitiveType(This->WineD3DDevice, PrimitiveType); hr = IWineD3DDevice_DrawIndexedPrimitiveUP(This->WineD3DDevice, MinVertexIndex, NumVertexIndices, vertex_count_from_primitive_count(PrimitiveType, PrimitiveCount), pIndexData, wined3dformat_from_d3dformat(IndexDataFormat), pVertexStreamZeroData, VertexStreamZeroStride); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1709,9 +1769,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_ProcessVertices(LPDIRECT3DDEVICE8 ifa IDirect3DVertexBuffer8Impl *dest = (IDirect3DVertexBuffer8Impl *) pDestBuffer; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_ProcessVertices(This->WineD3DDevice,SrcStartIndex, DestIndex, VertexCount, dest->wineD3DVertexBuffer, NULL, Flags, dest->fvf); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -1746,10 +1807,11 @@ static HRESULT IDirect3DDevice8Impl_CreateVertexDeclaration(IDirect3DDevice8 *if CopyMemory(object->elements, declaration, object->elements_size); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_CreateVertexDeclaration(This->WineD3DDevice, &object->wined3d_vertex_declaration, (IUnknown *)object, wined3d_elements, wined3d_element_count); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + HeapFree(GetProcessHeap(), 0, wined3d_elements); if (FAILED(hr)) { @@ -1807,12 +1869,12 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CreateVertexShader(LPDIRECT3DDEVICE8 return D3DERR_INVALIDCALL; } - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); handle = d3d8_allocate_handle(&This->handle_table, object, D3D8_HANDLE_VS); if (handle == D3D8_INVALID_HANDLE) { ERR("Failed to allocate shader handle\n"); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); IDirect3DVertexDeclaration8_Release(object->vertex_declaration); HeapFree(GetProcessHeap(), 0, object); *ppShader = 0; @@ -1846,7 +1908,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CreateVertexShader(LPDIRECT3DDEVICE8 } } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return hrc; } @@ -1930,29 +1992,31 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetVertexShader(LPDIRECT3DDEVICE8 ifa if (VS_HIGHESTFIXEDFXF >= pShader) { TRACE("Setting FVF, %#x\n", pShader); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DDevice_SetVertexDeclaration(This->WineD3DDevice, IDirect3DDevice8Impl_FindDecl(This, pShader)->wined3d_vertex_declaration); IWineD3DDevice_SetVertexShader(This->WineD3DDevice, NULL); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return D3D_OK; } TRACE("Setting shader\n"); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); shader = d3d8_get_object(&This->handle_table, pShader - (VS_HIGHESTFIXEDFXF + 1), D3D8_HANDLE_VS); if (!shader) { WARN("Invalid handle (%#x) passed.\n", pShader); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return D3DERR_INVALIDCALL; } hr = IWineD3DDevice_SetVertexDeclaration(This->WineD3DDevice, ((IDirect3DVertexDeclaration8Impl *)shader->vertex_declaration)->wined3d_vertex_declaration); if (SUCCEEDED(hr)) hr = IWineD3DDevice_SetVertexShader(This->WineD3DDevice, shader->wineD3DVertexShader); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); TRACE("Returning hr %#x\n", hr); @@ -1966,12 +2030,12 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetVertexShader(LPDIRECT3DDEVICE8 ifa HRESULT hrc; TRACE("(%p) : Relay device@%p\n", This, This->WineD3DDevice); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hrc = IWineD3DDevice_GetVertexDeclaration(This->WineD3DDevice, &wined3d_declaration); if (FAILED(hrc)) { - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); WARN("(%p) : Call to IWineD3DDevice_GetVertexDeclaration failed %#x (device %p)\n", This, hrc, This->WineD3DDevice); return hrc; @@ -1979,14 +2043,14 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetVertexShader(LPDIRECT3DDEVICE8 ifa if (!wined3d_declaration) { - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); *ppShader = 0; return D3D_OK; } hrc = IWineD3DVertexDeclaration_GetParent(wined3d_declaration, (IUnknown **)&d3d8_declaration); IWineD3DVertexDeclaration_Release(wined3d_declaration); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (SUCCEEDED(hrc)) { *ppShader = ((IDirect3DVertexDeclaration8Impl *)d3d8_declaration)->shader_handle; @@ -2005,13 +2069,13 @@ static HRESULT WINAPI IDirect3DDevice8Impl_DeleteVertexShader(LPDIRECT3DDEVICE TRACE("(%p) : pShader %#x\n", This, pShader); - EnterCriticalSection(&d3d8_cs); - + wined3d_mutex_lock(); shader = d3d8_free_handle(&This->handle_table, pShader - (VS_HIGHESTFIXEDFXF + 1), D3D8_HANDLE_VS); if (!shader) { WARN("Invalid handle (%#x) passed.\n", pShader); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return D3DERR_INVALIDCALL; } @@ -2023,7 +2087,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_DeleteVertexShader(LPDIRECT3DDEVICE IWineD3DVertexShader_Release(cur); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (IUnknown_Release((IUnknown *)shader)) { @@ -2044,9 +2108,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetVertexShaderConstant(LPDIRECT3DDEV return D3DERR_INVALIDCALL; } - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetVertexShaderConstantF(This->WineD3DDevice, Register, pConstantData, ConstantCount); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -2061,9 +2126,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetVertexShaderConstant(LPDIRECT3DDEV return D3DERR_INVALIDCALL; } - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetVertexShaderConstantF(This->WineD3DDevice, Register, pConstantData, ConstantCount); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -2074,10 +2140,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetVertexShaderDeclaration(LPDIRECT3D TRACE("(%p) : pVertexShader 0x%08x, pData %p, *pSizeOfData %u\n", This, pVertexShader, pData, *pSizeOfData); - EnterCriticalSection(&d3d8_cs); - + wined3d_mutex_lock(); shader = d3d8_get_object(&This->handle_table, pVertexShader - (VS_HIGHESTFIXEDFXF + 1), D3D8_HANDLE_VS); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + if (!shader) { WARN("Invalid handle (%#x) passed.\n", pVertexShader); @@ -2110,26 +2176,26 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetVertexShaderFunction(LPDIRECT3DDEV TRACE("(%p) : pVertexShader %#x, pData %p, pSizeOfData %p\n", This, pVertexShader, pData, pSizeOfData); - EnterCriticalSection(&d3d8_cs); - + wined3d_mutex_lock(); shader = d3d8_get_object(&This->handle_table, pVertexShader - (VS_HIGHESTFIXEDFXF + 1), D3D8_HANDLE_VS); if (!shader) { WARN("Invalid handle (%#x) passed.\n", pVertexShader); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return D3DERR_INVALIDCALL; } if (!shader->wineD3DVertexShader) { - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); *pSizeOfData = 0; return D3D_OK; } hr = IWineD3DVertexShader_GetFunction(shader->wineD3DVertexShader, pData, pSizeOfData); + wined3d_mutex_unlock(); - LeaveCriticalSection(&d3d8_cs); return hr; } @@ -2139,18 +2205,19 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetIndices(LPDIRECT3DDEVICE8 iface, I IDirect3DIndexBuffer8Impl *ib = (IDirect3DIndexBuffer8Impl *)pIndexData; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); /* WineD3D takes an INT(due to d3d9), but d3d8 uses UINTs. Do I have to add a check here that * the UINT doesn't cause an overflow in the INT? It seems rather unlikely because such large * vertex buffers can't be created to address them with an index that requires the 32nd bit * (4 Byte minimum vertex size * 2^31-1 -> 8 gb buffer. The index sign would be the least * problem) */ + wined3d_mutex_lock(); IWineD3DDevice_SetBaseVertexIndex(This->WineD3DDevice, baseVertexIndex); hr = IWineD3DDevice_SetIndices(This->WineD3DDevice, ib ? ib->wineD3DIndexBuffer : NULL, ib ? ib->format : WINED3DFMT_UNKNOWN); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -2165,8 +2232,8 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetIndices(LPDIRECT3DDEVICE8 iface, I return D3DERR_INVALIDCALL; } - EnterCriticalSection(&d3d8_cs); /* The case from UINT to INT is safe because d3d8 will never set negative values */ + wined3d_mutex_lock(); IWineD3DDevice_GetBaseVertexIndex(This->WineD3DDevice, (INT *) pBaseVertexIndex); rc = IWineD3DDevice_GetIndices(This->WineD3DDevice, &retIndexData); if (SUCCEEDED(rc) && retIndexData) { @@ -2176,7 +2243,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetIndices(LPDIRECT3DDEVICE8 iface, I if (FAILED(rc)) FIXME("Call to GetIndices failed\n"); *ppIndexData = NULL; } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return rc; } @@ -2203,12 +2270,12 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CreatePixelShader(LPDIRECT3DDEVICE8 i object->ref = 1; object->lpVtbl = &Direct3DPixelShader8_Vtbl; - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_CreatePixelShader(This->WineD3DDevice, pFunction, NULL, &object->wineD3DPixelShader, (IUnknown *)object); if (FAILED(hr)) { - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); FIXME("(%p) call to IWineD3DDevice_CreatePixelShader failed\n", This); HeapFree(GetProcessHeap(), 0 , object); *ppShader = 0; @@ -2216,7 +2283,8 @@ static HRESULT WINAPI IDirect3DDevice8Impl_CreatePixelShader(LPDIRECT3DDEVICE8 i } handle = d3d8_allocate_handle(&This->handle_table, object, D3D8_HANDLE_PS); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + if (handle == D3D8_INVALID_HANDLE) { ERR("Failed to allocate shader handle\n"); @@ -2237,12 +2305,12 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetPixelShader(LPDIRECT3DDEVICE8 ifac TRACE("(%p) : pShader %#x\n", This, pShader); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); if (!pShader) { hr = IWineD3DDevice_SetPixelShader(This->WineD3DDevice, NULL); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return hr; } @@ -2250,13 +2318,14 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetPixelShader(LPDIRECT3DDEVICE8 ifac if (!shader) { WARN("Invalid handle (%#x) passed.\n", pShader); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return D3DERR_INVALIDCALL; } TRACE("(%p) : Setting shader %p\n", This, shader); hr = IWineD3DDevice_SetPixelShader(This->WineD3DDevice, shader->wineD3DPixelShader); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -2271,7 +2340,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetPixelShader(LPDIRECT3DDEVICE8 ifac return D3DERR_INVALIDCALL; } - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hrc = IWineD3DDevice_GetPixelShader(This->WineD3DDevice, &object); if (D3D_OK == hrc && NULL != object) { IDirect3DPixelShader8Impl *d3d8_shader; @@ -2282,9 +2351,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetPixelShader(LPDIRECT3DDEVICE8 ifac } else { *ppShader = 0; } + wined3d_mutex_unlock(); TRACE("(%p) : returning %#x\n", This, *ppShader); - LeaveCriticalSection(&d3d8_cs); + return hrc; } @@ -2295,13 +2365,13 @@ static HRESULT WINAPI IDirect3DDevice8Impl_DeletePixelShader(LPDIRECT3DDEVICE8 i TRACE("(%p) : pShader %#x\n", This, pShader); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); shader = d3d8_free_handle(&This->handle_table, pShader - (VS_HIGHESTFIXEDFXF + 1), D3D8_HANDLE_PS); if (!shader) { WARN("Invalid handle (%#x) passed.\n", pShader); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return D3D_OK; } @@ -2313,7 +2383,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_DeletePixelShader(LPDIRECT3DDEVICE8 i IWineD3DPixelShader_Release(cur); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (IUnknown_Release((IUnknown *)shader)) { @@ -2328,9 +2398,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetPixelShaderConstant(LPDIRECT3DDE HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetPixelShaderConstantF(This->WineD3DDevice, Register, pConstantData, ConstantCount); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -2339,9 +2410,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetPixelShaderConstant(LPDIRECT3DDEVI HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_GetPixelShaderConstantF(This->WineD3DDevice, Register, pConstantData, ConstantCount); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -2352,17 +2424,19 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetPixelShaderFunction(LPDIRECT3DDEVI TRACE("(%p) : pPixelShader %#x, pData %p, pSizeOfData %p\n", This, pPixelShader, pData, pSizeOfData); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); shader = d3d8_get_object(&This->handle_table, pPixelShader - (VS_HIGHESTFIXEDFXF + 1), D3D8_HANDLE_PS); if (!shader) { WARN("Invalid handle (%#x) passed.\n", pPixelShader); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return D3DERR_INVALIDCALL; } hr = IWineD3DPixelShader_GetFunction(shader->wineD3DPixelShader, pData, pSizeOfData); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -2371,9 +2445,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_DrawRectPatch(LPDIRECT3DDEVICE8 iface HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_DrawRectPatch(This->WineD3DDevice, Handle, pNumSegs, (CONST WINED3DRECTPATCH_INFO *)pRectPatchInfo); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -2382,9 +2457,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_DrawTriPatch(LPDIRECT3DDEVICE8 iface, HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_DrawTriPatch(This->WineD3DDevice, Handle, pNumSegs, (CONST WINED3DTRIPATCH_INFO *)pTriPatchInfo); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -2393,9 +2469,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_DeletePatch(LPDIRECT3DDEVICE8 iface, HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_DeletePatch(This->WineD3DDevice, Handle); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -2404,11 +2481,12 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetStreamSource(LPDIRECT3DDEVICE8 ifa HRESULT hr; TRACE("(%p) Relay\n" , This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DDevice_SetStreamSource(This->WineD3DDevice, StreamNumber, NULL == pStreamData ? NULL : ((IDirect3DVertexBuffer8Impl *)pStreamData)->wineD3DVertexBuffer, 0/* Offset in bytes */, Stride); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -2423,7 +2501,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetStreamSource(LPDIRECT3DDEVICE8 ifa return D3DERR_INVALIDCALL; } - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); rc = IWineD3DDevice_GetStreamSource(This->WineD3DDevice, StreamNumber, &retStream, 0 /* Offset in bytes */, pStride); if (rc == D3D_OK && NULL != retStream) { IWineD3DBuffer_GetParent(retStream, (IUnknown **)pStream); @@ -2434,7 +2512,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetStreamSource(LPDIRECT3DDEVICE8 ifa } *pStream = NULL; } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return rc; } diff --git a/dlls/d3d8/directx.c b/dlls/d3d8/directx.c index e294d16e13..3368794d73 100644 --- a/dlls/d3d8/directx.c +++ b/dlls/d3d8/directx.c @@ -71,9 +71,11 @@ static ULONG WINAPI IDirect3D8Impl_Release(LPDIRECT3D8 iface) { if (ref == 0) { TRACE("Releasing wined3d %p\n", This->WineD3D); - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); IWineD3D_Release(This->WineD3D); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + HeapFree(GetProcessHeap(), 0, This); } @@ -86,9 +88,10 @@ static HRESULT WINAPI IDirect3D8Impl_RegisterSoftwareDevice (LPDIRECT3D8 iface, HRESULT hr; TRACE("(%p)->(%p)\n", This, pInitializeFunction); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3D_RegisterSoftwareDevice(This->WineD3D, pInitializeFunction); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -97,9 +100,10 @@ static UINT WINAPI IDirect3D8Impl_GetAdapterCount (LPDIRECT3D8 iface) { HRESULT hr; TRACE("(%p)\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3D_GetAdapterCount(This->WineD3D); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -119,9 +123,9 @@ static HRESULT WINAPI IDirect3D8Impl_GetAdapterIdentifier(LPDIRECT3D8 iface, adapter_id.device_name = NULL; /* d3d9 only */ adapter_id.device_name_size = 0; /* d3d9 only */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3D_GetAdapterIdentifier(This->WineD3D, Adapter, Flags, &adapter_id); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); pIdentifier->DriverVersion = adapter_id.driver_version; pIdentifier->VendorId = adapter_id.vendor_id; @@ -139,9 +143,10 @@ static UINT WINAPI IDirect3D8Impl_GetAdapterModeCount (LPDIRECT3D8 iface,UINT Ad HRESULT hr; TRACE("(%p)->(%d)\n", This, Adapter); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3D_GetAdapterModeCount(This->WineD3D, Adapter, 0 /* format */); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -150,9 +155,9 @@ static HRESULT WINAPI IDirect3D8Impl_EnumAdapterModes (LPDIRECT3D8 iface, UINT A HRESULT hr; TRACE("(%p)->(%d, %d, %p)\n", This, Adapter, Mode, pMode); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3D_EnumAdapterModes(This->WineD3D, Adapter, WINED3DFMT_UNKNOWN, Mode, (WINED3DDISPLAYMODE *) pMode); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (SUCCEEDED(hr)) pMode->Format = d3dformat_from_wined3dformat(pMode->Format); @@ -164,9 +169,9 @@ static HRESULT WINAPI IDirect3D8Impl_GetAdapterDisplayMode (LPDIRECT3D8 iface, U HRESULT hr; TRACE("(%p)->(%d,%p)\n", This, Adapter, pMode); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3D_GetAdapterDisplayMode(This->WineD3D, Adapter, (WINED3DDISPLAYMODE *) pMode); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (SUCCEEDED(hr)) pMode->Format = d3dformat_from_wined3dformat(pMode->Format); @@ -180,10 +185,11 @@ static HRESULT WINAPI IDirect3D8Impl_CheckDeviceType (LPDIRECT3D8 i HRESULT hr; TRACE("(%p)->(%d, %d, %d, %d, %s)\n", This, Adapter, CheckType, DisplayFormat, BackBufferFormat, Windowed ? "true" : "false"); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3D_CheckDeviceType(This->WineD3D, Adapter, CheckType, wined3dformat_from_d3dformat(DisplayFormat), wined3dformat_from_d3dformat(BackBufferFormat), Windowed); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -214,10 +220,11 @@ static HRESULT WINAPI IDirect3D8Impl_CheckDeviceFormat (LPDIRECT3D8 i break; } - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3D_CheckDeviceFormat(This->WineD3D, Adapter, DeviceType, wined3dformat_from_d3dformat(AdapterFormat), Usage, WineD3DRType, wined3dformat_from_d3dformat(CheckFormat), SURFACE_OPENGL); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -228,10 +235,11 @@ static HRESULT WINAPI IDirect3D8Impl_CheckDeviceMultiSampleType(IDirect3D8 *ifac HRESULT hr; TRACE("(%p)-<(%d, %d, %d, %s, %d)\n", This, Adapter, DeviceType, SurfaceFormat, Windowed ? "true" : "false", MultiSampleType); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3D_CheckDeviceMultiSampleType(This->WineD3D, Adapter, DeviceType, wined3dformat_from_d3dformat(SurfaceFormat), Windowed, (WINED3DMULTISAMPLE_TYPE) MultiSampleType, NULL); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -242,11 +250,12 @@ static HRESULT WINAPI IDirect3D8Impl_CheckDepthStencilMatch(IDirect3D8 *iface, U HRESULT hr; TRACE("(%p)-<(%d, %d, %d, %d, %d)\n", This, Adapter, DeviceType, AdapterFormat, RenderTargetFormat, DepthStencilFormat); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3D_CheckDepthStencilMatch(This->WineD3D, Adapter, DeviceType, wined3dformat_from_d3dformat(AdapterFormat), wined3dformat_from_d3dformat(RenderTargetFormat), wined3dformat_from_d3dformat(DepthStencilFormat)); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -278,9 +287,11 @@ static HRESULT WINAPI IDirect3D8Impl_GetDeviceCaps(LPDIRECT3D8 iface, UINT Ada if(pWineCaps == NULL){ return D3DERR_INVALIDCALL; /*well this is what MSDN says to return*/ } - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hrc = IWineD3D_GetDeviceCaps(This->WineD3D, Adapter, DeviceType, pWineCaps); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + fixup_caps(pWineCaps); WINECAPSTOD3D8CAPS(pCaps, pWineCaps) HeapFree(GetProcessHeap(), 0, pWineCaps); @@ -294,9 +305,10 @@ static HMONITOR WINAPI IDirect3D8Impl_GetAdapterMonitor(LPDIRECT3D8 iface, UINT HMONITOR ret; TRACE("(%p)->(%d)\n", This, Adapter); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3D_GetAdapterMonitor(This->WineD3D, Adapter); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -362,14 +374,15 @@ static HRESULT WINAPI IDirect3D8Impl_CreateDevice(LPDIRECT3D8 iface, UINT Adapte *ppReturnedDeviceInterface = (IDirect3DDevice8 *)object; /* Allocate an associated WineD3DDevice object */ - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3D_CreateDevice(This->WineD3D, Adapter, DeviceType, hFocusWindow, BehaviourFlags, (IUnknown *)object, (IWineD3DDeviceParent *)&object->device_parent_vtbl, &object->WineD3DDevice); if (hr != D3D_OK) { HeapFree(GetProcessHeap(), 0, object); *ppReturnedDeviceInterface = NULL; - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -396,7 +409,7 @@ static HRESULT WINAPI IDirect3D8Impl_CreateDevice(LPDIRECT3D8 iface, UINT Adapte } hr = IWineD3DDevice_Init3D(object->WineD3DDevice, &localParameters); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); pPresentationParameters->BackBufferWidth = localParameters.BackBufferWidth; pPresentationParameters->BackBufferHeight = localParameters.BackBufferHeight; @@ -422,9 +435,11 @@ static HRESULT WINAPI IDirect3D8Impl_CreateDevice(LPDIRECT3D8 iface, UINT Adapte object->decls = HeapAlloc(GetProcessHeap(), 0, object->declArraySize * sizeof(*object->decls)); if(!object->decls) { ERR("Out of memory\n"); - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); IWineD3DDevice_Release(object->WineD3DDevice); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + HeapFree(GetProcessHeap(), 0, object); *ppReturnedDeviceInterface = NULL; hr = E_OUTOFMEMORY; diff --git a/dlls/d3d8/indexbuffer.c b/dlls/d3d8/indexbuffer.c index a0de5c5caf..b59b1ab292 100644 --- a/dlls/d3d8/indexbuffer.c +++ b/dlls/d3d8/indexbuffer.c @@ -56,9 +56,10 @@ static ULONG WINAPI IDirect3DIndexBuffer8Impl_Release(LPDIRECT3DINDEXBUFFER8 ifa TRACE("(%p) : ReleaseRef to %d\n", This, ref); if (ref == 0) { - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DBuffer_Release(This->wineD3DIndexBuffer); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + IUnknown_Release(This->parentDevice); HeapFree(GetProcessHeap(), 0, This); } @@ -72,14 +73,15 @@ static HRESULT WINAPI IDirect3DIndexBuffer8Impl_GetDevice(LPDIRECT3DINDEXBUFFER8 HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_GetDevice(This->wineD3DIndexBuffer, &wined3d_device); if (SUCCEEDED(hr)) { IWineD3DDevice_GetParent(wined3d_device, (IUnknown **)ppDevice); IWineD3DDevice_Release(wined3d_device); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -88,9 +90,10 @@ static HRESULT WINAPI IDirect3DIndexBuffer8Impl_SetPrivateData(LPDIRECT3DINDEXBU HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_SetPrivateData(This->wineD3DIndexBuffer, refguid, pData, SizeOfData, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -99,9 +102,10 @@ static HRESULT WINAPI IDirect3DIndexBuffer8Impl_GetPrivateData(LPDIRECT3DINDEXBU HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_GetPrivateData(This->wineD3DIndexBuffer, refguid, pData, pSizeOfData); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -110,9 +114,10 @@ static HRESULT WINAPI IDirect3DIndexBuffer8Impl_FreePrivateData(LPDIRECT3DINDEXB HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_FreePrivateData(This->wineD3DIndexBuffer, refguid); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -121,9 +126,10 @@ static DWORD WINAPI IDirect3DIndexBuffer8Impl_SetPriority(LPDIRECT3DINDEXBUFFER8 DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DBuffer_SetPriority(This->wineD3DIndexBuffer, PriorityNew); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -132,9 +138,10 @@ static DWORD WINAPI IDirect3DIndexBuffer8Impl_GetPriority(LPDIRECT3DINDEXBUFFER8 DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DBuffer_GetPriority(This->wineD3DIndexBuffer); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -142,9 +149,9 @@ static void WINAPI IDirect3DIndexBuffer8Impl_PreLoad(LPDIRECT3DINDEXBUFFER8 ifac IDirect3DIndexBuffer8Impl *This = (IDirect3DIndexBuffer8Impl *)iface; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DBuffer_PreLoad(This->wineD3DIndexBuffer); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); } static D3DRESOURCETYPE WINAPI IDirect3DIndexBuffer8Impl_GetType(LPDIRECT3DINDEXBUFFER8 iface) { @@ -160,9 +167,10 @@ static HRESULT WINAPI IDirect3DIndexBuffer8Impl_Lock(LPDIRECT3DINDEXBUFFER8 ifac HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_Map(This->wineD3DIndexBuffer, OffsetToLock, SizeToLock, ppbData, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -171,9 +179,10 @@ static HRESULT WINAPI IDirect3DIndexBuffer8Impl_Unlock(LPDIRECT3DINDEXBUFFER8 if HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_Unmap(This->wineD3DIndexBuffer); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -183,9 +192,9 @@ static HRESULT WINAPI IDirect3DIndexBuffer8Impl_GetDesc(LPDIRECT3DINDEXBUFFER8 i WINED3DBUFFER_DESC desc; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_GetDesc(This->wineD3DIndexBuffer, &desc); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (SUCCEEDED(hr)) { pDesc->Format = d3dformat_from_wined3dformat(This->format); diff --git a/dlls/d3d8/pixelshader.c b/dlls/d3d8/pixelshader.c index ae8d15fa63..2f0fb1c4c3 100644 --- a/dlls/d3d8/pixelshader.c +++ b/dlls/d3d8/pixelshader.c @@ -56,9 +56,10 @@ static ULONG WINAPI IDirect3DPixelShader8Impl_Release(IDirect3DPixelShader8 * if TRACE("(%p) : ReleaseRef to %d\n", This, ref); if (ref == 0) { - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DPixelShader_Release(This->wineD3DPixelShader); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + HeapFree(GetProcessHeap(), 0, This); } return ref; diff --git a/dlls/d3d8/stateblock.c b/dlls/d3d8/stateblock.c index ace9211e0a..04c4e48482 100644 --- a/dlls/d3d8/stateblock.c +++ b/dlls/d3d8/stateblock.c @@ -58,9 +58,10 @@ static ULONG WINAPI IDirect3DStateBlock8Impl_Release(IDirect3DStateBlock8 *iface TRACE("(%p) : ReleaseRef to %d\n", This, ref); if (ref == 0) { - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DStateBlock_Release(This->wineD3DStateBlock); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + HeapFree(GetProcessHeap(), 0, This); } return ref; @@ -74,16 +75,14 @@ static HRESULT WINAPI IDirect3DStateBlock8Impl_GetDevice(IDirect3DStateBlock8 *i TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); - + wined3d_mutex_lock(); hr = IWineD3DStateBlock_GetDevice(This->wineD3DStateBlock, &wined3d_device); if (SUCCEEDED(hr)) { IWineD3DDevice_GetParent(wined3d_device, (IUnknown **)ppDevice); IWineD3DDevice_Release(wined3d_device); } - - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return hr; } @@ -94,11 +93,9 @@ static HRESULT WINAPI IDirect3DStateBlock8Impl_Capture(IDirect3DStateBlock8 *ifa TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); - + wined3d_mutex_lock(); hr = IWineD3DStateBlock_Capture(This->wineD3DStateBlock); - - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return hr; } @@ -109,11 +106,9 @@ static HRESULT WINAPI IDirect3DStateBlock8Impl_Apply(IDirect3DStateBlock8 *iface TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); - + wined3d_mutex_lock(); hr = IWineD3DStateBlock_Apply(This->wineD3DStateBlock); - - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); return hr; } diff --git a/dlls/d3d8/surface.c b/dlls/d3d8/surface.c index c3aa11aef4..3185a1f88a 100644 --- a/dlls/d3d8/surface.c +++ b/dlls/d3d8/surface.c @@ -76,9 +76,10 @@ static ULONG WINAPI IDirect3DSurface8Impl_Release(LPDIRECT3DSURFACE8 iface) { if (This->parentDevice) IUnknown_Release(This->parentDevice); /* Implicit surfaces are destroyed with the device, not if refcount reaches 0. */ if (!This->isImplicit) { - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DSurface_Release(This->wineD3DSurface); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + HeapFree(GetProcessHeap(), 0, This); } } @@ -94,14 +95,15 @@ static HRESULT WINAPI IDirect3DSurface8Impl_GetDevice(LPDIRECT3DSURFACE8 iface, HRESULT hr; TRACE("(%p)->(%p)\n", This, ppDevice); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DSurface_GetDevice(This->wineD3DSurface, &wined3d_device); if (SUCCEEDED(hr)) { IWineD3DDevice_GetParent(wined3d_device, (IUnknown **)ppDevice); IWineD3DDevice_Release(wined3d_device); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -110,9 +112,10 @@ static HRESULT WINAPI IDirect3DSurface8Impl_SetPrivateData(LPDIRECT3DSURFACE8 if HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DSurface_SetPrivateData(This->wineD3DSurface, refguid, pData, SizeOfData, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -121,9 +124,10 @@ static HRESULT WINAPI IDirect3DSurface8Impl_GetPrivateData(LPDIRECT3DSURFACE8 if HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DSurface_GetPrivateData(This->wineD3DSurface, refguid, pData, pSizeOfData); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -132,9 +136,10 @@ static HRESULT WINAPI IDirect3DSurface8Impl_FreePrivateData(LPDIRECT3DSURFACE8 i HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DSurface_FreePrivateData(This->wineD3DSurface, refguid); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -159,9 +164,9 @@ static HRESULT WINAPI IDirect3DSurface8Impl_GetDesc(LPDIRECT3DSURFACE8 iface, D3 HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DSurface_GetDesc(This->wineD3DSurface, &wined3ddesc); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (SUCCEEDED(hr)) { @@ -184,7 +189,7 @@ static HRESULT WINAPI IDirect3DSurface8Impl_LockRect(LPDIRECT3DSURFACE8 iface, D TRACE("(%p) Relay\n", This); TRACE("(%p) calling IWineD3DSurface_LockRect %p %p %p %d\n", This, This->wineD3DSurface, pLockedRect, pRect, Flags); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); if (pRect) { D3DSURFACE_DESC desc; IDirect3DSurface8_GetDesc(iface, &desc); @@ -196,13 +201,15 @@ static HRESULT WINAPI IDirect3DSurface8Impl_LockRect(LPDIRECT3DSURFACE8 iface, D || (pRect->right > desc.Width) || (pRect->bottom > desc.Height)) { WARN("Trying to lock an invalid rectangle, returning D3DERR_INVALIDCALL\n"); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return D3DERR_INVALIDCALL; } } hr = IWineD3DSurface_LockRect(This->wineD3DSurface, (WINED3DLOCKED_RECT *) pLockedRect, pRect, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -211,9 +218,10 @@ static HRESULT WINAPI IDirect3DSurface8Impl_UnlockRect(LPDIRECT3DSURFACE8 iface) HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DSurface_UnlockRect(This->wineD3DSurface); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + switch(hr) { case WINEDDERR_NOTLOCKED: return D3DERR_INVALIDCALL; diff --git a/dlls/d3d8/swapchain.c b/dlls/d3d8/swapchain.c index 25d2a0ee34..67f3429cad 100644 --- a/dlls/d3d8/swapchain.c +++ b/dlls/d3d8/swapchain.c @@ -56,9 +56,10 @@ static ULONG WINAPI IDirect3DSwapChain8Impl_Release(LPDIRECT3DSWAPCHAIN8 iface) TRACE("(%p) : ReleaseRef to %d\n", This, ref); if (ref == 0) { - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DSwapChain_Destroy(This->wineD3DSwapChain, D3D8CB_DestroyRenderTarget); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + if (This->parentDevice) IUnknown_Release(This->parentDevice); HeapFree(GetProcessHeap(), 0, This); } @@ -71,9 +72,10 @@ static HRESULT WINAPI IDirect3DSwapChain8Impl_Present(LPDIRECT3DSWAPCHAIN8 iface HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DSwapChain_Present(This->wineD3DSwapChain, pSourceRect, pDestRect, hDestWindowOverride, pDirtyRegion, 0); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -84,13 +86,14 @@ static HRESULT WINAPI IDirect3DSwapChain8Impl_GetBackBuffer(LPDIRECT3DSWAPCHAIN8 TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hrc = IWineD3DSwapChain_GetBackBuffer(This->wineD3DSwapChain, iBackBuffer, (WINED3DBACKBUFFER_TYPE )Type, &mySurface); if (hrc == D3D_OK && NULL != mySurface) { IWineD3DSurface_GetParent(mySurface, (IUnknown **)ppBackBuffer); IWineD3DSurface_Release(mySurface); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hrc; } diff --git a/dlls/d3d8/texture.c b/dlls/d3d8/texture.c index cbfc95a1bb..c22c49111b 100644 --- a/dlls/d3d8/texture.c +++ b/dlls/d3d8/texture.c @@ -57,9 +57,10 @@ static ULONG WINAPI IDirect3DTexture8Impl_Release(LPDIRECT3DTEXTURE8 iface) { TRACE("(%p) : ReleaseRef to %d\n", This, ref); if (ref == 0) { - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DTexture_Destroy(This->wineD3DTexture, D3D8CB_DestroySurface); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + IUnknown_Release(This->parentDevice); HeapFree(GetProcessHeap(), 0, This); } @@ -72,14 +73,16 @@ static HRESULT WINAPI IDirect3DTexture8Impl_GetDevice(LPDIRECT3DTEXTURE8 iface, IWineD3DDevice *wined3d_device; HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hr = IWineD3DTexture_GetDevice(This->wineD3DTexture, &wined3d_device); if (SUCCEEDED(hr)) { IWineD3DDevice_GetParent(wined3d_device, (IUnknown **)ppDevice); IWineD3DDevice_Release(wined3d_device); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -88,9 +91,10 @@ static HRESULT WINAPI IDirect3DTexture8Impl_SetPrivateData(LPDIRECT3DTEXTURE8 if HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DTexture_SetPrivateData(This->wineD3DTexture, refguid, pData, SizeOfData, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -99,9 +103,10 @@ static HRESULT WINAPI IDirect3DTexture8Impl_GetPrivateData(LPDIRECT3DTEXTURE8 if HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DTexture_GetPrivateData(This->wineD3DTexture, refguid, pData, pSizeOfData); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -110,9 +115,10 @@ static HRESULT WINAPI IDirect3DTexture8Impl_FreePrivateData(LPDIRECT3DTEXTURE8 i HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DTexture_FreePrivateData(This->wineD3DTexture, refguid); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -121,9 +127,10 @@ static DWORD WINAPI IDirect3DTexture8Impl_SetPriority(LPDIRECT3DTEXTURE8 iface, DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DTexture_SetPriority(This->wineD3DTexture, PriorityNew); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -132,9 +139,10 @@ static DWORD WINAPI IDirect3DTexture8Impl_GetPriority(LPDIRECT3DTEXTURE8 iface) DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DTexture_GetPriority(This->wineD3DTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -142,9 +150,9 @@ static void WINAPI IDirect3DTexture8Impl_PreLoad(LPDIRECT3DTEXTURE8 iface) { IDirect3DTexture8Impl *This = (IDirect3DTexture8Impl *)iface; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DTexture_PreLoad(This->wineD3DTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); } static D3DRESOURCETYPE WINAPI IDirect3DTexture8Impl_GetType(LPDIRECT3DTEXTURE8 iface) { @@ -152,9 +160,10 @@ static D3DRESOURCETYPE WINAPI IDirect3DTexture8Impl_GetType(LPDIRECT3DTEXTURE8 i D3DRESOURCETYPE type; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); type = IWineD3DTexture_GetType(This->wineD3DTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return type; } @@ -164,9 +173,10 @@ static DWORD WINAPI IDirect3DTexture8Impl_SetLOD(LPDIRECT3DTEXTURE8 iface, DWORD DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DTexture_SetLOD(This->wineD3DTexture, LODNew); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -175,9 +185,10 @@ static DWORD WINAPI IDirect3DTexture8Impl_GetLOD(LPDIRECT3DTEXTURE8 iface) { DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DTexture_GetLOD(This->wineD3DTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -186,9 +197,10 @@ static DWORD WINAPI IDirect3DTexture8Impl_GetLevelCount(LPDIRECT3DTEXTURE8 iface DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DTexture_GetLevelCount(This->wineD3DTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -200,9 +212,9 @@ static HRESULT WINAPI IDirect3DTexture8Impl_GetLevelDesc(LPDIRECT3DTEXTURE8 ifac WINED3DSURFACE_DESC wined3ddesc; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DTexture_GetLevelDesc(This->wineD3DTexture, Level, &wined3ddesc); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (SUCCEEDED(hr)) { @@ -225,13 +237,15 @@ static HRESULT WINAPI IDirect3DTexture8Impl_GetSurfaceLevel(LPDIRECT3DTEXTURE8 i IWineD3DSurface *mySurface = NULL; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + + wined3d_mutex_lock(); hrc = IWineD3DTexture_GetSurfaceLevel(This->wineD3DTexture, Level, &mySurface); if (hrc == D3D_OK && NULL != ppSurfaceLevel) { IWineD3DSurface_GetParent(mySurface, (IUnknown **)ppSurfaceLevel); IWineD3DSurface_Release(mySurface); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hrc; } @@ -240,9 +254,10 @@ static HRESULT WINAPI IDirect3DTexture8Impl_LockRect(LPDIRECT3DTEXTURE8 iface, U HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DTexture_LockRect(This->wineD3DTexture, Level, (WINED3DLOCKED_RECT *) pLockedRect, pRect, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -251,9 +266,10 @@ static HRESULT WINAPI IDirect3DTexture8Impl_UnlockRect(LPDIRECT3DTEXTURE8 iface, HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DTexture_UnlockRect(This->wineD3DTexture, Level); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -262,9 +278,10 @@ static HRESULT WINAPI IDirect3DTexture8Impl_AddDirtyRect(LPDIRECT3DTEXTURE8 ifac HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DTexture_AddDirtyRect(This->wineD3DTexture, pDirtyRect); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } diff --git a/dlls/d3d8/vertexbuffer.c b/dlls/d3d8/vertexbuffer.c index a282cda6bf..617aff3529 100644 --- a/dlls/d3d8/vertexbuffer.c +++ b/dlls/d3d8/vertexbuffer.c @@ -57,9 +57,10 @@ static ULONG WINAPI IDirect3DVertexBuffer8Impl_Release(LPDIRECT3DVERTEXBUFFER8 i TRACE("(%p) : ReleaseRef to %d\n", This, ref); if (ref == 0) { - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DBuffer_Release(This->wineD3DVertexBuffer); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + IUnknown_Release(This->parentDevice); HeapFree(GetProcessHeap(), 0, This); } @@ -74,14 +75,15 @@ static HRESULT WINAPI IDirect3DVertexBuffer8Impl_GetDevice(LPDIRECT3DVERTEXBUFFE HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_GetDevice(This->wineD3DVertexBuffer, &wined3d_device); if (SUCCEEDED(hr)) { IWineD3DDevice_GetParent(wined3d_device, (IUnknown **)ppDevice); IWineD3DDevice_Release(wined3d_device); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -90,9 +92,10 @@ static HRESULT WINAPI IDirect3DVertexBuffer8Impl_SetPrivateData(LPDIRECT3DVERTEX HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_SetPrivateData(This->wineD3DVertexBuffer, refguid, pData, SizeOfData, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -101,9 +104,10 @@ static HRESULT WINAPI IDirect3DVertexBuffer8Impl_GetPrivateData(LPDIRECT3DVERTEX HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_GetPrivateData(This->wineD3DVertexBuffer, refguid, pData, pSizeOfData); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -112,9 +116,10 @@ static HRESULT WINAPI IDirect3DVertexBuffer8Impl_FreePrivateData(LPDIRECT3DVERTE HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_FreePrivateData(This->wineD3DVertexBuffer, refguid); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -123,9 +128,10 @@ static DWORD WINAPI IDirect3DVertexBuffer8Impl_SetPriority(LPDIRECT3DVERTEXBUFFE DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DBuffer_SetPriority(This->wineD3DVertexBuffer, PriorityNew); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -134,9 +140,10 @@ static DWORD WINAPI IDirect3DVertexBuffer8Impl_GetPriority(LPDIRECT3DVERTEXBUFFE DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DBuffer_GetPriority(This->wineD3DVertexBuffer); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -144,9 +151,9 @@ static void WINAPI IDirect3DVertexBuffer8Impl_PreLoad(LPDIRECT3DVERTEXBUFFER8 if IDirect3DVertexBuffer8Impl *This = (IDirect3DVertexBuffer8Impl *)iface; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DBuffer_PreLoad(This->wineD3DVertexBuffer); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); } static D3DRESOURCETYPE WINAPI IDirect3DVertexBuffer8Impl_GetType(LPDIRECT3DVERTEXBUFFER8 iface) { @@ -162,9 +169,10 @@ static HRESULT WINAPI IDirect3DVertexBuffer8Impl_Lock(LPDIRECT3DVERTEXBUFFER8 if HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_Map(This->wineD3DVertexBuffer, OffsetToLock, SizeToLock, ppbData, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -173,9 +181,10 @@ static HRESULT WINAPI IDirect3DVertexBuffer8Impl_Unlock(LPDIRECT3DVERTEXBUFFER8 HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_Unmap(This->wineD3DVertexBuffer); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -185,9 +194,9 @@ static HRESULT WINAPI IDirect3DVertexBuffer8Impl_GetDesc(LPDIRECT3DVERTEXBUFFER8 WINED3DBUFFER_DESC desc; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DBuffer_GetDesc(This->wineD3DVertexBuffer, &desc); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (SUCCEEDED(hr)) { pDesc->Type = D3DRTYPE_VERTEXBUFFER; diff --git a/dlls/d3d8/vertexdeclaration.c b/dlls/d3d8/vertexdeclaration.c index e9d56d09fb..2eea098a4e 100644 --- a/dlls/d3d8/vertexdeclaration.c +++ b/dlls/d3d8/vertexdeclaration.c @@ -61,9 +61,10 @@ static ULONG WINAPI IDirect3DVertexDeclaration8Impl_Release(IDirect3DVertexDecla TRACE("(%p) : Releasing to %d\n", This, ref_count); if (!ref_count) { - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DVertexDeclaration_Release(This->wined3d_vertex_declaration); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + HeapFree(GetProcessHeap(), 0, This->elements); HeapFree(GetProcessHeap(), 0, This); } diff --git a/dlls/d3d8/vertexshader.c b/dlls/d3d8/vertexshader.c index 4ea8b52ac2..1a9b5ea953 100644 --- a/dlls/d3d8/vertexshader.c +++ b/dlls/d3d8/vertexshader.c @@ -59,9 +59,9 @@ static ULONG WINAPI IDirect3DVertexShader8Impl_Release(IDirect3DVertexShader8 *i IDirect3DVertexDeclaration8_Release(This->vertex_declaration); if (This->wineD3DVertexShader) { - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DVertexShader_Release(This->wineD3DVertexShader); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); } HeapFree(GetProcessHeap(), 0, This); } diff --git a/dlls/d3d8/volume.c b/dlls/d3d8/volume.c index 4a7066c6f7..968b5348a8 100644 --- a/dlls/d3d8/volume.c +++ b/dlls/d3d8/volume.c @@ -72,9 +72,10 @@ static ULONG WINAPI IDirect3DVolume8Impl_Release(LPDIRECT3DVOLUME8 iface) { TRACE("(%p) : ReleaseRef to %d\n", This, ref); if (ref == 0) { - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DVolume_Release(This->wineD3DVolume); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + HeapFree(GetProcessHeap(), 0, This); } @@ -87,11 +88,12 @@ static HRESULT WINAPI IDirect3DVolume8Impl_GetDevice(LPDIRECT3DVOLUME8 iface, ID IDirect3DVolume8Impl *This = (IDirect3DVolume8Impl *)iface; IWineD3DDevice *myDevice = NULL; - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DVolume_GetDevice(This->wineD3DVolume, &myDevice); IWineD3DDevice_GetParent(myDevice, (IUnknown **)ppDevice); IWineD3DDevice_Release(myDevice); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return D3D_OK; } @@ -100,9 +102,10 @@ static HRESULT WINAPI IDirect3DVolume8Impl_SetPrivateData(LPDIRECT3DVOLUME8 ifac HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolume_SetPrivateData(This->wineD3DVolume, refguid, pData, SizeOfData, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -111,9 +114,10 @@ static HRESULT WINAPI IDirect3DVolume8Impl_GetPrivateData(LPDIRECT3DVOLUME8 ifac HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolume_GetPrivateData(This->wineD3DVolume, refguid, pData, pSizeOfData); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -122,9 +126,10 @@ static HRESULT WINAPI IDirect3DVolume8Impl_FreePrivateData(LPDIRECT3DVOLUME8 ifa HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolume_FreePrivateData(This->wineD3DVolume, refguid); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -154,9 +159,9 @@ static HRESULT WINAPI IDirect3DVolume8Impl_GetDesc(LPDIRECT3DVOLUME8 iface, D3DV TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolume_GetDesc(This->wineD3DVolume, &wined3ddesc); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (SUCCEEDED(hr)) { @@ -178,9 +183,10 @@ static HRESULT WINAPI IDirect3DVolume8Impl_LockBox(LPDIRECT3DVOLUME8 iface, D3DL HRESULT hr; TRACE("(%p) relay %p %p %p %d\n", This, This->wineD3DVolume, pLockedVolume, pBox, Flags); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolume_LockBox(This->wineD3DVolume, (WINED3DLOCKED_BOX *) pLockedVolume, (CONST WINED3DBOX *) pBox, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -189,9 +195,10 @@ static HRESULT WINAPI IDirect3DVolume8Impl_UnlockBox(LPDIRECT3DVOLUME8 iface) { HRESULT hr; TRACE("(%p) relay %p\n", This, This->wineD3DVolume); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolume_UnlockBox(This->wineD3DVolume); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } diff --git a/dlls/d3d8/volumetexture.c b/dlls/d3d8/volumetexture.c index 25aa93dc69..1875081a3b 100644 --- a/dlls/d3d8/volumetexture.c +++ b/dlls/d3d8/volumetexture.c @@ -57,9 +57,10 @@ static ULONG WINAPI IDirect3DVolumeTexture8Impl_Release(LPDIRECT3DVOLUMETEXTURE8 TRACE("(%p) : ReleaseRef to %d\n", This, ref); if (ref == 0) { - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DVolumeTexture_Destroy(This->wineD3DVolumeTexture, D3D8CB_DestroyVolume); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + IUnknown_Release(This->parentDevice); HeapFree(GetProcessHeap(), 0, This); } @@ -73,14 +74,15 @@ static HRESULT WINAPI IDirect3DVolumeTexture8Impl_GetDevice(LPDIRECT3DVOLUMETEXT HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolumeTexture_GetDevice(This->wineD3DVolumeTexture, &wined3d_device); if (SUCCEEDED(hr)) { IWineD3DDevice_GetParent(wined3d_device, (IUnknown **)ppDevice); IWineD3DDevice_Release(wined3d_device); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -89,9 +91,10 @@ static HRESULT WINAPI IDirect3DVolumeTexture8Impl_SetPrivateData(LPDIRECT3DVOLUM HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolumeTexture_SetPrivateData(This->wineD3DVolumeTexture, refguid, pData, SizeOfData, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -100,9 +103,10 @@ static HRESULT WINAPI IDirect3DVolumeTexture8Impl_GetPrivateData(LPDIRECT3DVOLUM HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolumeTexture_GetPrivateData(This->wineD3DVolumeTexture, refguid, pData, pSizeOfData); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -111,9 +115,10 @@ static HRESULT WINAPI IDirect3DVolumeTexture8Impl_FreePrivateData(LPDIRECT3DVOLU HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolumeTexture_FreePrivateData(This->wineD3DVolumeTexture, refguid); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -122,9 +127,10 @@ static DWORD WINAPI IDirect3DVolumeTexture8Impl_SetPriority(LPDIRECT3DVOLUMETEXT DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DVolumeTexture_SetPriority(This->wineD3DVolumeTexture, PriorityNew); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -133,9 +139,10 @@ static DWORD WINAPI IDirect3DVolumeTexture8Impl_GetPriority(LPDIRECT3DVOLUMETEXT DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DVolumeTexture_GetPriority(This->wineD3DVolumeTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -143,9 +150,9 @@ static void WINAPI IDirect3DVolumeTexture8Impl_PreLoad(LPDIRECT3DVOLUMETEXTURE8 IDirect3DVolumeTexture8Impl *This = (IDirect3DVolumeTexture8Impl *)iface; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); IWineD3DVolumeTexture_PreLoad(This->wineD3DVolumeTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); } static D3DRESOURCETYPE WINAPI IDirect3DVolumeTexture8Impl_GetType(LPDIRECT3DVOLUMETEXTURE8 iface) { @@ -153,9 +160,10 @@ static D3DRESOURCETYPE WINAPI IDirect3DVolumeTexture8Impl_GetType(LPDIRECT3DVOLU D3DRESOURCETYPE type; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); type = IWineD3DVolumeTexture_GetType(This->wineD3DVolumeTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return type; } @@ -165,9 +173,10 @@ static DWORD WINAPI IDirect3DVolumeTexture8Impl_SetLOD(LPDIRECT3DVOLUMETEXTURE8 DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DVolumeTexture_SetLOD(This->wineD3DVolumeTexture, LODNew); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -176,9 +185,10 @@ static DWORD WINAPI IDirect3DVolumeTexture8Impl_GetLOD(LPDIRECT3DVOLUMETEXTURE8 DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DVolumeTexture_GetLOD(This->wineD3DVolumeTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -187,9 +197,10 @@ static DWORD WINAPI IDirect3DVolumeTexture8Impl_GetLevelCount(LPDIRECT3DVOLUMETE DWORD ret; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); ret = IWineD3DVolumeTexture_GetLevelCount(This->wineD3DVolumeTexture); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return ret; } @@ -201,9 +212,9 @@ static HRESULT WINAPI IDirect3DVolumeTexture8Impl_GetLevelDesc(LPDIRECT3DVOLUMET TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolumeTexture_GetLevelDesc(This->wineD3DVolumeTexture, Level, &wined3ddesc); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); if (SUCCEEDED(hr)) { @@ -227,13 +238,14 @@ static HRESULT WINAPI IDirect3DVolumeTexture8Impl_GetVolumeLevel(LPDIRECT3DVOLUM TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hrc = IWineD3DVolumeTexture_GetVolumeLevel(This->wineD3DVolumeTexture, Level, &myVolume); if (hrc == D3D_OK && NULL != ppVolumeLevel) { IWineD3DVolumeTexture_GetParent(myVolume, (IUnknown **)ppVolumeLevel); IWineD3DVolumeTexture_Release(myVolume); } - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hrc; } @@ -242,9 +254,10 @@ static HRESULT WINAPI IDirect3DVolumeTexture8Impl_LockBox(LPDIRECT3DVOLUMETEXTUR HRESULT hr; TRACE("(%p) Relay %p %p %p %d\n", This, This->wineD3DVolumeTexture, pLockedVolume, pBox,Flags); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolumeTexture_LockBox(This->wineD3DVolumeTexture, Level, (WINED3DLOCKED_BOX *) pLockedVolume, (CONST WINED3DBOX *) pBox, Flags); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -253,9 +266,10 @@ static HRESULT WINAPI IDirect3DVolumeTexture8Impl_UnlockBox(LPDIRECT3DVOLUMETEXT HRESULT hr; TRACE("(%p) Relay %p %d\n", This, This->wineD3DVolumeTexture, Level); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolumeTexture_UnlockBox(This->wineD3DVolumeTexture, Level); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } @@ -264,9 +278,10 @@ static HRESULT WINAPI IDirect3DVolumeTexture8Impl_AddDirtyBox(LPDIRECT3DVOLUMETE HRESULT hr; TRACE("(%p) Relay\n", This); - EnterCriticalSection(&d3d8_cs); + wined3d_mutex_lock(); hr = IWineD3DVolumeTexture_AddDirtyBox(This->wineD3DVolumeTexture, (CONST WINED3DBOX *) pDirtyBox); - LeaveCriticalSection(&d3d8_cs); + wined3d_mutex_unlock(); + return hr; } diff --git a/dlls/wined3d/wined3d.spec b/dlls/wined3d/wined3d.spec index 2f2677c1ce..f65ee314df 100644 --- a/dlls/wined3d/wined3d.spec +++ b/dlls/wined3d/wined3d.spec @@ -1,2 +1,4 @@ @ stdcall WineDirect3DCreate(long ptr) @ stdcall WineDirect3DCreateClipper(ptr) +@ stdcall wined3d_mutex_lock() +@ stdcall wined3d_mutex_unlock() diff --git a/dlls/wined3d/wined3d_main.c b/dlls/wined3d/wined3d_main.c index 4feb50952e..fa3c163487 100644 --- a/dlls/wined3d/wined3d_main.c +++ b/dlls/wined3d/wined3d_main.c @@ -32,6 +32,15 @@ int num_lock = 0; void (*CDECL wine_tsx11_lock_ptr)(void) = NULL; void (*CDECL wine_tsx11_unlock_ptr)(void) = NULL; +CRITICAL_SECTION wined3d_cs; +static CRITICAL_SECTION_DEBUG wined3d_cs_debug = +{ + 0, 0, &wined3d_cs, + {&wined3d_cs_debug.ProcessLocksList, + &wined3d_cs_debug.ProcessLocksList}, + 0, 0, {(DWORD_PTR)(__FILE__ ": wined3d_cs")} +}; +CRITICAL_SECTION wined3d_cs = {&wined3d_cs_debug, -1, 0, 0, 0, 0}; /* When updating default value here, make sure to update winecfg as well, * where appropriate. */ @@ -325,6 +334,16 @@ static BOOL wined3d_destroy(HINSTANCE hInstDLL) return TRUE; } +void WINAPI wined3d_mutex_lock(void) +{ + EnterCriticalSection(&wined3d_cs); +} + +void WINAPI wined3d_mutex_unlock(void) +{ + LeaveCriticalSection(&wined3d_cs); +} + /* At process attach */ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) { diff --git a/include/wine/wined3d.idl b/include/wine/wined3d.idl index 0e87d7f04a..ec204332fa 100644 --- a/include/wine/wined3d.idl +++ b/include/wine/wined3d.idl @@ -3468,3 +3468,5 @@ interface IWineD3DDevice : IWineD3DBase IWineD3D *WineDirect3DCreate(UINT dxVersion, IUnknown *parent); IWineD3DClipper *WineDirect3DCreateClipper(IUnknown *parent); +void wined3d_mutex_lock(void); +void wined3d_mutex_unlock(void);