Commit Graph

102 Commits

Author SHA1 Message Date
Andrew Talbot
388fe7e371 shell32: Declare some functions static. 2007-02-07 11:03:28 +01:00
Andrew Talbot
8246b6cd30 shell32: Remove unused function. 2007-02-06 13:19:22 +01:00
Francois Gouget
4abebb8eb5 shell32: There is no need to check strings for NULL when using debugstr_w().
Also don't put single quotes around '%s' in that case.
2007-01-18 12:55:40 +01:00
Francois Gouget
df299b7305 shell32: Replace numeric literals with the proper constant. 2006-12-14 20:24:31 +01:00
Francois Gouget
df9715b1b0 shell32: Fix FindExecutableW() to not check if lpResult after using it. It's supposed to cause a segfault anyway.
Use SE_ERR_FNF rather than a numeric literal.
2006-12-14 12:45:27 +01:00
Francois Gouget
2538fa319a shell32: Add some documentation for FindExecutableW(). 2006-12-14 12:45:21 +01:00
Francois Gouget
71e5f3c116 shell32: Fix FindExecutable() to return the executable path, not the whole command. 2006-12-14 12:45:15 +01:00
James Hawkins
44b0b462cb shell32: Move a NULL pointer check before the place where we dereference the pointer. 2006-12-04 12:22:46 +01:00
Francois Gouget
9fefaa87a9 shell32: Remove unused parameters from SHELL_FindExecutableByOperation(). 2006-11-24 11:48:35 +01:00
Francois Gouget
138e12b3d2 shell32: Add missing '\n' to Wine trace. 2006-11-08 12:10:39 +01:00
Aric Stewart
3f9a168f47 shell32: Have SHELL_ArgifyW respect the length of the buffer passed in and report a needed buffer size. 2006-11-06 14:11:57 +01:00
Aric Stewart
3490cb81ed shell32: Create dynamic buffers for expanded enviroment strings to allow for parameters and such longer than MAX_PATH.
With help from Michael Moss.
2006-11-06 14:10:55 +01:00
Hans Leidekker
89e1d29482 shell32: Win64 printf format warning fixes. 2006-10-09 12:45:02 +02:00
James Hawkins
7b89ff88e8 janitorial: Remove redundant NULL checks before SHFree. 2006-10-07 17:52:59 +02:00
Andrew Talbot
30806fc00c shell32: Cast-qual warnings fix. 2006-10-02 11:55:26 +02:00
Francois Gouget
9607151e38 shell32: Fix computation of default verb.
Compute the default verb as documented on MSDN instead of blindly
assuming it is 'open'. This fixes the WordViewer association in some
cases.
2006-06-26 13:05:12 +02:00
Francois Gouget
2d7ef72cf0 shell32: Remove dead code in SHELL_FindExecutable(). 2006-06-16 11:32:11 +02:00
Jonathan Ernst
360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
Jacek Caban
150bd5442c shell32: Don't crash in SHELL_ExecuteW if psei->lpDirectory is NULL. 2006-04-14 19:37:02 +02:00
Jacek Caban
4b5125a79c shell32: Allocate wszApplicationName on the heap as it may be longer than MAX_PATH. 2006-04-12 20:56:57 +02:00
Dmitry Timoshkov
52645e1144 shell32: Add parameter formatting rule to the command line if there isn't any. 2006-03-14 18:49:43 +01:00
Eric Pouech
1be2e1edef shell32: Fixes for bugs found by valgrind on shell32 tests harness.
- read strings from left to right (PathGetDriveNumberW)
- don't access buffers before they are filled (SHGetPathFromIDListW)
- fill buffers & variables on all paths (SHELL_FindExecutable)
- handle error condition (unix_fs)
- don't shoot in the blind for AW APIs (tests/shelllink.c)
2006-02-22 12:04:02 +01:00
Dmitry Timoshkov
22204c2c80 shell32: execute_from_key should fallback to a DDE exec only if the
command to execute from is not found in the registry.
Pass already found executable name to dde_connect.
2006-02-01 12:29:39 +01:00
Ge van Geldorp
a8d1e6e068 shell32: Fix directory execution.
Only use the Folder class handler if we're actually executing a
folder.
2006-01-12 13:31:45 +01:00
Martin Fuchs
041039390a Fix context menu handling for more than one entry in order to repair
.lnk-file execution: Don't break at the first non-matching entry.
2005-11-30 18:26:32 +01:00
Ge van Geldorp
72ed6eae4c Other code in shlexec.c (e.g. the extension handling code in
ShellExecute_GetClassKey) expects sei->lpFile to not be enclosed in
quotes.
2005-11-28 17:29:58 +01:00
Dmitry Timoshkov
84d4fc5e03 Unconditionally fall back to ANSI DDE APIs in ShellExecute if current
emulated Windows version is Win9x, Excel refuses to communicate with a
unicode client in win9x mode.
2005-11-11 10:54:07 +00:00
Mike McCormack
32d5240178 Invoke shortcuts through IContextMenu, rather than trying to access
them directly.
2005-11-03 11:33:57 +00:00
Dmitry Timoshkov
8cd388f398 Use appropriate DDE APIs (ANSI or unicode) for ShellExecuteA/W, Excel
2000 depends on that.
2005-10-18 14:11:17 +00:00
Martin Fuchs
803146d220 Simplify 'sei' structure initialization in ShellExecuteA/W. 2005-10-03 11:02:47 +00:00
Ge van Geldorp
5b7da80911 Fix execution of Control Panel items. 2005-09-12 12:10:57 +00:00
Dmitry Timoshkov
4cc1c14005 Pass a locally modified version of SHELLEXECUTEINFO to
IShellExecuteHookW_Execute, this should pass through at least
sei_tmp.nShow retrieved from an .lnk file (fStartup).
2005-09-08 18:54:52 +00:00
Kevin Koltzau
95a173a52b Fix warnings in 64bit. 2005-09-02 11:32:17 +00:00
Francois Gouget
0b5cc286e3 Fix ShellExecute("\"foo.doc\"") for Internet Explorer 6.
Update the conformance tests accordingly.
Tweak a trace because it's very confusing to see the path with no
escaped quotes in ShellExecuteA() and then with escaped quotes in
ShellExecuteExW32() (due to debugstr_w()).
2005-08-17 09:53:30 +00:00
Francois Gouget
df6ed2f4e8 Fix the return value of SHELL_Argify() so it once again returns true
if a '%1' or equivalent placeholder was found. This fixes
ShellExecuteEx(lpFile="foo.txt", lpClass="txtfile").
2005-08-11 17:04:31 +00:00
Francois Gouget
efe2bbd0ec Fix handling of SEE_MASK_CLASSNAME and SEE_MASK_CLASSKEY. They are not
disjoint flags.
2005-08-11 10:29:44 +00:00
Francois Gouget
28dc5a8afc Assorted spelling fixes. 2005-07-11 10:59:41 +00:00
Michael Jung
81b7509f3b Use SHGetPathFromIDList instead of SHELL32_GetPathFromIDList. 2005-06-14 19:17:41 +00:00
Juan Lang
f12eadf7bf - only log unsupported flags in ShellExecute
- environment variables are expanded, so SEE_MASK_DOENVSUBST is
  supported
2005-05-14 11:06:54 +00:00
Peter Berg Larsen
6e3bcb5a54 Replace strncpy with memcpy or lstrcpyn. 2005-04-18 10:30:55 +00:00
Francois Gouget
93416cdaf7 Assorted spelling fixes. 2005-03-23 13:15:18 +00:00
Aric Stewart
984931bd09 For ShellExecuteExA we need to copy out the hProcess value from the W
structure.
2005-03-17 20:50:53 +00:00
Ge van Geldorp
a912c2a885 Error numbers >= 32 are to be expected. 2005-02-14 11:03:21 +00:00
Michael Stefaniuc
5ad7d858e0 Do not check for non NULL pointer before HeapFree'ing it. It's
redundant.
2004-12-23 17:06:43 +00:00
Alexandre Julliard
758b2887e9 Remove some no longer needed AW functions. 2004-12-17 19:20:07 +00:00
Jon Griffiths
f82272c92f Remove unneeded headers to reduce unneeded rebuilds. 2004-12-16 14:35:55 +00:00
Ge van Geldorp
9b399da426 - Don't double-quote an already double-quoted argument.
- Properly increment the fmt pointer.
2004-10-21 20:59:25 +00:00
Francois Gouget
486d020c1b Don't define COBJMACROS in objbase.h.
Update the Wine sources accordingly.
2004-10-07 03:06:48 +00:00
Jens Collin
9e679d3675 Added lookup of environment vars in SHELL_ArgifyW. 2004-09-14 20:14:09 +00:00
Ge van Geldorp
225c8e6c57 Handle shell link files contained in double quotes. 2004-08-16 23:18:36 +00:00