Commit Graph

412 Commits

Author SHA1 Message Date
Serge Ivanov
9eedcf5852 - Removed dependency of edit control from combobox implementation.
- Edit control uses undocumented window style 0x0200 to detect is it a part
  of combobox. If so it calls GetDlgItem(hwndCombo, 1000) to get ComboLBox
  window handle (see comments for combo.c below).
- EDIT_CheckCombo - modified for correct handling of keyboard messages.
- Processing of WM_GETDLGCODE and WM_CHAR for VK_RETURN and VK_ESCAPE
  depends on whether listbox is dropped down. This prevents closing of dialog
  if listbox is dropped down and allows combobox to process these keyboard
  messages properly.
2000-06-07 03:47:34 +00:00
Serge Ivanov
07917e40e8 - We can use wnd->wIDmenu for ComboLBox (it is not reset anymore in SetParent)
- When user clicks outside of dropped listbox, original selection must be
  restored.
- ComboLBox has caret_on = FALSE on creation, that's why combobox sends
  LB_CARETON message before dropping listbox down (but only for
  CBS_DROPDOWNLIST - I don't now why).
2000-06-07 03:46:57 +00:00
Alexandre Julliard
72bdd5bee7 Stephane Lussier
Sheri Steeves
Haithem Hmida
- Height of the listbox should be adjust when LBS_OWNERDRAWFIXED is set
  and not if LBS_OWNERDRAWVARIABLE is set, previously it was not adjusting
  the size in both cases.
- When the caret index change, items repainting need tp be in this
  order
  a) Paint old caret item without the focus
  b) Paint old caret item without the selection
  c) Paint new caret item with the selection
  d) Paint new caret item with the focus.
- When repainting the listbox, we should paint all items regarding if
  they are slected or not and then paint after the focus item. So focus
  item will end out being painted twice. (That's what Windows does).
2000-06-07 03:17:35 +00:00
Susan Farley
b09c6ef5ae Attempt to paint the checkbox and radio buttons better. 2000-06-04 01:32:59 +00:00
Andreas Mohr
2e011a5243 Lots of spelling fixes that accumulated in my tree again, made several
error msgs more verbose, doc updates.
2000-06-01 23:28:25 +00:00
Alexandre Julliard
207f7019e6 Louis-Philippe Gagnon (of Macadamian for Corel)
Static controls weren't receiving WM_LBUTTONDBLCLK messages because the
Static window class was registered without the CS_DBLCLKS style (which it
has in Windows).
2000-06-01 23:15:49 +00:00
Serge Ivanov
bfe15b12ad MSDN: "WM_NCHITTEST - Returns HTCLIENT if the control style is
SS_NOTIFY; otherwise, returns HTTRANSPARENT. "
2000-06-01 22:46:51 +00:00
Alexandre Julliard
d566a0e309 Serge Ivanov
Returning DLGC_WANTALLKEYS for multiline edit control was not good because
it breaks navigation in dialogs.
2000-05-30 20:50:09 +00:00
David Grant
8a92213111 - Creating combobox with CBS_SIMPLE style shall set internal flag CBF_EDIT.
- Edit text must be selected only if CB is in focus.
- If CB has edit control we have to call CBUpdateEdit to update its
  contents. Invalidating textRect will not force updating of child
  edit control, obviously.
- We have to protect ourselves from changing selection in listbox when
  we receive listbox notification. So LBN_SELCHANGE -> CBUpdateEdit ->
  EN_CHANGE will not reselect item in the lisbox.
2000-05-30 17:48:33 +00:00
Alexandre Julliard
dcc175de6a Owen Wang
When you click on an icon to open a combo box, you would expect it to
be enabled so you can choose something in it. In Wine this was not
guaranteed since your default flags could get lost in the process-heap
of the application.
2000-05-30 15:28:06 +00:00
Alexandre Julliard
ab2f43f99b Serge Ivanov
- Added handling of WM_MOUSEACTIVATE message
- Added in_focus field to internal listbox's structure. This flag is set on
  receiving WM_SETFOCUS message and is reseted on WM_KILLFOCUS. All calls to
  GetFocus function were replaced with checks of this flag.
- In LISTBOX_HandleLButtonDown: focus is set only if 'in_focus' flag is
  clear
2000-05-26 22:28:34 +00:00
Alexandre Julliard
fa2c79398d Henning Hoffmann
Don't send EN_CHANGE after painting the edit.
Send it wherever text is changed.
2000-05-26 01:24:56 +00:00
Ulrich Czekalla
70d5a95236 Moved the EN_UPDATE notification out of the paint handler. Instead,
the notification is sent when an InvalidateRect is made after
modifying the text.
2000-05-26 01:17:34 +00:00
Alexandre Julliard
c616625945 Louis-Philippe Gagnon (of Macadamian Technologies for Corel)
Added event handler for WM_MBUTTONDOWN (sends WM_PASTE message).
2000-05-25 23:01:39 +00:00
Rob Farnum
b200793de4 Post a WM_CANCELMODE message to wake up the internal menu handling
code. This fixes the problem of a menu being orphaned when the parent
window disappears, or if the parent loses focus.
2000-05-23 23:34:17 +00:00
Ulrich Czekalla
c804e3eac4 Capture ^V,^X,^C and translate it to the corresponding message for
paste, cut, copy.
2000-05-23 21:16:07 +00:00
Alexandre Julliard
7f90a8c900 Serge Ivanov
Fixed WM_LBUTTONDBLCLK handling.
2000-05-23 04:18:12 +00:00
Andreas Mohr
a8edb3e461 Some part of EDIT_EM_LineLength code was commented (broken). Restored
the capability to calculate the remaining non-selected chars of a
selection area.
2000-05-23 04:05:05 +00:00
Alexandre Julliard
f5d4244f71 Sheri Steeves
The edit is now detected correctly if the parent is a combo box. It
wasn't working when the combobox was superclassed.
2000-05-18 00:16:53 +00:00
Susan Farley
d34205ef94 Avoid calls to SetFocus when they are unnecessary. 2000-05-15 02:34:20 +00:00
Gerard Patel
c6369b0bd7 When new menu Id is not found or index > nitems, insert the new menu
at end of current menu.
2000-05-14 22:52:52 +00:00
Susan Farley
f1d467a337 Distinguish RADIOCHECK style menu items from standard checkmark menu
items.
2000-05-12 21:59:31 +00:00
Susan Farley
b64aa2460e Like the AUTORADIOBUTTON, the parent of a RADIOBUTTON style button
should be sent a BN_CLICKED when it receives the focus.
2000-05-12 21:51:09 +00:00
Guy Albertelli
f12b70addb Revalidate menu handle in mt.hTopMenu after DispatchMessage. 2000-05-11 00:06:11 +00:00
Aric Stewart
70cc169d1c - Wine was passing the wrong hwnd as the owner when processing owner
drawn menubars.
- When doing MENU_CalcItemSize for the menu bar we were not properly
  padding the returned rect.
2000-05-10 21:54:07 +00:00
Ken Thomases
130f0d88c1 Fixed to display popup-menu arrow on owner-drawn popup menus.
Fixed positioning of submenus relative to parent menus.
2000-05-10 21:38:37 +00:00
Chris Morgan
c0872e3119 Fixed scrolling bug. 2000-05-07 18:24:36 +00:00
Susan Farley
86d0b031bb Handle ^C, ^V and ^X in an edit control properly. 2000-05-05 18:21:02 +00:00
Ove Kaaven
b4018e7a57 Fix edit control's WM_GETTEXT behaviour. 2000-04-23 19:59:11 +00:00
Stephane Lussier
4bdf4af11e Implemented Mousewheel support. 2000-04-18 11:56:33 +00:00
Patrik Stridvall
2d6457c11a Added/fixed some documentation reported by winapi_check. 2000-03-28 20:22:59 +00:00
Francois Gouget
6d77d3a1df Use min/max instead of MIN/MAX. 2000-03-25 21:44:35 +00:00
Huw D M Davies
65a0fa6e4e Send the correct ODA_ code when deselecting an item. 2000-03-25 21:41:17 +00:00
Alexandre Julliard
7f3418fba0 Store monitor size and depth in the generic structure.
Merged monitor driver into USER driver.
2000-03-25 17:30:13 +00:00
Huw D M Davies
2d6eabacc3 Set the correct value for the cch element of MENUITEMINFO in
GetMenuItemInfo.
2000-03-24 19:48:53 +00:00
Huw D M Davies
2e34030a02 Stop a WM_SETTEXT message (and friends) to a combo sending CBN_EDIT*
messages to the parent.
2000-03-24 19:44:39 +00:00
Alexandre Julliard
28c3a1baf3 Moved graphics initialisation to the x11drv/ttydrv dll init code.
Merged event, keyboard and mouse drivers into USER driver.
2000-03-20 18:21:19 +00:00
Patrik Stridvall
6cc47d4924 Removed a lot of unnecessary includes and fixed the compile errors. 2000-03-08 18:26:56 +00:00
Ulrich Czekalla
60b1c38e86 The static control only needs to invalidate its rect when we SetText. 2000-03-08 18:22:51 +00:00
Ulrich Czekalla
33026a2a6e Send WM_HELP message when F1 is pressed. 2000-02-26 19:13:44 +00:00
Yuxi Zhang
f94c3c55c1 In the listbox, when the last item is selected and deleted, it still
appeared in the window.

Sheri Steeves <sheri@macadamian.com>
In LISTBOX_UpdateScroll(), if the listbox did not have the WS_SCROLL
style it would just return.  This left the horizontal scroll bar
uninitialized and it was appearing at the bottom of the listbox when
it did not have to.

Serge Ivanov <sergei@corel.com>
LISTBOX_SetColumnWidth adds extra 2 pixels to the passed column width
(it says it is for column margins). Obviously it is wrong, because
margins must be internal.
2000-02-26 19:13:12 +00:00
Bill Jin
4f155e88bc Bitmap buttons were not refreshed correctly. 2000-02-26 18:29:15 +00:00
Alexandre Julliard
916f975624 Improved the selector get/set functions.
Support ANSI-compatible inline asm (with the help of Patrik Stridvall).
2000-02-26 16:51:13 +00:00
Jeremy White
d3e22d9d55 Removed #include of wingdi.h and windef.h from winuser.h (and resolved
the resulting compilation failures).
2000-02-10 19:03:02 +00:00
Luc Tourangeau
e84b678408 Implementation of Static OwnerDraw. 2000-02-07 16:01:04 +00:00
Alexandre Julliard
b2f6f0e7d2 Removed resource.h. 2000-02-03 01:54:36 +00:00
Dmitry Timoshkov
6fb62f52f5 Correct the behaviour of the accelerator keys in dialogs according to
the Windows' one.
2000-01-29 22:09:40 +00:00
Gerard Patel
3e629748cf Validate the menu handles. 2000-01-17 22:22:16 +00:00
Pascal Lessard
ae6de763e9 Stop menu tracking when clicking on the menu bar where there is no
menu item.
2000-01-09 02:38:02 +00:00
Marcus Meissner
cb3c7bfa70 GetMenuString should return itemlength on 0 nMax or NULL str
InsertItem pos=-1, flags = 0 should append item
(thanks to Sander van Leeuwen)
2000-01-08 22:25:57 +00:00
Rein Klazes
e8256f589f Don't show the scrollbar if SetScrollinfo() is called with only the
SIF_DISABLENOSCROLL flag.
2000-01-04 00:28:55 +00:00
Dmitry Timoshkov
cd207587ec ComboBox should not send bogus messages to edit buddy and to itself. 1999-12-12 20:47:45 +00:00
Rein Klazes
80c924f1f4 In win32 a WM_MENUSELECT message should contain the position when the
item refers to a submenu, not the submenu's handle as in win16.
1999-12-12 19:40:46 +00:00
Marcus Meissner
ed0da3f66c Removed 2 useless include winversion.h
Do not make autodetected version fix on first calls if it is Win31.
1999-12-12 00:44:06 +00:00
Ulrich Weigand
2faf2cf964 Perform 16/32A/32W message mapping for posted messages. 1999-12-10 03:47:13 +00:00
Dimitrie O. Paun
dd03cc19fd Make use of the DEFAULT_DEBUG_CHANNEL where appropriate.
Use the default version of FIXME, ERR, WARN, TRACE for the default
channel.
1999-12-08 03:56:23 +00:00
Dmitry Timoshkov
0958a20725 Fix problem with EN_UPDATE notification sent by edit control. 1999-12-08 03:25:30 +00:00
Dmitry Timoshkov
38d04b8ff4 Allow to deselect all items by sending CB_SETCURSEL(-1) to the combo. 1999-12-06 00:57:20 +00:00
Dmitry Timoshkov
f92a777007 Remove hack for keyboard messages in dialogs. 1999-12-05 23:51:15 +00:00
Dmitry Timoshkov
92f376f78b Show use of undocumented messages. 1999-12-05 02:45:10 +00:00
Dmitry Timoshkov
f4a27b8d41 When combobox selection changes, update its edit box accordingly. 1999-11-28 19:45:58 +00:00
Dmitry Timoshkov
e0f493e5b0 Notify parent of listbox if requested. 1999-11-28 19:44:33 +00:00
Rein Klazes
077ec0cffd Send WM_CTLCOLOREDIT not WM_CTLCOLORSTATIC messages to parent of a
disabled edit control if the application expects a windows version
before WIN95 and NT40.
1999-11-10 19:55:29 +00:00
Jim Aston
aebda22e61 Fixed the height of the ComboBox drop list. 1999-11-07 21:04:57 +00:00
Karl Lessard
4a0a7df6a3 When a popupmenu is currently active on the screen, it shouldn't
remove mouse click messages that don't belong to it from the queue.
1999-11-07 05:17:10 +00:00
Marcus Meissner
2e48a2cc22 Do not clear the drawing area for etched static controls.
Replaced our own drawing stuff in etched static controls by DrawEdge.
1999-10-31 17:36:26 +00:00
Pierre Mageau
891d4d22a7 Fixed loop with WM_SYSCHAR. 1999-10-23 20:05:04 +00:00
Abey George
889a3be68f Draw the item text from the top of the item rect. 1999-10-23 17:12:24 +00:00
Gerard Patel
8c36254147 Make WM_GETTEXTLENGTH return length for dropdownlist combos. 1999-10-13 13:50:17 +00:00
Francois Boisvert
73d7337e83 Removed FillRect in the ownerdrawn button procedure. 1999-10-13 13:49:42 +00:00
Juergen Schmied
371c420549 Made TrackPopupMenu with TPM_RETURNCMD returning the id instead of
true.
1999-10-13 12:27:44 +00:00
Karl Lessard
13409b32cd Make ExecFocusedItem return -1 on failure. 1999-09-28 16:24:58 +00:00
Gerard Patel
6df0694f7c Force recalculation of menu when calling InsertMenuItem. 1999-09-28 13:05:54 +00:00
Stephane Lussier
5ca2ec4288 Return key should not be ignored in multiline edit even if
ES_WANTRETURN flag isn't set.
1999-09-27 11:45:07 +00:00
Rein Klazes
61b15de4ba Use an extra bit in the button status byte to flag whether the
DefButtonWndProc should process the WM_LBUTTONUP message.
1999-09-27 11:38:47 +00:00
Abey George
b59d4bc503 Don't send WM_ENTERMENULOOP, WM_INITMENU & WM_INITMENUPOPUP messages
when TPM_NONOTIFY flag is set in TrackPopupMenu.
1999-09-22 15:10:42 +00:00
Francis Beaudet
2862362259 Fixed display bug in the static control. 1999-09-20 18:28:08 +00:00
Pascal Lessard
445c910e89 Message removed when menu tracking finish on a WM_LBUTTONDOWN. 1999-09-20 18:27:14 +00:00
Dennis Björklund
4352c7a9d0 Send correct WM_MENUSELECT when menu closes. 1999-09-19 18:28:35 +00:00
Noomen Hamza
502e4f5dc6 The MDIClient class must be registered with the IDC_ARROW cursor. 1999-09-19 14:11:41 +00:00
Francis Beaudet
f132872741 Implemented the disabled state of the combobox. 1999-09-19 14:09:52 +00:00
Richard Cohen
56753621d3 Protect SetMenu from rogue menu handle.
GetMenu16 can just call GetMenu.
1999-09-19 14:08:13 +00:00
Pascal Lessard
07c447f971 Added a case for menu handling in win31. 1999-09-19 12:03:25 +00:00
Dennis Björklund
9af3ebaa7b Fixed win9x look on checkboxes and radiobuttons. 1999-09-13 16:06:17 +00:00
Eric Pouech
0c62bf064d Added MenuItemFromPoint stub. 1999-09-13 15:11:35 +00:00
Nick Holloway
b9ce4fd51b For Win 3.x applications, if they have either horizontal or vertical
scrollbars, enable both.
1999-09-11 16:29:00 +00:00
Pierre Mageau
25c62cc61f Set the mouse capture on the combo listbox. 1999-09-11 16:26:03 +00:00
Abey George
3cee09c0fc Draw the focus rectangle for buttons with BS_3STATE, BS_RADIOBUTTON,
BS_CHECKBOX, BS_AUTO* styles.
1999-09-11 16:22:10 +00:00
Pascal Lessard
aed79e58c7 Implemented the behavior around the ES_WANTRETURN style in the edit
control.
1999-09-10 13:58:34 +00:00
Pierre Mageau
a433582363 Modified CBDropDown to find the best height of the listbox. 1999-09-05 12:12:30 +00:00
Stephane Lussier
cdb5650d1e Initialize the enabling state variable in the edit. 1999-09-04 14:27:50 +00:00
Pascal Lessard
3405f5c6cd The format rect is recalculated for each font change. MoveEnd &
MoveHome improved.
1999-09-04 10:59:07 +00:00
Pascal Lessard
2eb0a302a0 Menu hides when clicked for a second time. 1999-09-03 16:38:52 +00:00
Stephane Lussier
93805344ee Keep the enable state in the edit structure instead of calling
IsWindowEnabled().
1999-09-03 16:37:00 +00:00
Francis Beaudet
49936036e6 Slight 1 pixel adjustment on the position of the radio button bitmap. 1999-09-03 15:07:21 +00:00
Pascal Lessard
6fe38e560e The backspace is now handled in the WM_CHAR message. 1999-09-03 15:02:48 +00:00
Francis Beaudet
f22ff403ac Fixed a little positioning bug with the checkbox. 1999-09-03 12:35:18 +00:00
Gerard Patel
8e5c72e195 Implemented wParam of WM_PAINT msg for edit control. 1999-09-03 12:23:52 +00:00
Stephane Lussier
a833f63783 Avoid changing the activation state in EnableMenuItem. 1999-08-21 14:46:06 +00:00
Rein Klazes
d35c834b77 Make sure that an empty string never matches a listbox entry in
LISTBOX_FindString().
1999-08-21 13:04:58 +00:00