Commit Graph

124 Commits

Author SHA1 Message Date
Ulrich Czekalla
32a4ac1629 shell32: Revert c1f2824429. It caused poor performance.
Patch c1f2824429 causes poor performance
when browsing a directory. In fact it has a side affect that when you
browse the root folder off of My Computer it will enumerate not only
the root's contents but each subfolder's contents as well in order to
get a more likely correct value for SFGAO_HASSUBFOLDER.
2008-09-30 11:32:50 -05:00
Andrew Talbot
6994071269 shell32: Remove unneeded casts. 2008-01-21 11:39:09 +01:00
Francois Gouget
44b52b128c Assorted spelling fixes. 2008-01-16 12:48:29 +01:00
Dmitry Timoshkov
e3cfd6ef32 shell32: Remove class cache introduced in commit f686cfab2f. 2007-09-12 11:33:11 +02:00
Michael Stefaniuc
b6ce3de8e7 shell32: Fix missing unlock on an error path. Found by Smatch. 2007-07-16 22:47:12 +02:00
Dmitry Timoshkov
f686cfab2f shell32: Add a cache for queried shell folder interfaces. 2007-07-16 15:00:01 +02:00
Aric Stewart
c465e11a6d shell32: Use _ILSimpleGetTextW instead of using _ILGetTextPointer
to be able to make use of FileStructW and avoid W->A->W roundtrips if
possible.
2007-04-11 12:26:31 +02:00
Hans Leidekker
89e1d29482 shell32: Win64 printf format warning fixes. 2006-10-09 12:45:02 +02:00
Francois Gouget
9bfbfcbeb4 Assorted spelling, case and grammar fixes. 2006-06-26 13:06:11 +02:00
Jonathan Ernst
360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
Francois Gouget
6bddeb1cf7 Assorted spelling fixes. 2006-03-21 20:10:39 +01:00
Martin Fuchs
8167c415ab shell32: Avoid recursing SHELL32_GetItemAttributes() calls. 2006-02-20 11:50:56 +01:00
Martin Fuchs
c362d7c35b shell32: SHELL32_GetItemAttributes()
- correct documentation which incorrectly claimed not to set any
  attribute bits
- retrieve file attributes using SHGetPathFromIDListW() when they are
  not already present in the internal PIDL structures
- add test case to show the previously wrong folder attributes when
  using absolute PIDLs
- fix some memory leaks in the tests
2006-02-11 12:16:56 +01:00
Huw Davies
51fd750707 shell: Fix incorrect usage of the return value of StrRetToStrNW. 2006-01-20 20:17:07 +01:00
Robert Shearman
50c1e46d18 shell: Convert SHELL32_GetDisplayNameOfChild to unicode. 2006-01-16 21:31:10 +01:00
Martin Fuchs
0b17529332 Correctly call HCR_GetFolderAttributes() in SHELL32_GetItemAttributes().
Directly return the correct "My Computer" attributes in
ISF_Desktop_fnGetAttributesOf().
Remove "todo_wine" from the "My Computer" attributes test case.
Add test case for retrieving the file system path from the
CSIDL_PROGRAM_FILES PIDL using SHGetPathFromIDListW().
2005-11-28 10:38:06 +01:00
Alexandre Julliard
73f7847297 Authors: Vitaliy Margolen <wine-patch@kievinfo.com>, Michael Jung <mjung@iss.tu-darmstadt.de>
Set all capability flags supported by the shellfolder, disregarding
the flag mask given to GetAttributesOf.
Unit tests to demonstrate this behaviour.
2005-11-03 09:56:07 +00:00
Robert Shearman
055d96b721 Convert SHELL32_BindToChild to Unicode and fix up the callers. 2005-11-01 09:34:03 +00:00
Michael Jung
47c0906369 Only initialize shell folders via the IPersistFolder3 interface in
SHELL32_CoCreateInitSF if the pidl which specifies the child is of
type 'Folder'. Otherwise fall back to IPersistFolder.
2005-07-20 10:29:05 +00:00
Michael Jung
114975d937 Fix a lurking infinite loop in SHGetPathFromIDList. 2005-06-25 18:32:17 +00:00
Michael Jung
11cadc368a Support for shellfolder's CallForAttributes registry value. 2005-06-25 17:55:53 +00:00
Juan Lang
ab88fd34dc Const-ify a mask. 2005-06-07 20:03:39 +00:00
Michael Jung
38f2ee9d04 Let BindToObject fail, if called with empty relative pidl.
Tests to show that it should do so.
Fix SHBrowseForFolder to not pass an empty pidl to BindToObject.
2005-06-06 10:04:15 +00:00
Kouji Sasaki
c1f2824429 Added the processing for determination of SFGAO_HASSUBFOLDER flag in
SHELL32_GetItemAttribute function.
2005-05-18 09:43:39 +00:00
Huw Davies
8dabf51d39 Directory items should have the SFGOA_FILESYSANCESTOR attribute.
Add a test for this and cleanup the shlfolder test a bit.
2005-04-11 18:50:01 +00:00
Francois Gouget
93416cdaf7 Assorted spelling fixes. 2005-03-23 13:15:18 +00:00
Mike McCormack
4098dc64ca Remove some dead code and some ifdefs. 2005-03-17 18:55:49 +00:00
Mike McCormack
2c8367a3de Use lstrcmpiA in preference to strcasecmp. 2005-03-07 11:05:03 +00:00
Jon Griffiths
f82272c92f Remove unneeded headers to reduce unneeded rebuilds. 2004-12-16 14:35:55 +00:00
Eric Pouech
0a258964c2 Const correctness fixes. 2004-11-30 21:38:57 +00:00
Francois Gouget
486d020c1b Don't define COBJMACROS in objbase.h.
Update the Wine sources accordingly.
2004-10-07 03:06:48 +00:00
Ge van Geldorp
3db9386195 Can't pass NULL as default value to GetPrivateProfileString. 2004-10-04 19:05:02 +00:00
Robert Shearman
5ad2d3517f - Add support for custom shell folders, such as the History folder.
- Always try to initialize folder using IPersistFolder3 interface and
  then fall back on IPersistFolder if not supported.
2004-09-28 19:33:44 +00:00
Vitaliy Margolen
f609b68ea5 IShellFolder::CompareIDs - return only -1/0/1 in lower 16 bit. 2004-09-13 23:25:09 +00:00
Martin Fuchs
849337b9b6 Correct error handling in SHELL32_ParseNextElement(). 2004-04-15 04:55:54 +00:00
Martin Fuchs
fc69e4cf1b Improved error handling.
SHELL32_GetItemAttributes(): support for SFGAO_LINK attribute.
2004-01-23 20:43:18 +00:00
Francois Gouget
17112eaa4d Assorted spelling fixes. 2004-01-16 21:26:08 +00:00
Francois Gouget
224063f033 Some spelling fixes.
Fix the case of WineHQ.
2003-09-29 20:20:53 +00:00
Rolf Kalbermatter
2407c13848 Make sure the bind context is forwarded in
ShellFolder_ParseDisplayName.
2003-09-15 22:16:41 +00:00
Alexandre Julliard
20c169e0a4 Fixed a few more headers dependency issues. 2003-09-09 19:39:31 +00:00
Alexandre Julliard
e37c6e18d0 Fixed header dependencies to be fully compatible with the Windows
headers (with help from Dimitrie O. Paun).
2003-09-05 23:08:26 +00:00
Martin Fuchs
63fecde98b Declare LPCITEMIDLIST as 'const' pointer and adjust shell32
implementation to the corrected type.
2003-09-02 01:01:06 +00:00
Mike McCormack
8e98b9cda4 Stub for (undocumented) SHCreateLinks. 2003-08-21 21:26:07 +00:00
Francois Gouget
c5f775a9c7 Typos/spelling fixes. 2003-06-18 03:30:39 +00:00
Vitaliy Margolen
11c19c509d Add few SFGAO_CAN* attributes to supported list. 2003-03-05 02:48:26 +00:00
Alberto Massari
84c48b957b Fixes to IShellFolder::GetAttributesOf:
- before computing the flags for the requested entry, reset the bits
  we don't support, or we will tell something we didn't want to.
- instead of using an hexadecimal mask for the unsupported flags, use
  a mask made of the supported ones
- replace the obscure hexadecimal values with the proper macros
2003-02-27 21:04:38 +00:00
Ove Kaaven
1f5315c80f Make sure that no files except unknwn.h include wine/obj_base.h
directly.
2002-12-05 20:33:07 +00:00
Gregg Mattinson
8c9bdcc9e1 Fixes for Sparc build. 2002-08-07 01:18:41 +00:00
Juergen Schmied
1e5ec8893d - Cleaned up the implementation of shell folders and put them into
separate files.
- Fixed some memory leaks.
- Some more fixes.
2002-07-24 01:56:03 +00:00
Gregg Mattinson
25ee95cd5d Initialized the pidlOut variable in SHELL32_ParseNextElement to
prevent a crash in some cases.
2002-07-16 01:11:52 +00:00