mirror of
https://github.com/reactos/wine.git
synced 2024-12-11 13:26:00 +00:00
da0175ba71
Certain WM_LBUTTONDOWN & WM_LBUTTONUP events should change focus to the ComboBox (a child of ComboBoxEx), but instead the focus was set to the Edit control.
369 lines
13 KiB
C
369 lines
13 KiB
C
/* Unit test suite for combo boxes.
|
|
*
|
|
* Copyright 2007 Mikolaj Zalewski
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
|
|
*/
|
|
|
|
#include <assert.h>
|
|
#include <stdarg.h>
|
|
#include <stdio.h>
|
|
|
|
#define STRICT
|
|
#define WIN32_LEAN_AND_MEAN
|
|
#include <windows.h>
|
|
|
|
#include "wine/test.h"
|
|
|
|
#define COMBO_ID 1995
|
|
|
|
static HWND hMainWnd;
|
|
|
|
#define expect_eq(expr, value, type, fmt); { type val = expr; ok(val == (value), #expr " expected " #fmt " got " #fmt "\n", (value), val); }
|
|
#define expect_rect(r, _left, _top, _right, _bottom) ok(r.left == _left && r.top == _top && \
|
|
r.bottom == _bottom && r.right == _right, "Invalid rect (%d,%d) (%d,%d) vs (%d,%d) (%d,%d)\n", \
|
|
r.left, r.top, r.right, r.bottom, _left, _top, _right, _bottom);
|
|
|
|
static HWND build_combo(DWORD style)
|
|
{
|
|
return CreateWindow("ComboBox", "Combo", WS_VISIBLE|WS_CHILD|style, 5, 5, 100, 100, hMainWnd, (HMENU)COMBO_ID, NULL, 0);
|
|
}
|
|
|
|
static int font_height(HFONT hFont)
|
|
{
|
|
TEXTMETRIC tm;
|
|
HFONT hFontOld;
|
|
HDC hDC;
|
|
|
|
hDC = CreateCompatibleDC(NULL);
|
|
hFontOld = SelectObject(hDC, hFont);
|
|
GetTextMetrics(hDC, &tm);
|
|
SelectObject(hDC, hFontOld);
|
|
DeleteDC(hDC);
|
|
|
|
return tm.tmHeight;
|
|
}
|
|
|
|
static INT CALLBACK is_font_installed_proc(const LOGFONT *elf, const TEXTMETRIC *tm, DWORD type, LPARAM lParam)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int is_font_installed(const char *name)
|
|
{
|
|
HDC hdc = GetDC(NULL);
|
|
BOOL ret = !EnumFontFamilies(hdc, name, is_font_installed_proc, 0);
|
|
ReleaseDC(NULL, hdc);
|
|
return ret;
|
|
}
|
|
|
|
static void test_setitemheight(DWORD style)
|
|
{
|
|
HWND hCombo = build_combo(style);
|
|
RECT r;
|
|
int i;
|
|
|
|
trace("Style %x\n", style);
|
|
GetClientRect(hCombo, &r);
|
|
expect_rect(r, 0, 0, 100, 24);
|
|
SendMessageA(hCombo, CB_GETDROPPEDCONTROLRECT, 0, (LPARAM)&r);
|
|
MapWindowPoints(HWND_DESKTOP, hMainWnd, (LPPOINT)&r, 2);
|
|
todo_wine expect_rect(r, 5, 5, 105, 105);
|
|
|
|
for (i = 1; i < 30; i++)
|
|
{
|
|
SendMessage(hCombo, CB_SETITEMHEIGHT, -1, i);
|
|
GetClientRect(hCombo, &r);
|
|
expect_eq(r.bottom - r.top, i + 6, int, "%d");
|
|
}
|
|
|
|
DestroyWindow(hCombo);
|
|
}
|
|
|
|
static void test_setfont(DWORD style)
|
|
{
|
|
HWND hCombo = build_combo(style);
|
|
HFONT hFont1 = CreateFont(10, 0, 0, 0, FW_DONTCARE, FALSE, FALSE, FALSE, ANSI_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, DEFAULT_PITCH|FF_DONTCARE, "Marlett");
|
|
HFONT hFont2 = CreateFont(8, 0, 0, 0, FW_DONTCARE, FALSE, FALSE, FALSE, ANSI_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, DEFAULT_PITCH|FF_DONTCARE, "Marlett");
|
|
RECT r;
|
|
int i;
|
|
|
|
trace("Style %x\n", style);
|
|
GetClientRect(hCombo, &r);
|
|
expect_rect(r, 0, 0, 100, 24);
|
|
SendMessageA(hCombo, CB_GETDROPPEDCONTROLRECT, 0, (LPARAM)&r);
|
|
MapWindowPoints(HWND_DESKTOP, hMainWnd, (LPPOINT)&r, 2);
|
|
todo_wine expect_rect(r, 5, 5, 105, 105);
|
|
|
|
if (!is_font_installed("Marlett"))
|
|
{
|
|
skip("Marlett font not available\n");
|
|
DestroyWindow(hCombo);
|
|
DeleteObject(hFont1);
|
|
DeleteObject(hFont2);
|
|
return;
|
|
}
|
|
|
|
if (font_height(hFont1) == 10 && font_height(hFont2) == 8)
|
|
{
|
|
SendMessage(hCombo, WM_SETFONT, (WPARAM)hFont1, FALSE);
|
|
GetClientRect(hCombo, &r);
|
|
expect_rect(r, 0, 0, 100, 18);
|
|
SendMessageA(hCombo, CB_GETDROPPEDCONTROLRECT, 0, (LPARAM)&r);
|
|
MapWindowPoints(HWND_DESKTOP, hMainWnd, (LPPOINT)&r, 2);
|
|
todo_wine expect_rect(r, 5, 5, 105, 99);
|
|
|
|
SendMessage(hCombo, WM_SETFONT, (WPARAM)hFont2, FALSE);
|
|
GetClientRect(hCombo, &r);
|
|
expect_rect(r, 0, 0, 100, 16);
|
|
SendMessageA(hCombo, CB_GETDROPPEDCONTROLRECT, 0, (LPARAM)&r);
|
|
MapWindowPoints(HWND_DESKTOP, hMainWnd, (LPPOINT)&r, 2);
|
|
todo_wine expect_rect(r, 5, 5, 105, 97);
|
|
|
|
SendMessage(hCombo, WM_SETFONT, (WPARAM)hFont1, FALSE);
|
|
GetClientRect(hCombo, &r);
|
|
expect_rect(r, 0, 0, 100, 18);
|
|
SendMessageA(hCombo, CB_GETDROPPEDCONTROLRECT, 0, (LPARAM)&r);
|
|
MapWindowPoints(HWND_DESKTOP, hMainWnd, (LPPOINT)&r, 2);
|
|
todo_wine expect_rect(r, 5, 5, 105, 99);
|
|
}
|
|
else
|
|
skip("Invalid Marlett font heights\n");
|
|
|
|
for (i = 1; i < 30; i++)
|
|
{
|
|
HFONT hFont = CreateFont(i, 0, 0, 0, FW_DONTCARE, FALSE, FALSE, FALSE, ANSI_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, DEFAULT_PITCH|FF_DONTCARE, "Marlett");
|
|
int height = font_height(hFont);
|
|
|
|
SendMessage(hCombo, WM_SETFONT, (WPARAM)hFont, FALSE);
|
|
GetClientRect(hCombo, &r);
|
|
expect_eq(r.bottom - r.top, height + 8, int, "%d");
|
|
SendMessage(hCombo, WM_SETFONT, 0, FALSE);
|
|
DeleteObject(hFont);
|
|
}
|
|
|
|
DestroyWindow(hCombo);
|
|
DeleteObject(hFont1);
|
|
DeleteObject(hFont2);
|
|
}
|
|
|
|
static LRESULT (CALLBACK *old_parent_proc)(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam);
|
|
static LPCSTR expected_edit_text;
|
|
static LPCSTR expected_list_text;
|
|
static BOOL selchange_fired;
|
|
|
|
static LRESULT CALLBACK parent_wnd_proc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam)
|
|
{
|
|
switch (msg)
|
|
{
|
|
case WM_COMMAND:
|
|
switch (wparam)
|
|
{
|
|
case MAKEWPARAM(COMBO_ID, CBN_SELCHANGE):
|
|
{
|
|
HWND hCombo = (HWND)lparam;
|
|
int idx;
|
|
char list[20], edit[20];
|
|
|
|
memset(list, 0, sizeof(list));
|
|
memset(edit, 0, sizeof(edit));
|
|
|
|
idx = SendMessage(hCombo, CB_GETCURSEL, 0, 0);
|
|
SendMessage(hCombo, CB_GETLBTEXT, idx, (LPARAM)list);
|
|
SendMessage(hCombo, WM_GETTEXT, sizeof(edit), (LPARAM)edit);
|
|
|
|
ok(!strcmp(edit, expected_edit_text), "edit: got %s, expected %s\n",
|
|
edit, expected_edit_text);
|
|
ok(!strcmp(list, expected_list_text), "list: got %s, expected %s\n",
|
|
list, expected_list_text);
|
|
|
|
selchange_fired = TRUE;
|
|
}
|
|
break;
|
|
}
|
|
break;
|
|
}
|
|
|
|
return CallWindowProc(old_parent_proc, hwnd, msg, wparam, lparam);
|
|
}
|
|
|
|
static void test_selection(DWORD style, const char * const text[],
|
|
const int *edit, const int *list)
|
|
{
|
|
INT idx;
|
|
HWND hCombo;
|
|
|
|
hCombo = build_combo(style);
|
|
|
|
SendMessage(hCombo, CB_ADDSTRING, 0, (LPARAM)text[0]);
|
|
SendMessage(hCombo, CB_ADDSTRING, 0, (LPARAM)text[1]);
|
|
SendMessage(hCombo, CB_SETCURSEL, -1, 0);
|
|
|
|
old_parent_proc = (void *)SetWindowLongPtr(hMainWnd, GWLP_WNDPROC, (ULONG_PTR)parent_wnd_proc);
|
|
|
|
idx = SendMessage(hCombo, CB_GETCURSEL, 0, 0);
|
|
ok(idx == -1, "expected selection -1, got %d\n", idx);
|
|
|
|
/* keyboard navigation */
|
|
|
|
expected_list_text = text[list[0]];
|
|
expected_edit_text = text[edit[0]];
|
|
selchange_fired = FALSE;
|
|
SendMessage(hCombo, WM_KEYDOWN, VK_DOWN, 0);
|
|
ok(selchange_fired, "CBN_SELCHANGE not sent!\n");
|
|
|
|
expected_list_text = text[list[1]];
|
|
expected_edit_text = text[edit[1]];
|
|
selchange_fired = FALSE;
|
|
SendMessage(hCombo, WM_KEYDOWN, VK_DOWN, 0);
|
|
ok(selchange_fired, "CBN_SELCHANGE not sent!\n");
|
|
|
|
expected_list_text = text[list[2]];
|
|
expected_edit_text = text[edit[2]];
|
|
selchange_fired = FALSE;
|
|
SendMessage(hCombo, WM_KEYDOWN, VK_UP, 0);
|
|
ok(selchange_fired, "CBN_SELCHANGE not sent!\n");
|
|
|
|
/* programmatic navigation */
|
|
|
|
expected_list_text = text[list[3]];
|
|
expected_edit_text = text[edit[3]];
|
|
selchange_fired = FALSE;
|
|
SendMessage(hCombo, CB_SETCURSEL, list[3], 0);
|
|
ok(!selchange_fired, "CBN_SELCHANGE sent!\n");
|
|
|
|
expected_list_text = text[list[4]];
|
|
expected_edit_text = text[edit[4]];
|
|
selchange_fired = FALSE;
|
|
SendMessage(hCombo, CB_SETCURSEL, list[4], 0);
|
|
ok(!selchange_fired, "CBN_SELCHANGE sent!\n");
|
|
|
|
SetWindowLongPtr(hMainWnd, GWLP_WNDPROC, (ULONG_PTR)old_parent_proc);
|
|
DestroyWindow(hCombo);
|
|
}
|
|
|
|
static void test_CBN_SELCHANGE(void)
|
|
{
|
|
static const char * const text[] = { "alpha", "beta", "" };
|
|
static const int sel_1[] = { 2, 0, 1, 0, 1 };
|
|
static const int sel_2[] = { 0, 1, 0, 0, 1 };
|
|
|
|
test_selection(CBS_SIMPLE, text, sel_1, sel_2);
|
|
test_selection(CBS_DROPDOWN, text, sel_1, sel_2);
|
|
test_selection(CBS_DROPDOWNLIST, text, sel_2, sel_2);
|
|
}
|
|
|
|
static void test_WM_LBUTTONDOWN(void)
|
|
{
|
|
HWND hCombo, hEdit, hList;
|
|
COMBOBOXINFO cbInfo;
|
|
UINT x, y, item_height;
|
|
LRESULT result;
|
|
int i, idx;
|
|
RECT rect;
|
|
WCHAR buffer[3];
|
|
static const UINT choices[] = {8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72};
|
|
static const WCHAR stringFormat[] = {'%','2','d','\0'};
|
|
|
|
hCombo = CreateWindow("ComboBox", "Combo", WS_VISIBLE|WS_CHILD|CBS_DROPDOWN,
|
|
0, 0, 200, 150, hMainWnd, (HMENU)COMBO_ID, NULL, 0);
|
|
|
|
for (i = 0; i < sizeof(choices)/sizeof(UINT); i++){
|
|
wsprintfW(buffer, stringFormat, choices[i]);
|
|
ok(SendMessageW(hCombo, CB_ADDSTRING, 0, (LPARAM)&buffer) != CB_ERR,
|
|
"Failed to add item %d\n", i);
|
|
}
|
|
|
|
cbInfo.cbSize = sizeof(COMBOBOXINFO);
|
|
result = SendMessage(hCombo, CB_GETCOMBOBOXINFO, 0, (LPARAM)&cbInfo);
|
|
ok(result, "Failed to get combobox info structure. LastError=%d\n",
|
|
GetLastError());
|
|
hEdit = cbInfo.hwndItem;
|
|
hList = cbInfo.hwndList;
|
|
|
|
trace("hMainWnd=%x, hCombo=%x, hList=%x, hEdit=%x\n",
|
|
(UINT)hMainWnd, (UINT)hCombo, (UINT)hList, (UINT)hEdit);
|
|
ok(GetFocus() == hMainWnd, "Focus not on Main Window, instead on %x\n",
|
|
(UINT)GetFocus());
|
|
|
|
/* Click on the button to drop down the list */
|
|
x = cbInfo.rcButton.left + (cbInfo.rcButton.right-cbInfo.rcButton.left)/2;
|
|
y = cbInfo.rcButton.top + (cbInfo.rcButton.bottom-cbInfo.rcButton.top)/2;
|
|
result = SendMessage(hCombo, WM_LBUTTONDOWN, 0, MAKELPARAM(x, y));
|
|
ok(result, "WM_LBUTTONDOWN was not processed. LastError=%d\n",
|
|
GetLastError());
|
|
ok(SendMessage(hCombo, CB_GETDROPPEDSTATE, 0, 0),
|
|
"The dropdown list should have appeared after clicking the button.\n");
|
|
|
|
ok(GetFocus() == hEdit,
|
|
"Focus not on ComboBox's Edit Control, instead on %x\n",
|
|
(UINT)GetFocus());
|
|
result = SendMessage(hCombo, WM_LBUTTONUP, 0, MAKELPARAM(x, y));
|
|
ok(result, "WM_LBUTTONUP was not processed. LastError=%d\n",
|
|
GetLastError());
|
|
ok(GetFocus() == hEdit,
|
|
"Focus not on ComboBox's Edit Control, instead on %x\n",
|
|
(UINT)GetFocus());
|
|
|
|
/* Click on the 5th item in the list */
|
|
item_height = SendMessage(hCombo, CB_GETITEMHEIGHT, 0, 0);
|
|
ok(GetClientRect(hList, &rect), "Failed to get list's client rect.\n");
|
|
x = rect.left + (rect.right-rect.left)/2;
|
|
y = item_height/2 + item_height*4;
|
|
result = SendMessage(hList, WM_LBUTTONDOWN, 0, MAKELPARAM(x, y));
|
|
ok(!result, "WM_LBUTTONDOWN was not processed. LastError=%d\n",
|
|
GetLastError());
|
|
ok(GetFocus() == hEdit,
|
|
"Focus not on ComboBox's Edit Control, instead on %x\n",
|
|
(UINT)GetFocus());
|
|
|
|
result = SendMessage(hList, WM_MOUSEMOVE, 0, MAKELPARAM(x, y));
|
|
ok(!result, "WM_MOUSEMOVE was not processed. LastError=%d\n",
|
|
GetLastError());
|
|
ok(GetFocus() == hEdit,
|
|
"Focus not on ComboBox's Edit Control, instead on %x\n",
|
|
(UINT)GetFocus());
|
|
ok(SendMessage(hCombo, CB_GETDROPPEDSTATE, 0, 0),
|
|
"The dropdown list should still be visible.\n");
|
|
|
|
result = SendMessage(hList, WM_LBUTTONUP, 0, MAKELPARAM(x, y));
|
|
ok(!result, "WM_LBUTTONUP was not processed. LastError=%d\n",
|
|
GetLastError());
|
|
ok(GetFocus() == hEdit,
|
|
"Focus not on ComboBox's Edit Control, instead on %x\n",
|
|
(UINT)GetFocus());
|
|
ok(!SendMessage(hCombo, CB_GETDROPPEDSTATE, 0, 0),
|
|
"The dropdown list should have been rolled up.\n");
|
|
idx = SendMessage(hCombo, CB_GETCURSEL, 0, 0);
|
|
ok(idx, "Current Selection: expected %d, got %d\n", 4, idx);
|
|
|
|
DestroyWindow(hCombo);
|
|
}
|
|
|
|
START_TEST(combo)
|
|
{
|
|
hMainWnd = CreateWindow("static", "Test", WS_OVERLAPPEDWINDOW, 10, 10, 300, 300, NULL, NULL, NULL, 0);
|
|
ShowWindow(hMainWnd, SW_SHOW);
|
|
|
|
test_setfont(CBS_DROPDOWN);
|
|
test_setfont(CBS_DROPDOWNLIST);
|
|
test_setitemheight(CBS_DROPDOWN);
|
|
test_setitemheight(CBS_DROPDOWNLIST);
|
|
test_CBN_SELCHANGE();
|
|
test_WM_LBUTTONDOWN();
|
|
|
|
DestroyWindow(hMainWnd);
|
|
}
|