Files
romm/backend
Georges-Antoine AssiandClaude Opus 5.5 3deb38d93a fix(scan): keep an uploaded manual when the rom had no scraped one (#5030)
* fix(scan): keep an uploaded manual when the rom had no scraped one

Update, unmatched and hashes scans pin a stored manual url, but a manual
uploaded to a rom without a scraped url has nothing to pin. The provider's
url then won, differed from the empty stored one, and its download
overwrote the upload at the shared manual path. A locked manual, or one
on disk with no source url, now keeps its empty url through the scan.

Fixes #4101

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

* fix(scan): drop a scraped manual's path on unmatch, test the download stage

Addresses Greptile's review on #5030:
- Unmatch cleared url_manual but kept path_manual, so the next scan read the
  old scraped manual as an upload and never fetched the new match's one. It
  now clears path_manual too, unless url_manual is locked (an upload).
- Trim the url_manual comment to two lines.
- Carry the scan result through download_rom_resources in the upload test and
  check the manual is never stored over.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 18:59:08 -04:00
..
2026-10-01 19:17:30 -04:00
2024-02-10 12:43:39 -05:00
2025-07-05 19:17:40 -04:00