fix: propagate queryStr to concrete vectorStore (#1495)

Co-authored-by: Alex Yang <himself65@outlook.com>
This commit is contained in:
Wassim Chegham
2024-11-15 20:16:32 +01:00
committed by GitHub
parent 3d503cb810
commit 5dae534f8d
2 changed files with 13 additions and 1 deletions
+5
View File
@@ -0,0 +1,5 @@
---
"llamaindex": patch
---
fix: propagate queryStr to concrete vectorStore
@@ -18,6 +18,7 @@ import {
type NodeWithScore,
} from "@llamaindex/core/schema";
import type { BaseIndexStore } from "@llamaindex/core/storage/index-store";
import { extractText } from "@llamaindex/core/utils";
import type { ServiceContext } from "../../ServiceContext.js";
import { nodeParserFromSettingsOrContext } from "../../Settings.js";
import { RetrieverQueryEngine } from "../../engines/query/RetrieverQueryEngine.js";
@@ -449,8 +450,13 @@ export class VectorIndexRetriever extends BaseRetriever {
filters?: MetadataFilters,
): Promise<NodeWithScore[]> {
// convert string message to multi-modal format
let queryStr = query;
if (typeof query === "string") {
query = [{ type: "text", text: query }];
queryStr = query;
query = [{ type: "text", text: queryStr }];
} else {
queryStr = extractText(query);
}
// overwrite embed model if specified, otherwise use the one from the vector store
const embedModel = this.index.embedModel ?? vectorStore.embedModel;
@@ -460,6 +466,7 @@ export class VectorIndexRetriever extends BaseRetriever {
const queryEmbedding = await embedModel.getQueryEmbedding(item);
if (queryEmbedding) {
const result = await vectorStore.query({
queryStr,
queryEmbedding,
mode: VectorStoreQueryMode.DEFAULT,
similarityTopK: this.topK[type]!,