run-llama/chat-ui
1
0
Fork 0
mirror of https://github.com/run-llama/chat-ui.git synced 2026-07-21 03:15:21 -04:00
Code Issues 13 Packages Projects Releases 10 Wiki Activity

[PR #149] [MERGED] set the run status to running as soon as event streaming starts #161

New Issue
Closed
opened 2026-02-16 03:15:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 03:15:25 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/chat-ui/pull/149
Author: @adrianlyjak
Created: 6/25/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @marcusschiesser

Base: main ← Head: adrian/fix-148

📝 Commits (7)

  • a1e9a93 Failing test to recreate #148
  • 19c1533 Fix the status bug
  • 3796da3 this is failing when resuming a task too
  • 1a66ea8 use actual streaming response
  • c0ad533 set status running as soon as start streaming events
  • e4e1632 Create empty-mails-laugh.md
  • 56ef202 update changeset

📊 Changes

5 files changed (+124 additions, -4 deletions)

View changed files

➕ .changeset/empty-mails-laugh.md (+5 -0)
➕ .prettierignore (+1 -0)
📝 packages/chat-ui/src/hook/use-workflow/hook.ts (+2 -3)
📝 packages/chat-ui/src/hook/use-workflow/types.ts (+1 -1)
📝 packages/chat-ui/src/test/__tests__/use-workflow.test.tsx (+115 -0)

📄 Description

Hmm, I can't actually recreate this with a realistic streaming response. I wonder if we're doing something improper in llamadeploy causing the header section to not complete before the first event is sent.

I could "fix" this by setting the status as soon as the /events request is sent (rather than waiting for ok ack from SSE headers)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/chat-ui/pull/149 **Author:** [@adrianlyjak](https://github.com/adrianlyjak) **Created:** 6/25/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@marcusschiesser](https://github.com/marcusschiesser) **Base:** `main` ← **Head:** `adrian/fix-148` --- ### 📝 Commits (7) - [`a1e9a93`](https://github.com/run-llama/chat-ui/commit/a1e9a93aa278165c9204b2c3639aeefc76e9b4ba) Failing test to recreate #148 - [`19c1533`](https://github.com/run-llama/chat-ui/commit/19c15335a4f115344e0e088c8f4f66b90bc595e8) Fix the status bug - [`3796da3`](https://github.com/run-llama/chat-ui/commit/3796da39e057d700b1a0a8c1a97ed8d8e53ecd2d) this is failing when resuming a task too - [`1a66ea8`](https://github.com/run-llama/chat-ui/commit/1a66ea897290ec84ff6e496e9f9ce21d47fca334) use actual streaming response - [`c0ad533`](https://github.com/run-llama/chat-ui/commit/c0ad533fdc63f0977666819bfe0cfd62897737a3) set status running as soon as start streaming events - [`e4e1632`](https://github.com/run-llama/chat-ui/commit/e4e1632cf9d1ee03a74304b8845b9ffc0d610a82) Create empty-mails-laugh.md - [`56ef202`](https://github.com/run-llama/chat-ui/commit/56ef202443bfdc7275d5b4953818936234e799b2) update changeset ### 📊 Changes **5 files changed** (+124 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/empty-mails-laugh.md` (+5 -0) ➕ `.prettierignore` (+1 -0) 📝 `packages/chat-ui/src/hook/use-workflow/hook.ts` (+2 -3) 📝 `packages/chat-ui/src/hook/use-workflow/types.ts` (+1 -1) 📝 `packages/chat-ui/src/test/__tests__/use-workflow.test.tsx` (+115 -0) </details> ### 📄 Description Hmm, I can't actually recreate this with a realistic streaming response. I wonder if we're doing something improper in llamadeploy causing the header section to not complete before the first event is sent. I could "fix" this by setting the status as soon as the /events request is sent (rather than waiting for ok ack from SSE headers) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 03:15:25 -05:00
yindo closed this issue 2026-02-16 03:15:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/chat-ui#161
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?