run-llama/chat-ui
1
0
Fork 0
mirror of https://github.com/run-llama/chat-ui.git synced 2026-07-21 03:15:21 -04:00
Code Issues 13 Packages Projects Releases 10 Wiki Activity

[PR #58] [MERGED] Always preprocess citations without sources #85

New Issue
Closed
opened 2026-02-16 03:15:03 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 03:15:03 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/chat-ui/pull/58
Author: @leehuwuj
Created: 3/10/2025
Status: ✅ Merged
Merged: 3/11/2025
Merged by: @marcusschiesser

Base: main ← Head: lee/fix-citation-source

📝 Commits (2)

📊 Changes

2 files changed (+22 additions, -19 deletions)

View changed files

➕ .changeset/yellow-webs-hunt.md (+5 -0)
📝 packages/chat-ui/src/widgets/markdown.tsx (+17 -19)

📄 Description

  • Always preprocess citation to convert into a link or trim out the incomplete citation text without sources data.
  • In markdown, if a matched source node is found, render a citation; otherwise, render nothing (which also involves cleaning up the citation ID to not display it to the user).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/chat-ui/pull/58 **Author:** [@leehuwuj](https://github.com/leehuwuj) **Created:** 3/10/2025 **Status:** ✅ Merged **Merged:** 3/11/2025 **Merged by:** [@marcusschiesser](https://github.com/marcusschiesser) **Base:** `main` ← **Head:** `lee/fix-citation-source` --- ### 📝 Commits (2) - [`32bceab`](https://github.com/run-llama/chat-ui/commit/32bceab345f8425a53fbe074a89b15a608838c01) remove sources dependencies - [`c3db6a2`](https://github.com/run-llama/chat-ui/commit/c3db6a2e1dba727b53eea2f8677e1244050a928f) add changeset ### 📊 Changes **2 files changed** (+22 additions, -19 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/yellow-webs-hunt.md` (+5 -0) 📝 `packages/chat-ui/src/widgets/markdown.tsx` (+17 -19) </details> ### 📄 Description + Always preprocess citation to convert into a link or trim out the incomplete citation text without sources data. + In markdown, if a matched source node is found, render a citation; otherwise, render nothing (which also involves cleaning up the citation ID to not display it to the user). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 03:15:03 -05:00
yindo closed this issue 2026-02-16 03:15:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/chat-ui#85
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?