run-llama/chat-ui
1
0
Fork 0
mirror of https://github.com/run-llama/chat-ui.git synced 2026-07-20 19:04:22 -04:00
Code Issues 13 Packages Projects Releases 10 Wiki Activity

[PR #61] [MERGED] fix: prevent message send during text composition #86

New Issue
Closed
opened 2026-02-16 03:15:03 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 03:15:03 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/chat-ui/pull/61
Author: @lemorage
Created: 3/17/2025
Status: ✅ Merged
Merged: 3/19/2025
Merged by: @marcusschiesser

Base: main ← Head: fix-text-composition-input

📝 Commits (3)

  • bff364b fix: prevent message send during text composition
  • b47f571 Create chilly-cups-decide.md
  • e0d17f2 Update chilly-cups-decide.md

📊 Changes

2 files changed (+22 additions, -4 deletions)

View changed files

➕ .changeset/chilly-cups-decide.md (+5 -0)
📝 packages/chat-ui/src/chat/chat-input.tsx (+17 -4)

📄 Description

Inspired by @nxnen8282's solution, this PR is aimed to fix #60, but instead of using e.nativeEvent.isComposing, the React Composition Events is used here.

@nxnen8282's solution: https://github.com/nxnen8282/run-llama-chat-ui-60/commit/5a936f5adcd8e05f7272ac839197d039e8e6c685

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/chat-ui/pull/61 **Author:** [@lemorage](https://github.com/lemorage) **Created:** 3/17/2025 **Status:** ✅ Merged **Merged:** 3/19/2025 **Merged by:** [@marcusschiesser](https://github.com/marcusschiesser) **Base:** `main` ← **Head:** `fix-text-composition-input` --- ### 📝 Commits (3) - [`bff364b`](https://github.com/run-llama/chat-ui/commit/bff364bc4f34998489c5cd7187aa72859bb96681) fix: prevent message send during text composition - [`b47f571`](https://github.com/run-llama/chat-ui/commit/b47f57190d3a98eb796914e95ba9c15263ef6d79) Create chilly-cups-decide.md - [`e0d17f2`](https://github.com/run-llama/chat-ui/commit/e0d17f20f682f1610d25e3f444234ce6def4f7e9) Update chilly-cups-decide.md ### 📊 Changes **2 files changed** (+22 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/chilly-cups-decide.md` (+5 -0) 📝 `packages/chat-ui/src/chat/chat-input.tsx` (+17 -4) </details> ### 📄 Description Inspired by @nxnen8282's solution, this PR is aimed to fix #60, but instead of using `e.nativeEvent.isComposing`, the **React Composition Events** is used here. > @nxnen8282's solution: https://github.com/nxnen8282/run-llama-chat-ui-60/commit/5a936f5adcd8e05f7272ac839197d039e8e6c685 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 03:15:03 -05:00
yindo closed this issue 2026-02-16 03:15:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/chat-ui#86
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?