run-llama/create-llama
1
0
Fork 0
mirror of https://github.com/run-llama/create-llama.git synced 2026-07-16 03:04:21 -04:00
Code Issues 39 Packages Projects Releases 10 Wiki Activity

[PR #247] [MERGED] feat: Use the retrieval defaults from LlamaCloud #378

New Issue
Closed
opened 2026-02-15 19:17:27 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 19:17:27 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/create-llama/pull/247
Author: @marcusschiesser
Created: 8/21/2024
Status: ✅ Merged
Merged: 8/22/2024
Merged by: @marcusschiesser

Base: main ← Head: ms/use-llamacloud-default

📝 Commits (2)

  • c76ad72 feat: Use the retrieval defaults from LlamaCloud
  • 606fbb4 fix: similarity_top_k does not always support none

📊 Changes

7 files changed (+16 additions, -10 deletions)

View changed files

➕ .changeset/weak-students-pay.md (+5 -0)
📝 helpers/env-variables.ts (+0 -1)
📝 templates/components/engines/python/agent/engine.py (+2 -2)
📝 templates/components/engines/python/chat/engine.py (+2 -3)
📝 templates/components/engines/typescript/chat/chat.ts (+1 -1)
📝 templates/types/extractor/fastapi/app/engine/engine.py (+2 -2)
📝 templates/types/multiagent/fastapi/app/agents/query_engine/agent.py (+4 -1)

📄 Description

Summary by CodeRabbit

  • New Features

    • Enhanced data retrieval capabilities related to student payment information with the integration of LlamaCloud's retrieval defaults.
    • Improved flexibility in the handling of the TOP_K parameter across various components, allowing for a None value where previously a default integer was enforced.

  • Bug Fixes

    • Addressed issues related to default values for the TOP_K environment variable to improve the logic and functionality of query engines.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/create-llama/pull/247 **Author:** [@marcusschiesser](https://github.com/marcusschiesser) **Created:** 8/21/2024 **Status:** ✅ Merged **Merged:** 8/22/2024 **Merged by:** [@marcusschiesser](https://github.com/marcusschiesser) **Base:** `main` ← **Head:** `ms/use-llamacloud-default` --- ### 📝 Commits (2) - [`c76ad72`](https://github.com/run-llama/create-llama/commit/c76ad7260d1119b92d4d23bab33882cf2da64f6b) feat: Use the retrieval defaults from LlamaCloud - [`606fbb4`](https://github.com/run-llama/create-llama/commit/606fbb42d4de986c032a3d09ef950e9afe08f4ae) fix: similarity_top_k does not always support none ### 📊 Changes **7 files changed** (+16 additions, -10 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/weak-students-pay.md` (+5 -0) 📝 `helpers/env-variables.ts` (+0 -1) 📝 `templates/components/engines/python/agent/engine.py` (+2 -2) 📝 `templates/components/engines/python/chat/engine.py` (+2 -3) 📝 `templates/components/engines/typescript/chat/chat.ts` (+1 -1) 📝 `templates/types/extractor/fastapi/app/engine/engine.py` (+2 -2) 📝 `templates/types/multiagent/fastapi/app/agents/query_engine/agent.py` (+4 -1) </details> ### 📄 Description <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced data retrieval capabilities related to student payment information with the integration of LlamaCloud's retrieval defaults. - Improved flexibility in the handling of the `TOP_K` parameter across various components, allowing for a `None` value where previously a default integer was enforced. - **Bug Fixes** - Addressed issues related to default values for the `TOP_K` environment variable to improve the logic and functionality of query engines. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 19:17:27 -05:00
yindo closed this issue 2026-02-15 19:17:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/create-llama#378
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?