run-llama/create-llama
1
0
Fork 0
mirror of https://github.com/run-llama/create-llama.git synced 2026-07-19 23:13:36 -04:00
Code Issues 39 Packages Projects Releases 10 Wiki Activity

[PR #332] [MERGED] refactor: make saveDocument reusable #429

New Issue
Closed
opened 2026-02-15 19:17:38 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 19:17:38 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/create-llama/pull/332
Author: @marcusschiesser
Created: 10/1/2024
Status: ✅ Merged
Merged: 10/1/2024
Merged by: @marcusschiesser

Base: main ← Head: ms/export-doc-write

📝 Commits (1)

  • f4c2810 refactor: make saveDocument reusable

📊 Changes

1 file changed (+5 additions, -9 deletions)

View changed files

📝 templates/components/llamaindex/typescript/documents/helper.ts (+5 -9)

📄 Description

Summary by CodeRabbit

  • New Features

    • Enhanced document handling with improved MIME type validation to ensure only supported file types are processed.

  • Bug Fixes

    • Fixed issues related to unsupported document types by implementing early error handling.

  • Refactor

    • Simplified the saveDocument method by removing the unnecessary MIME type parameter, streamlining the interface.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/create-llama/pull/332 **Author:** [@marcusschiesser](https://github.com/marcusschiesser) **Created:** 10/1/2024 **Status:** ✅ Merged **Merged:** 10/1/2024 **Merged by:** [@marcusschiesser](https://github.com/marcusschiesser) **Base:** `main` ← **Head:** `ms/export-doc-write` --- ### 📝 Commits (1) - [`f4c2810`](https://github.com/run-llama/create-llama/commit/f4c2810e17c75d080dba78d5acceab9c284af261) refactor: make saveDocument reusable ### 📊 Changes **1 file changed** (+5 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `templates/components/llamaindex/typescript/documents/helper.ts` (+5 -9) </details> ### 📄 Description <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced document handling with improved MIME type validation to ensure only supported file types are processed. - **Bug Fixes** - Fixed issues related to unsupported document types by implementing early error handling. - **Refactor** - Simplified the `saveDocument` method by removing the unnecessary MIME type parameter, streamlining the interface. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 19:17:38 -05:00
yindo closed this issue 2026-02-15 19:17:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/create-llama#429
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?