[PR #9] [MERGED] Fix MessageQueuePublisherMixin #205

Closed
opened 2026-02-16 01:16:27 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/9
Author: @nerdai
Created: 6/10/2024
Status: Merged
Merged: 6/10/2024
Merged by: @nerdai

Base: mainHead: nerda/fix-mixin


📝 Commits (1)

📊 Changes

5 files changed (+66 additions, -19 deletions)

View changed files

📝 agentfile/agent_server/fastapi.py (+13 -3)
📝 agentfile/control_plane/fastapi.py (+15 -5)
📝 agentfile/launchers/local.py (+13 -3)
📝 agentfile/message_publishers/publisher.py (+16 -6)
📝 tests/test_agent_server.py (+9 -2)

📄 Description

  • Previous checked in mixin had init() which is not good practice
  • Fix by using @property and @abstractmethod which is a pattern we've adopted elsewhere already (i.e., BaseAgentServer for agent_definition)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/9 **Author:** [@nerdai](https://github.com/nerdai) **Created:** 6/10/2024 **Status:** ✅ Merged **Merged:** 6/10/2024 **Merged by:** [@nerdai](https://github.com/nerdai) **Base:** `main` ← **Head:** `nerda/fix-mixin` --- ### 📝 Commits (1) - [`673fee4`](https://github.com/run-llama/llama_deploy/commit/673fee479a044b8856ae8702fe2317f0e2122c77) fix mixin ### 📊 Changes **5 files changed** (+66 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `agentfile/agent_server/fastapi.py` (+13 -3) 📝 `agentfile/control_plane/fastapi.py` (+15 -5) 📝 `agentfile/launchers/local.py` (+13 -3) 📝 `agentfile/message_publishers/publisher.py` (+16 -6) 📝 `tests/test_agent_server.py` (+9 -2) </details> ### 📄 Description - Previous checked in mixin had __init__() which is not good practice - Fix by using @property and @abstractmethod which is a pattern we've adopted elsewhere already (i.e., `BaseAgentServer` for `agent_definition`) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:27 -05:00
yindo closed this issue 2026-02-16 01:16:27 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#205