[PR #73] [MERGED] [bug] Handle case Port is None #247

Closed
opened 2026-02-16 01:16:37 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/73
Author: @nerdai
Created: 6/27/2024
Status: Merged
Merged: 6/27/2024
Merged by: @logan-markewich

Base: mainHead: nerdai/ignore-port-if-empty


📝 Commits (1)

📊 Changes

5 files changed (+26 additions, -8 deletions)

View changed files

📝 llama_agents/control_plane/server.py (+6 -2)
📝 llama_agents/message_queues/simple.py (+5 -3)
📝 llama_agents/services/agent.py (+5 -1)
📝 llama_agents/services/human.py (+5 -1)
📝 llama_agents/services/tool.py (+5 -1)

📄 Description

  • Currently we set all urls to use Ports
  • But there could be valid cases where one doesn't want to use Ports and so None is specified.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/73 **Author:** [@nerdai](https://github.com/nerdai) **Created:** 6/27/2024 **Status:** ✅ Merged **Merged:** 6/27/2024 **Merged by:** [@logan-markewich](https://github.com/logan-markewich) **Base:** `main` ← **Head:** `nerdai/ignore-port-if-empty` --- ### 📝 Commits (1) - [`0bf003c`](https://github.com/run-llama/llama_deploy/commit/0bf003c1d0ccc84496a9372f0419b9e9cef97492) handle optional ports ### 📊 Changes **5 files changed** (+26 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `llama_agents/control_plane/server.py` (+6 -2) 📝 `llama_agents/message_queues/simple.py` (+5 -3) 📝 `llama_agents/services/agent.py` (+5 -1) 📝 `llama_agents/services/human.py` (+5 -1) 📝 `llama_agents/services/tool.py` (+5 -1) </details> ### 📄 Description - Currently we set all urls to use Ports - But there could be valid cases where one doesn't want to use Ports and so None is specified. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:37 -05:00
yindo closed this issue 2026-02-16 01:16:37 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#247