run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-25 10:39:36 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #192] [MERGED] minor fix to agentic_rag_toolservice example #310

New Issue
Closed
opened 2026-02-16 01:16:50 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:16:50 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/192
Author: @alexfazio
Created: 8/17/2024
Status: ✅ Merged
Merged: 8/19/2024
Merged by: @logan-markewich

Base: main ← Head: main

📝 Commits (4)

  • 891c8c0 Add llama_index installation to notebook
  • e7cfda5 To briefly explain the addition of .idea to a .gitignore file in a commit message, you could write:
  • 178490a Remove .idea directory from version control
  • 9850152 Fix: Add missing newline at end of .gitignore to satisfy linter

📊 Changes

2 files changed (+3 additions, -0 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 examples/agentic_rag_toolservice.ipynb (+2 -0)

📄 Description

this pr makes a couple of small tweaks to the agentic_rag_toolservice.ipynb example to smooth out the setup process.

what’s changed:

  1. add llama_index install to notebook

    • added %pip install llama_index in a jupyter cell.
    • fixes modulenotfounderror when trying to use llama_index.

  2. update .gitignore for ide settings

    • added .idea/ to .gitignore.
    • keeps jetbrains ide settings out of version control, so everyone's configs stay local.

  3. clean up .idea directory

    • ran git rm -r --cached .idea/ to remove the .idea folder from the repo.
    • keeps the repo clean by getting rid of those ide files that snuck in.

these are just small changes to keep the repo tidy and make setup a bit easier. let me know if you need anything else!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/192 **Author:** [@alexfazio](https://github.com/alexfazio) **Created:** 8/17/2024 **Status:** ✅ Merged **Merged:** 8/19/2024 **Merged by:** [@logan-markewich](https://github.com/logan-markewich) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`891c8c0`](https://github.com/run-llama/llama_deploy/commit/891c8c0f832ce611e9aed9f71f12e11c1c6b3955) Add llama_index installation to notebook - [`e7cfda5`](https://github.com/run-llama/llama_deploy/commit/e7cfda5a6df681d5bd60704dc8ee068e457ad059) To briefly explain the addition of .idea to a .gitignore file in a commit message, you could write: - [`178490a`](https://github.com/run-llama/llama_deploy/commit/178490a8ff8c68e6b02d32b7641ddcfb3d652c94) Remove .idea directory from version control - [`9850152`](https://github.com/run-llama/llama_deploy/commit/9850152c9cd6d2e57d6fcc20429092f554561acc) Fix: Add missing newline at end of .gitignore to satisfy linter ### 📊 Changes **2 files changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `examples/agentic_rag_toolservice.ipynb` (+2 -0) </details> ### 📄 Description this pr makes a couple of small tweaks to the `agentic_rag_toolservice.ipynb` example to smooth out the setup process. **what’s changed:** 1. **add `llama_index` install to notebook** - added `%pip install llama_index` in a jupyter cell. - fixes `modulenotfounderror` when trying to use `llama_index`. 2. **update `.gitignore` for ide settings** - added `.idea/` to `.gitignore`. - keeps jetbrains ide settings out of version control, so everyone's configs stay local. 3. **clean up `.idea` directory** - ran `git rm -r --cached .idea/` to remove the `.idea` folder from the repo. - keeps the repo clean by getting rid of those ide files that snuck in. these are just small changes to keep the repo tidy and make setup a bit easier. let me know if you need anything else! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:50 -05:00
yindo closed this issue 2026-02-16 01:16:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#310
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?