[PR #217] [MERGED] Add external_host and external_port to server settings #325

Closed
opened 2026-02-16 01:16:53 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/217
Author: @nerdai
Created: 9/4/2024
Status: Merged
Merged: 9/4/2024
Merged by: @nerdai

Base: v0.1.0Head: nerdai/external-networking


📝 Commits (3)

📊 Changes

3 files changed (+26 additions, -6 deletions)

View changed files

📝 llama_deploy/control_plane/server.py (+13 -2)
📝 llama_deploy/services/workflow.py (+12 -3)
📝 pyproject.toml (+1 -1)

📄 Description

This PR adds two optional params that are useful when setting up a system that makes use of a separate internal and external networking (e.g., Docker-Compose and Kubernetes).

  • host and port are used as the default network setting as well as the internal network in more complex settings
  • external_host and external_port are used for outside connections to the service when standing it up (i.e., when invoked via launch_server())

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/217 **Author:** [@nerdai](https://github.com/nerdai) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/4/2024 **Merged by:** [@nerdai](https://github.com/nerdai) **Base:** `v0.1.0` ← **Head:** `nerdai/external-networking` --- ### 📝 Commits (3) - [`b1abad4`](https://github.com/run-llama/llama_deploy/commit/b1abad43438266cbf1607032c7f581c457252544) add external host and port - [`0cbe459`](https://github.com/run-llama/llama_deploy/commit/0cbe45949859731bba8c3032b6bc0983fd5a9c6c) add external settings - [`492c97d`](https://github.com/run-llama/llama_deploy/commit/492c97df689e33b3384bb169f89e769f75f691d1) bump prerelease version num ### 📊 Changes **3 files changed** (+26 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `llama_deploy/control_plane/server.py` (+13 -2) 📝 `llama_deploy/services/workflow.py` (+12 -3) 📝 `pyproject.toml` (+1 -1) </details> ### 📄 Description This PR adds two optional params that are useful when setting up a system that makes use of a separate internal and external networking (e.g., Docker-Compose and Kubernetes). - `host` and `port` are used as the default network setting as well as the internal network in more complex settings - `external_host` and `external_port` are used for outside connections to the service when standing it up (i.e., when invoked via `launch_server()`) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:53 -05:00
yindo closed this issue 2026-02-16 01:16:53 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#325