mirror of
https://github.com/run-llama/llama_deploy.git
synced 2026-08-25 10:39:36 -04:00
[PR #217] [MERGED] Add external_host and external_port to server settings
#325
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/run-llama/llama_deploy/pull/217
Author: @nerdai
Created: 9/4/2024
Status: ✅ Merged
Merged: 9/4/2024
Merged by: @nerdai
Base:
v0.1.0← Head:nerdai/external-networking📝 Commits (3)
b1abad4add external host and port0cbe459add external settings492c97dbump prerelease version num📊 Changes
3 files changed (+26 additions, -6 deletions)
View changed files
📝
llama_deploy/control_plane/server.py(+13 -2)📝
llama_deploy/services/workflow.py(+12 -3)📝
pyproject.toml(+1 -1)📄 Description
This PR adds two optional params that are useful when setting up a system that makes use of a separate internal and external networking (e.g., Docker-Compose and Kubernetes).
hostandportare used as the default network setting as well as the internal network in more complex settingsexternal_hostandexternal_portare used for outside connections to the service when standing it up (i.e., when invoked vialaunch_server())🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.