[PR #221] [MERGED] [fix] external port type #329

Closed
opened 2026-02-16 01:16:54 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/221
Author: @nerdai
Created: 9/4/2024
Status: Merged
Merged: 9/4/2024
Merged by: @nerdai

Base: v0.1.0Head: nerdai/fix-external-port-type


📝 Commits (2)

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 llama_deploy/message_queues/simple.py (+1 -1)
📝 pyproject.toml (+1 -1)

📄 Description

I mistakenly set the type of external_port to Optional[str] rather than Optional[int]. This PR fixes this mistake.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/221 **Author:** [@nerdai](https://github.com/nerdai) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/4/2024 **Merged by:** [@nerdai](https://github.com/nerdai) **Base:** `v0.1.0` ← **Head:** `nerdai/fix-external-port-type` --- ### 📝 Commits (2) - [`dde36e7`](https://github.com/run-llama/llama_deploy/commit/dde36e7465c30ffac4df0e040d38880aaeb447c7) fix external_port type - [`3cd1b03`](https://github.com/run-llama/llama_deploy/commit/3cd1b03852091ec475348a671f3cdeac739c8f40) bump prerelease version num ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `llama_deploy/message_queues/simple.py` (+1 -1) 📝 `pyproject.toml` (+1 -1) </details> ### 📄 Description I mistakenly set the type of `external_port` to `Optional[str]` rather than `Optional[int]`. This PR fixes this mistake. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:54 -05:00
yindo closed this issue 2026-02-16 01:16:54 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#329