[PR #326] [MERGED] fix: remove timeout from the underlying network service #398

New Issue

2026-02-16T01:17:11-05:00

yindo commented

2026-02-16 01:17:11 -05:00

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/326
Author: @masci
Created: 10/17/2024
Status: ✅ Merged
Merged: 10/17/2024
Merged by: @logan-markewich

Base: main ← Head: massi/320

📝 Commits (1)

82da594 remove timeout from the underlying network service

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 llama_deploy/deploy/network_workflow.py (+2 -2)

📄 Description

Fixes #320

When deploying nested workflows, another "system" workflow NetworkWorkflow is started under the hood to provide a map workflow<-->service. This workflow has no timeout set, defaulting to 10s. But if the overall deployment requires more than 10 seconds to run, NetworkWorkflow will exit before the deployment can finish, causing #320

We should probably review the strategy of NetworkWorkflow, specially when nested workflows are involved, but for the time being this fix should be good.

I didn't find a way to meaningfully unit test this, and a proper e2e test would take >10s so I propose we don't test it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/326 **Author:** [@masci](https://github.com/masci) **Created:** 10/17/2024 **Status:** ✅ Merged **Merged:** 10/17/2024 **Merged by:** [@logan-markewich](https://github.com/logan-markewich) **Base:** `main` ← **Head:** `massi/320` --- ### 📝 Commits (1) - [`82da594`](https://github.com/run-llama/llama_deploy/commit/82da594384a448e136ea9a01af2a740c22afa0d2) remove timeout from the underlying network service ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `llama_deploy/deploy/network_workflow.py` (+2 -2) </details> ### 📄 Description Fixes #320 When deploying nested workflows, another "system" workflow `NetworkWorkflow` is started under the hood to provide a map workflow<-->service. This workflow has no timeout set, defaulting to 10s. But if the overall deployment requires more than 10 seconds to run, `NetworkWorkflow` will exit before the deployment can finish, causing #320 We should probably review the strategy of `NetworkWorkflow`, specially when nested workflows are involved, but for the time being this fix should be good. I didn't find a way to meaningfully unit test this, and a proper e2e test would take >10s so I propose we don't test it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 01:17:11 -05:00

yindo closed this issue

2026-02-16 01:17:11 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#398