run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-25 10:39:36 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #343] [MERGED] refact: make collections in apiserver models lazy #407

New Issue
Closed
opened 2026-02-16 01:17:13 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:17:13 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/343
Author: @masci
Created: 10/29/2024
Status: ✅ Merged
Merged: 10/31/2024
Merged by: @masci

Base: main ← Head: massi/apiserver-fix

📝 Commits (2)

  • b3eb67c refact: make collections in apiserver models lazy
  • eee25f5 Merge branch 'main' into massi/apiserver-fix

📊 Changes

4 files changed (+73 additions, -58 deletions)

View changed files

📝 e2e_tests/apiserver/test_deploy.py (+2 -4)
📝 e2e_tests/apiserver/test_status.py (+1 -1)
📝 llama_deploy/client/models/apiserver.py (+67 -50)
📝 tests/client/models/test_apiserver.py (+3 -3)

📄 Description

Adjust client.apiserver.deployments and client.apiserver.sessions so that they don't actually load the items in a collection, deferring that to list. This way sessions and deployments can be regular properties, accessible without await.
This was originally implemented for the core client, this PR makes it consistent with the rest of the models.

Part of #337

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/343 **Author:** [@masci](https://github.com/masci) **Created:** 10/29/2024 **Status:** ✅ Merged **Merged:** 10/31/2024 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/apiserver-fix` --- ### 📝 Commits (2) - [`b3eb67c`](https://github.com/run-llama/llama_deploy/commit/b3eb67cd41ee177816e705cdd837d1a760dbb139) refact: make collections in apiserver models lazy - [`eee25f5`](https://github.com/run-llama/llama_deploy/commit/eee25f56ab8a603d876bdafae69abb37c2eae7ae) Merge branch 'main' into massi/apiserver-fix ### 📊 Changes **4 files changed** (+73 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `e2e_tests/apiserver/test_deploy.py` (+2 -4) 📝 `e2e_tests/apiserver/test_status.py` (+1 -1) 📝 `llama_deploy/client/models/apiserver.py` (+67 -50) 📝 `tests/client/models/test_apiserver.py` (+3 -3) </details> ### 📄 Description Adjust `client.apiserver.deployments` and `client.apiserver.sessions` so that they don't actually load the items in a collection, deferring that to `list`. This way `sessions` and `deployments` can be regular properties, accessible without `await`. This was originally implemented for the `core` client, this PR makes it consistent with the rest of the models. Part of #337 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:17:13 -05:00
yindo closed this issue 2026-02-16 01:17:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#407
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?