run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-25 10:39:36 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #388] [MERGED] test: fix runtime error in python<3.12 #432

New Issue
Closed
opened 2026-02-16 01:17:20 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:17:20 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/388
Author: @masci
Created: 11/27/2024
Status: ✅ Merged
Merged: 11/29/2024
Merged by: @logan-markewich

Base: main ← Head: massi/async-errors

📝 Commits (3)

📊 Changes

1 file changed (+12 additions, -5 deletions)

View changed files

📝 tests/services/test_workflow_service.py (+12 -5)

📄 Description

Clean up loop shutdown in tests, not 100% sure why the problem doesn't affect 3.12
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/388 **Author:** [@masci](https://github.com/masci) **Created:** 11/27/2024 **Status:** ✅ Merged **Merged:** 11/29/2024 **Merged by:** [@logan-markewich](https://github.com/logan-markewich) **Base:** `main` ← **Head:** `massi/async-errors` --- ### 📝 Commits (3) - [`3631255`](https://github.com/run-llama/llama_deploy/commit/3631255ecc74419f9fbe44af14037056bb896d62) test: fix runtime error in python<3.12 - [`0219e5c`](https://github.com/run-llama/llama_deploy/commit/0219e5c5c2089a32f7a45e6be381f67782475fe2) cleaner approach - [`d112c1b`](https://github.com/run-llama/llama_deploy/commit/d112c1b7652827b78b9a170f209d1b65bb8b417c) forgot ### 📊 Changes **1 file changed** (+12 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `tests/services/test_workflow_service.py` (+12 -5) </details> ### 📄 Description Clean up loop shutdown in tests, not 100% sure why the problem doesn't affect 3.12 <img width="267" alt="image" src="https://github.com/user-attachments/assets/21ef1054-f446-4e8b-bb1a-d3bb30ad521a"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:17:20 -05:00
yindo closed this issue 2026-02-16 01:17:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#432
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?