run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-24 21:01:26 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #434] [MERGED] fix: remove problematic root_path #462

New Issue
Closed
opened 2026-02-16 01:17:27 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:17:27 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/434
Author: @masci
Created: 1/21/2025
Status: ✅ Merged
Merged: 1/21/2025
Merged by: @masci

Base: main ← Head: massi/fastapi

📝 Commits (1)

  • 46595de fix: remove problematic root_path

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 llama_deploy/apiserver/app.py (+3 -3)

📄 Description

From #431, passing root_path="/" causes problems on some platforms. Since it's not a good practice to pass / anyways, let's remove it and see if it fixes the linked issue.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/434 **Author:** [@masci](https://github.com/masci) **Created:** 1/21/2025 **Status:** ✅ Merged **Merged:** 1/21/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/fastapi` --- ### 📝 Commits (1) - [`46595de`](https://github.com/run-llama/llama_deploy/commit/46595de2d4935e45ed4ce617b84888d22a539816) fix: remove problematic root_path ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `llama_deploy/apiserver/app.py` (+3 -3) </details> ### 📄 Description From #431, passing `root_path="/"` causes problems on some platforms. Since it's not a good practice to pass `/` anyways, let's remove it and see if it fixes the linked issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:17:27 -05:00
yindo closed this issue 2026-02-16 01:17:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#462
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?