run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-07-16 10:54:29 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #445] [MERGED] fix: launch only one SimpleMessageQueueServer per API Server instance #468

New Issue
Closed
opened 2026-02-16 01:17:29 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:17:29 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/445
Author: @masci
Created: 1/30/2025
Status: ✅ Merged
Merged: 1/31/2025
Merged by: @masci

Base: main ← Head: massi/apiserver-message-queue

📝 Commits (2)

  • f73743c fix: launch only one SimpleMessageQueueServer per API Server instance
  • 637a9f6 fix tests

📊 Changes

4 files changed (+28 additions, -22 deletions)

View changed files

📝 e2e_tests/apiserver/conftest.py (+3 -1)
📝 e2e_tests/apiserver/deployments/deployment_env_git.yml (+2 -4)
📝 llama_deploy/apiserver/deployment.py (+19 -13)
📝 tests/apiserver/test_deployment.py (+4 -4)

📄 Description

This fixes a subtle bug we had when creating multiple deployments on a single API Server instance, all using SimpleMessageQueue. Before we would start a server for each deployment, causing an error (address already in use). The API Server would still mostly work, but with an inconsistent state.

With this PR we move the logic from Deployment to the Manager, ensuring a single instance.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/445 **Author:** [@masci](https://github.com/masci) **Created:** 1/30/2025 **Status:** ✅ Merged **Merged:** 1/31/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/apiserver-message-queue` --- ### 📝 Commits (2) - [`f73743c`](https://github.com/run-llama/llama_deploy/commit/f73743cae7f000298ff1a4e7ac9d96826ff63639) fix: launch only one SimpleMessageQueueServer per API Server instance - [`637a9f6`](https://github.com/run-llama/llama_deploy/commit/637a9f6156ecfcc92864a148cef62dd53c7799a5) fix tests ### 📊 Changes **4 files changed** (+28 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `e2e_tests/apiserver/conftest.py` (+3 -1) 📝 `e2e_tests/apiserver/deployments/deployment_env_git.yml` (+2 -4) 📝 `llama_deploy/apiserver/deployment.py` (+19 -13) 📝 `tests/apiserver/test_deployment.py` (+4 -4) </details> ### 📄 Description This fixes a subtle bug we had when creating multiple deployments on a single API Server instance, all using `SimpleMessageQueue`. Before we would start a server for each deployment, causing an error (address already in use). The API Server would still mostly work, but with an inconsistent state. With this PR we move the logic from `Deployment` to the `Manager`, ensuring a single instance. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:17:29 -05:00
yindo closed this issue 2026-02-16 01:17:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#468
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?