run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-25 10:39:36 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #447] [MERGED] chore: add tests to avoid regressions on collect_events serialize #469

New Issue
Closed
opened 2026-02-16 01:17:29 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:17:29 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/447
Author: @masci
Created: 1/31/2025
Status: ✅ Merged
Merged: 2/1/2025
Merged by: @masci

Base: main ← Head: massi/test-collect-events

📝 Commits (2)

  • 9653ff7 chore: add tests to avoid regressions on collect_events serialize
  • 061da62 update lockfile

📊 Changes

3 files changed (+1413 additions, -1360 deletions)

View changed files

📝 e2e_tests/basic_workflow/workflow.py (+20 -5)
📝 llama_deploy/services/workflow.py (+7 -2)
📝 poetry.lock (+1386 -1353)

📄 Description

Follow-up for #442

The actual fix was on llama_deploy, this PR adds a test to detect regressions. Also added the stacktrace to the error logs, this would have saved some work during the investigation of #442

Note: tests are supposed to fail before LlamaIndex 0.12.15 is out. 0.12.15 is available, merge only when green

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/447 **Author:** [@masci](https://github.com/masci) **Created:** 1/31/2025 **Status:** ✅ Merged **Merged:** 2/1/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/test-collect-events` --- ### 📝 Commits (2) - [`9653ff7`](https://github.com/run-llama/llama_deploy/commit/9653ff71dafdb41939940da6982f6d8dfd397f09) chore: add tests to avoid regressions on collect_events serialize - [`061da62`](https://github.com/run-llama/llama_deploy/commit/061da62e917bd192826b285d66c19fa6621f5cd5) update lockfile ### 📊 Changes **3 files changed** (+1413 additions, -1360 deletions) <details> <summary>View changed files</summary> 📝 `e2e_tests/basic_workflow/workflow.py` (+20 -5) 📝 `llama_deploy/services/workflow.py` (+7 -2) 📝 `poetry.lock` (+1386 -1353) </details> ### 📄 Description Follow-up for #442 The actual fix was on `llama_deploy`, this PR adds a test to detect regressions. Also added the stacktrace to the error logs, this would have saved some work during the investigation of #442 ~Note: tests are supposed to fail before LlamaIndex 0.12.15 is out.~ 0.12.15 is available, merge only when green --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:17:29 -05:00
yindo closed this issue 2026-02-16 01:17:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#469
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?