run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-07-16 10:54:29 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #449] [MERGED] chore: refactor WorkflowService configuration #470

New Issue
Closed
opened 2026-02-16 01:17:29 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:17:29 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/449
Author: @masci
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/6/2025
Merged by: @masci

Base: main ← Head: massi/service-refact

📝 Commits (3)

  • cbd4358 chore: refactor WorkflowService configuration
  • 7789227 review comments
  • 74bfbcf update deploy logic

📊 Changes

5 files changed (+83 additions, -123 deletions)

View changed files

📝 llama_deploy/apiserver/deployment.py (+2 -4)
📝 llama_deploy/deploy/deploy.py (+1 -1)
📝 llama_deploy/services/base.py (+26 -22)
📝 llama_deploy/services/workflow.py (+35 -83)
📝 tests/services/test_workflow_service.py (+19 -13)

📄 Description

Enforce a single source of truth for the WorkflowService configuration through the WorkflowServiceConfig object. Base class doesn't need to be Pydantic model anymore.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/449 **Author:** [@masci](https://github.com/masci) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/6/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/service-refact` --- ### 📝 Commits (3) - [`cbd4358`](https://github.com/run-llama/llama_deploy/commit/cbd43589f4df19be209378cfcd5817c6311d7348) chore: refactor WorkflowService configuration - [`7789227`](https://github.com/run-llama/llama_deploy/commit/77892270927095417eafaffec071adffe31d8d27) review comments - [`74bfbcf`](https://github.com/run-llama/llama_deploy/commit/74bfbcf39330617ec872afafeaa7b369a08ea662) update deploy logic ### 📊 Changes **5 files changed** (+83 additions, -123 deletions) <details> <summary>View changed files</summary> 📝 `llama_deploy/apiserver/deployment.py` (+2 -4) 📝 `llama_deploy/deploy/deploy.py` (+1 -1) 📝 `llama_deploy/services/base.py` (+26 -22) 📝 `llama_deploy/services/workflow.py` (+35 -83) 📝 `tests/services/test_workflow_service.py` (+19 -13) </details> ### 📄 Description Enforce a single source of truth for the `WorkflowService` configuration through the `WorkflowServiceConfig` object. Base class doesn't need to be Pydantic model anymore. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:17:29 -05:00
yindo closed this issue 2026-02-16 01:17:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#470
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?