run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-24 21:01:26 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[PR #452] [MERGED] Pass client timeout to underlying client #473

New Issue
Closed
opened 2026-02-16 02:15:02 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 02:15:02 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/452
Author: @apost71
Created: 2/7/2025
Status: ✅ Merged
Merged: 2/9/2025
Merged by: @masci

Base: main ← Head: main

📝 Commits (3)

  • 379f270 fix: pass timeout to httpx client
  • af607e7 fix: add to sync client
  • 0617de3 fix: add to async client

📊 Changes

4 files changed (+6 additions, -4 deletions)

View changed files

📝 llama_deploy/client/async_client.py (+1 -1)
📝 llama_deploy/client/models/core.py (+1 -1)
📝 llama_deploy/client/sync_client.py (+1 -1)
📝 tests/client/models/test_core.py (+3 -1)

📄 Description

This is a PR to address https://github.com/run-llama/llama_deploy/issues/374

@masci I think you're right about the fine grained timeout configurations. Adding that capability introduces difficulties with serialization and ease of use via environment variables and may not be worth the effort.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/452 **Author:** [@apost71](https://github.com/apost71) **Created:** 2/7/2025 **Status:** ✅ Merged **Merged:** 2/9/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`379f270`](https://github.com/run-llama/llama_deploy/commit/379f270592cad41c21957b29e80deae0348d19e6) fix: pass timeout to httpx client - [`af607e7`](https://github.com/run-llama/llama_deploy/commit/af607e7a10b3024d10f028536acb097a07b005a8) fix: add to sync client - [`0617de3`](https://github.com/run-llama/llama_deploy/commit/0617de38fae1508af34e41f4fc97e3edf2577e61) fix: add to async client ### 📊 Changes **4 files changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `llama_deploy/client/async_client.py` (+1 -1) 📝 `llama_deploy/client/models/core.py` (+1 -1) 📝 `llama_deploy/client/sync_client.py` (+1 -1) 📝 `tests/client/models/test_core.py` (+3 -1) </details> ### 📄 Description This is a PR to address https://github.com/run-llama/llama_deploy/issues/374 @masci I think you're right about the fine grained timeout configurations. Adding that capability introduces difficulties with serialization and ease of use via environment variables and may not be worth the effort. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:15:02 -05:00
yindo closed this issue 2026-02-16 02:15:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#473
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?