[PR #458] [MERGED] chore: rename agent_id to service_id across the codebase #475

New Issue

2026-02-16T02:15:02-05:00

yindo commented

2026-02-16 02:15:02 -05:00

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/458
Author: @masci
Created: 2/13/2025
Status: ✅ Merged
Merged: 2/13/2025
Merged by: @masci

Base: main ← Head: massi/agent-id-rename

📝 Commits (1)

3413382 chore: rename agent_id to service_id across the codebase

📊 Changes

16 files changed (+56 additions, -57 deletions)

View changed files

📝 e2e_tests/apiserver/test_hitl.py (+4 -5)
📝 e2e_tests/basic_workflow/test_run_client.py (+3 -3)
📝 llama_deploy/apiserver/routers/deployments.py (+8 -8)
📝 llama_deploy/cli/run.py (+1 -1)
📝 llama_deploy/client/async_client.py (+3 -3)
📝 llama_deploy/client/models/apiserver.py (+1 -1)
📝 llama_deploy/client/models/core.py (+3 -3)
📝 llama_deploy/client/sync_client.py (+3 -3)
📝 llama_deploy/control_plane/server.py (+2 -2)
📝 llama_deploy/orchestrators/simple.py (+5 -5)
📝 llama_deploy/types/core.py (+4 -4)
📝 tests/apiserver/routers/test_deployments.py (+4 -4)
📝 tests/cli/test_run.py (+3 -3)
📝 tests/client/models/test_apiserver.py (+2 -2)
📝 tests/client/models/test_core.py (+9 -9)
📝 tests/orchestrators/test_simple_orchestrator.py (+1 -1)

📄 Description

Fixes #455

Originally, when the project was LlamaAgents, what we now call Service was referred to as Agent, hence the field agent_id. We didn't change the field so far assuming it was an internal implementation detail, but as #455 surfaced that's actually not true, as the misleading parameter leaks through the public interface.

This change is technically breaking for users relying on the raw HTTP API (e.g. not using the API Server nor the Client) but I think it's a band-aid we should rip off sooner rather than later.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/458 **Author:** [@masci](https://github.com/masci) **Created:** 2/13/2025 **Status:** ✅ Merged **Merged:** 2/13/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/agent-id-rename` --- ### 📝 Commits (1) - [`3413382`](https://github.com/run-llama/llama_deploy/commit/3413382af8a10d5a91221edbc5a2d1fe1c8418ae) chore: rename agent_id to service_id across the codebase ### 📊 Changes **16 files changed** (+56 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `e2e_tests/apiserver/test_hitl.py` (+4 -5) 📝 `e2e_tests/basic_workflow/test_run_client.py` (+3 -3) 📝 `llama_deploy/apiserver/routers/deployments.py` (+8 -8) 📝 `llama_deploy/cli/run.py` (+1 -1) 📝 `llama_deploy/client/async_client.py` (+3 -3) 📝 `llama_deploy/client/models/apiserver.py` (+1 -1) 📝 `llama_deploy/client/models/core.py` (+3 -3) 📝 `llama_deploy/client/sync_client.py` (+3 -3) 📝 `llama_deploy/control_plane/server.py` (+2 -2) 📝 `llama_deploy/orchestrators/simple.py` (+5 -5) 📝 `llama_deploy/types/core.py` (+4 -4) 📝 `tests/apiserver/routers/test_deployments.py` (+4 -4) 📝 `tests/cli/test_run.py` (+3 -3) 📝 `tests/client/models/test_apiserver.py` (+2 -2) 📝 `tests/client/models/test_core.py` (+9 -9) 📝 `tests/orchestrators/test_simple_orchestrator.py` (+1 -1) </details> ### 📄 Description Fixes #455 Originally, when the project was LlamaAgents, what we now call Service was referred to as Agent, hence the field `agent_id`. We didn't change the field so far assuming it was an internal implementation detail, but as #455 surfaced that's actually not true, as the misleading parameter leaks through the public interface. This change is technically breaking for users relying on the raw HTTP API (e.g. not using the API Server nor the Client) but I think it's a band-aid we should rip off sooner rather than later. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 02:15:02 -05:00

yindo closed this issue

2026-02-16 02:15:02 -05:00

yindo referenced this issue

2026-02-16 02:15:12 -05:00

[PR #476] [MERGED] refact: remove the remote/local concept, assume Control Plane is always remote #488

yindo referenced this issue

2026-02-16 02:15:12 -05:00

[PR #475] [MERGED] refact: remove the remote/local concept, assume services are always remote #489

Sign in to join this conversation.