[PR #506] [MERGED] chore: better naming for deployment config fields #508

New Issue

2026-02-16T02:15:24-05:00

yindo commented

2026-02-16 02:15:24 -05:00

📋 Pull Request Information

Original PR: https://github.com/run-llama/llama_deploy/pull/506
Author: @masci
Created: 5/22/2025
Status: ✅ Merged
Merged: 5/22/2025
Merged by: @masci

Base: main ← Head: massi/deployment-config

📝 Commits (1)

7df33e9 chore: better naming for deployment config fields

📊 Changes

4 files changed (+39 additions, -14 deletions)

View changed files

📝 llama_deploy/apiserver/deployment.py (+4 -4)
📝 llama_deploy/apiserver/deployment_config_parser.py (+29 -4)
📝 tests/apiserver/test_config_parser.py (+5 -5)
📝 tests/apiserver/test_deployment.py (+1 -1)

📄 Description

Discussed offline, in a deployment config like

name: LocalDeploymentRelativePath

services:
  test-workflow:
    name: Test Workflow
    source:
      type: local
      name: workflow
    path: workflow:my_workflow

the fields name and path are confusing, so this PR renames them to location and import_path respectively, resulting in the following

name: LocalDeploymentRelativePath

services:
  test-workflow:
    name: Test Workflow
    source:
      type: local
      location: workflow
    import_path: workflow:my_workflow

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/llama_deploy/pull/506 **Author:** [@masci](https://github.com/masci) **Created:** 5/22/2025 **Status:** ✅ Merged **Merged:** 5/22/2025 **Merged by:** [@masci](https://github.com/masci) **Base:** `main` ← **Head:** `massi/deployment-config` --- ### 📝 Commits (1) - [`7df33e9`](https://github.com/run-llama/llama_deploy/commit/7df33e9e82ac9c2d31c4d7b78df3f714658c9e29) chore: better naming for deployment config fields ### 📊 Changes **4 files changed** (+39 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `llama_deploy/apiserver/deployment.py` (+4 -4) 📝 `llama_deploy/apiserver/deployment_config_parser.py` (+29 -4) 📝 `tests/apiserver/test_config_parser.py` (+5 -5) 📝 `tests/apiserver/test_deployment.py` (+1 -1) </details> ### 📄 Description Discussed offline, in a deployment config like ```yaml name: LocalDeploymentRelativePath services: test-workflow: name: Test Workflow source: type: local name: workflow path: workflow:my_workflow ``` the fields `name` and `path` are confusing, so this PR renames them to `location` and `import_path` respectively, resulting in the following ```yaml name: LocalDeploymentRelativePath services: test-workflow: name: Test Workflow source: type: local location: workflow import_path: workflow:my_workflow ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 02:15:24 -05:00

yindo closed this issue

2026-02-16 02:15:24 -05:00

yindo referenced this issue

2026-02-16 02:15:24 -05:00

[PR #508] [MERGED] chore: remove deprecated clients #510

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#508