run-llama/llama_deploy
1
0
Fork 0
mirror of https://github.com/run-llama/llama_deploy.git synced 2026-08-25 10:39:36 -04:00
Code Issues 37 Packages Projects Releases 10 Wiki Activity

[cleanup] - remove opinionated interfaces #58

New Issue
Closed
opened 2026-02-16 01:15:28 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:15:28 -05:00
Owner
Copy Link
Copy Source

Originally created by @logan-markewich on GitHub (Aug 7, 2024).

There are a few classes that have some very opinionated fields. I think as we move towards integrating workflows and making llama-agents more general, we can rely on the caller of services to provide specific details in the input (either in the task input or task state), rather than relying on other hardcoded fields

I'll come back to this and update if I find more, but current list of interfaces to clean up

  • TaskResult.history -- this is way to specific to agents, it should either be in the task result or in the task state
  • ServiceDefinition.prompt -- this isn't really used at all anyways, and feels way too opinionated. This could be provided in the task definition as needed
  • Query-pipeline specific things should be deprecated and removed
  • (maybe) All other existing orchestrators should be either a) deprecated and removed or b) re-implmeneted with workflows
    • my hot take is that the existing agent orchestrator for example is too convoluted and opinionated to be useful?
    • maybe this could be re-implemented/updated to be more useful, not sure
  • remove tools as an argument to the orchestrator (it can be in the state if needed)
  • agent_id in the task definition should be service_name
Originally created by @logan-markewich on GitHub (Aug 7, 2024). There are a few classes that have some very opinionated fields. I think as we move towards integrating workflows and making llama-agents more general, we can rely on the caller of services to provide specific details in the input (either in the task input or task state), rather than relying on other hardcoded fields I'll come back to this and update if I find more, but current list of interfaces to clean up - `TaskResult.history` -- this is way to specific to agents, it should either be in the task result or in the task state - `ServiceDefinition.prompt` -- this isn't really used at all anyways, and feels way too opinionated. This could be provided in the task definition as needed - Query-pipeline specific things should be deprecated and removed - (maybe) All other existing orchestrators should be either a) deprecated and removed or b) re-implmeneted with workflows - my hot take is that the existing agent orchestrator for example is too convoluted and opinionated to be useful? - maybe this could be re-implemented/updated to be more useful, not sure - remove `tools` as an argument to the orchestrator (it can be in the state if needed) - `agent_id` in the task definition should be `service_name`
yindo added the enhancement label 2026-02-16 01:15:28 -05:00
yindo closed this issue 2026-02-16 01:15:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
bug
documentation
documentation
enhancement
example
good first issue
invalid
pull-request
Mirrored from GitHub Pull Request
 question
topic:CLI
topic:SDK
topic:SDK
topic:SDK
topic:apiserver
topic:control_plane
topic:message_queues
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/llama_deploy#58
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?