[PR #27] [MERGED] fix: Windows-specific issues related to across-threads IO operations #32

New Issue

2026-02-16T03:17:24-05:00

yindo commented

2026-02-16 03:17:24 -05:00

📋 Pull Request Information

Original PR: https://github.com/run-llama/notebookllama/pull/27
Author: @AstraBert
Created: 7/11/2025
Status: ✅ Merged
Merged: 7/11/2025
Merged by: @AstraBert

Base: main ← Head: clelia/windows-patch

📝 Commits (3)

242405d fix: patches for windows
46c31e5 ci: linting
22d0cd0 fix: uv sync

📊 Changes

6 files changed (+88 additions, -64 deletions)

View changed files

📝 pyproject.toml (+1 -1)
📝 src/notebookllama/Home.py (+57 -21)
📝 src/notebookllama/instrumentation.py (+2 -25)
📝 src/notebookllama/utils.py (+17 -8)
📝 tests/test_utils.py (+10 -8)
📝 uv.lock (+1 -1)

📄 Description

Introduces several patches for Windows:

Using localhost instead of 0.0.0.0because Windows likes it more
Introducing thread-safe async policies for windows
_to_pandas in OtelSqlEngine now converts rows directly without converting them to a temporary CSV file
Introducing MarkdownTextAnalyzer to avoid using an intermediate temporary file to use as an input to MarkdownAnalyzer

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/notebookllama/pull/27 **Author:** [@AstraBert](https://github.com/AstraBert) **Created:** 7/11/2025 **Status:** ✅ Merged **Merged:** 7/11/2025 **Merged by:** [@AstraBert](https://github.com/AstraBert) **Base:** `main` ← **Head:** `clelia/windows-patch` --- ### 📝 Commits (3) - [`242405d`](https://github.com/run-llama/notebookllama/commit/242405d287dd80d9ae329096fe550f7851e70644) fix: patches for windows - [`46c31e5`](https://github.com/run-llama/notebookllama/commit/46c31e572fab6cc2f42e6775cdb86aef700011ad) ci: linting - [`22d0cd0`](https://github.com/run-llama/notebookllama/commit/22d0cd0489b9f80f123cf86464b17166ad878fdf) fix: uv sync ### 📊 Changes **6 files changed** (+88 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `pyproject.toml` (+1 -1) 📝 `src/notebookllama/Home.py` (+57 -21) 📝 `src/notebookllama/instrumentation.py` (+2 -25) 📝 `src/notebookllama/utils.py` (+17 -8) 📝 `tests/test_utils.py` (+10 -8) 📝 `uv.lock` (+1 -1) </details> ### 📄 Description Introduces several patches for Windows: - Using `localhost` instead of `0.0.0.0`because Windows likes it more - Introducing thread-safe async policies for windows - `_to_pandas` in `OtelSqlEngine` now converts `rows` directly without converting them to a temporary CSV file - Introducing `MarkdownTextAnalyzer` to avoid using an intermediate temporary file to use as an input to `MarkdownAnalyzer` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 03:17:24 -05:00

yindo closed this issue

2026-02-16 03:17:24 -05:00

yindo referenced this issue

2026-02-16 03:17:25 -05:00

[PR #38] [MERGED] feat: Add support for LlamaCloud EU region #40

Sign in to join this conversation.