[PR #30] [MERGED] refactor: separate display text from internal values in CLI options #35

New Issue

2026-02-16T03:17:25-05:00

yindo commented

2026-02-16 03:17:25 -05:00

📋 Pull Request Information

Original PR: https://github.com/run-llama/notebookllama/pull/30
Author: @nick-galluzzo
Created: 7/12/2025
Status: ✅ Merged
Merged: 7/12/2025
Merged by: @AstraBert

Base: main ← Head: refactor/cli-option-values-separation

📝 Commits (2)

72804a5 refactor: separate display text from internal values in CLI options
c680f33 chore: version bump

📊 Changes

3 files changed (+4 additions, -32 deletions)

View changed files

📝 pyproject.toml (+1 -1)
📝 tools/cli/screens/initial.py (+3 -3)
➖ tools/cli/utils.py (+0 -28)

📄 Description

This PR refactors the CLI option handling to follow standard UI patterns by separating user-facing display text from internal programmatic values.

Changes Made

Updated Select options: Changed internal values from "With Default Settings" → "default_settings" and "With Custom Settings" → "custom_settings"
Preserved user experience: Display text remains user-friendly ("With Default Settings", "With Custom Settings")
Updated conditional logic: Modified app.config.setup_type comparison to use new internal values
Removed code duplication: Deleted unused DefaultOrCustomApp class from tools/cli/utils.py

This is a non-breaking refactoring that improves code quality without affecting user experience.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/notebookllama/pull/30 **Author:** [@nick-galluzzo](https://github.com/nick-galluzzo) **Created:** 7/12/2025 **Status:** ✅ Merged **Merged:** 7/12/2025 **Merged by:** [@AstraBert](https://github.com/AstraBert) **Base:** `main` ← **Head:** `refactor/cli-option-values-separation` --- ### 📝 Commits (2) - [`72804a5`](https://github.com/run-llama/notebookllama/commit/72804a556bc41823012917f8342131d15c5d5d27) refactor: separate display text from internal values in CLI options - [`c680f33`](https://github.com/run-llama/notebookllama/commit/c680f337055910197e520f0100ef63f248a83fed) chore: version bump ### 📊 Changes **3 files changed** (+4 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `pyproject.toml` (+1 -1) 📝 `tools/cli/screens/initial.py` (+3 -3) ➖ `tools/cli/utils.py` (+0 -28) </details> ### 📄 Description This PR refactors the CLI option handling to follow standard UI patterns by separating user-facing display text from internal programmatic values. **Changes Made** - **Updated Select options**: Changed internal values from `"With Default Settings"` → `"default_settings"` and `"With Custom Settings"` → `"custom_settings"` - **Preserved user experience**: Display text remains user-friendly (`"With Default Settings"`, `"With Custom Settings"`) - **Updated conditional logic**: Modified `app.config.setup_type` comparison to use new internal values - **Removed code duplication**: Deleted unused `DefaultOrCustomApp` class from `tools/cli/utils.py` This is a non-breaking refactoring that improves code quality without affecting user experience. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 03:17:25 -05:00

yindo closed this issue

2026-02-16 03:17:25 -05:00

yindo referenced this issue

2026-02-16 03:17:25 -05:00

[PR #35] [MERGED] feat: Podcast customization with UI configuration panel #38

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: run-llama/notebookllama#35