run-llama/semtools
1
0
Fork 0
mirror of https://github.com/run-llama/semtools.git synced 2026-07-22 03:35:25 -04:00
Code Issues 4 Packages Projects Releases 10 Wiki Activity

[PR #13] [MERGED] add --ignore-case param for search, improve CLI help #29

New Issue
Closed
opened 2026-02-16 04:15:17 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 04:15:17 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/semtools/pull/13
Author: @logan-markewich
Created: 8/30/2025
Status: ✅ Merged
Merged: 8/30/2025
Merged by: @logan-markewich

Base: main ← Head: logan/search_improvements

📝 Commits (4)

📊 Changes

3 files changed (+253 additions, -139 deletions)

View changed files

📝 README.md (+4 -3)
📝 examples/example_CLAUDE.md (+4 -3)
📝 src/bin/search.rs (+245 -133)

📄 Description

The default model, minishlab/potion-multilingual-128M, is case sensitive

To make search a bit more robust, added a --ignore-case param (similar to grep), which converts all input text to lowercase

I also noticed the unit tests were not actually testing anything, did a small refactor to make things testable!

Bonus round -- realized that seach --help was ignoring the arg descriptions. Turns out I used // instead of ///

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/semtools/pull/13 **Author:** [@logan-markewich](https://github.com/logan-markewich) **Created:** 8/30/2025 **Status:** ✅ Merged **Merged:** 8/30/2025 **Merged by:** [@logan-markewich](https://github.com/logan-markewich) **Base:** `main` ← **Head:** `logan/search_improvements` --- ### 📝 Commits (4) - [`5004fe0`](https://github.com/run-llama/semtools/commit/5004fe077a2a3afa8d9a9f5de117f75f5ddb1d72) add --ignore-case param, refactor tests - [`1bd3f0e`](https://github.com/run-llama/semtools/commit/1bd3f0eee814c1b49c042dd6b5c570eea3ba94d9) nit + tests - [`dadfc4e`](https://github.com/run-llama/semtools/commit/dadfc4e07312c1977e5816e9316c0b0c138a3f4b) test was non-deterministic for reasons - [`9efa6af`](https://github.com/run-llama/semtools/commit/9efa6af17059b7704fc400f044161e7e0a52fd0d) linting ### 📊 Changes **3 files changed** (+253 additions, -139 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+4 -3) 📝 `examples/example_CLAUDE.md` (+4 -3) 📝 `src/bin/search.rs` (+245 -133) </details> ### 📄 Description The default model, [minishlab/potion-multilingual-128M](https://huggingface.co/minishlab/potion-multilingual-128M), is case sensitive To make search a bit more robust, added a `--ignore-case` param (similar to grep), which converts all input text to lowercase I also noticed the unit tests were not actually testing anything, did a small refactor to make things testable! Bonus round -- realized that `seach --help` was ignoring the arg descriptions. Turns out I used `//` instead of `///` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 04:15:17 -05:00
yindo closed this issue 2026-02-16 04:15:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/semtools#29
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?