mirror of
https://github.com/run-llama/semtools.git
synced 2026-07-21 11:15:24 -04:00
[PR #25] [MERGED] remove beta document-level approach, persist purely line embeddings as a new beta approach #35
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/run-llama/semtools/pull/25
Author: @logan-markewich
Created: 9/14/2025
Status: ✅ Merged
Merged: 9/14/2025
Merged by: @logan-markewich
Base:
main← Head:logan/workspace_v2📝 Commits (4)
6479bferemove document-level approach, persist purely line embeddings4e3a533lintingfce4973linting915adaffix📊 Changes
5 files changed (+360 additions, -304 deletions)
View changed files
📝
Cargo.lock(+1 -1)📝
Cargo.toml(+1 -1)📝
package.json(+1 -1)📝
src/bin/search.rs(+81 -95)📝
src/workspace/store.rs(+276 -206)📄 Description
So, document-level filtering might be too big-brained.
Trying a beta.2 approach where instead we purely persist line embeddings
I also considered swapping lancedb with sqlite, but with line-level embeddings we will quickly blow past the scaling limits of sqlite
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.