run-llama/workflows-py
1
0
Fork 0
mirror of https://github.com/run-llama/workflows-py.git synced 2026-07-20 19:57:02 -04:00
Code Issues 18 Packages Projects Releases 10 Wiki Activity

[PR #101] [MERGED] Add better error handling and lifecycle handling to workflow server #119

New Issue
Closed
opened 2026-02-16 02:16:39 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 02:16:39 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/workflows-py/pull/101
Author: @adrianlyjak
Created: 9/16/2025
Status: ✅ Merged
Merged: 9/17/2025
Merged by: @adrianlyjak

Base: main ← Head: adrian/persistence-improvements

📝 Commits (2)

  • 4732a83 Add better error handling and lifecycle handling to workflow server
  • 157c267 Server being a context manager was a bit weird

📊 Changes

5 files changed (+762 additions, -658 deletions)

View changed files

📝 src/workflows/handler.py (+2 -0)
📝 src/workflows/server/server.py (+97 -61)
📝 src/workflows/workflow.py (+7 -8)
📝 tests/server/test_server_endpoints.py (+508 -553)
📝 tests/server/test_server_persistence.py (+148 -36)

📄 Description

  • Adds retries to workflow server persistence, and if it fully fails, cancel/fail the workflow
  • Adds workflow error exception logging
  • Shims in a task reference such that the persistence tests can wait for things to quiet down before quitting
  • Makes WorkflowServer into a context manager. This is related to alleviating some technical debt in LlamaDeploy before that can be paid down, but it also makes it simpler and more obvious how to tear down in tests. Context manager isn't stricly required, but I can also manage this by making a start/stop interface public

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/workflows-py/pull/101 **Author:** [@adrianlyjak](https://github.com/adrianlyjak) **Created:** 9/16/2025 **Status:** ✅ Merged **Merged:** 9/17/2025 **Merged by:** [@adrianlyjak](https://github.com/adrianlyjak) **Base:** `main` ← **Head:** `adrian/persistence-improvements` --- ### 📝 Commits (2) - [`4732a83`](https://github.com/run-llama/workflows-py/commit/4732a830bb5f7dec4967c0a42a782b1d0c7c4432) Add better error handling and lifecycle handling to workflow server - [`157c267`](https://github.com/run-llama/workflows-py/commit/157c267d4d7d17ce5823e11a3fc24c5b53955275) Server being a context manager was a bit weird ### 📊 Changes **5 files changed** (+762 additions, -658 deletions) <details> <summary>View changed files</summary> 📝 `src/workflows/handler.py` (+2 -0) 📝 `src/workflows/server/server.py` (+97 -61) 📝 `src/workflows/workflow.py` (+7 -8) 📝 `tests/server/test_server_endpoints.py` (+508 -553) 📝 `tests/server/test_server_persistence.py` (+148 -36) </details> ### 📄 Description - Adds retries to workflow server persistence, and if it fully fails, cancel/fail the workflow - Adds workflow error exception logging - Shims in a task reference such that the persistence tests can wait for things to quiet down before quitting - Makes WorkflowServer into a context manager. This is related to alleviating some technical debt in LlamaDeploy before that can be paid down, but it also makes it simpler and more obvious how to tear down in tests. Context manager isn't stricly required, but I can also manage this by making a start/stop interface public --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:16:39 -05:00
yindo closed this issue 2026-02-16 02:16:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/workflows-py#119
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?