run-llama/workflows-py
1
0
Fork 0
mirror of https://github.com/run-llama/workflows-py.git synced 2026-07-21 04:05:25 -04:00
Code Issues 18 Packages Projects Releases 10 Wiki Activity

[PR #123] [MERGED] Don't skip validation if start event is empty or missing #141

New Issue
Closed
opened 2026-02-16 02:16:43 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 02:16:43 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/workflows-py/pull/123
Author: @adrianlyjak
Created: 10/6/2025
Status: ✅ Merged
Merged: 10/6/2025
Merged by: @adrianlyjak

Base: main ← Head: adrian/validate-events

📝 Commits (2)

  • 01cb130 Don't skip validationg if start event is empty or missing
  • 4f7dd2a Fix format

📊 Changes

3 files changed (+59 additions, -8 deletions)

View changed files

📝 src/workflows/server/server.py (+9 -8)
📝 tests/server/conftest.py (+15 -0)
📝 tests/server/test_server_endpoints.py (+35 -0)

📄 Description

There was a bug where start event validation was being skipped if the start event dict was empty, since {} is falsy in python

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/workflows-py/pull/123 **Author:** [@adrianlyjak](https://github.com/adrianlyjak) **Created:** 10/6/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@adrianlyjak](https://github.com/adrianlyjak) **Base:** `main` ← **Head:** `adrian/validate-events` --- ### 📝 Commits (2) - [`01cb130`](https://github.com/run-llama/workflows-py/commit/01cb13047cd55b38cbd35947e502185b3f8a1711) Don't skip validationg if start event is empty or missing - [`4f7dd2a`](https://github.com/run-llama/workflows-py/commit/4f7dd2aa123f92c538ebeab148d170367b56e9dd) Fix format ### 📊 Changes **3 files changed** (+59 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/workflows/server/server.py` (+9 -8) 📝 `tests/server/conftest.py` (+15 -0) 📝 `tests/server/test_server_endpoints.py` (+35 -0) </details> ### 📄 Description There was a bug where start event validation was being skipped if the start event dict was empty, since `{}` is falsy in python --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:16:43 -05:00
yindo closed this issue 2026-02-16 02:16:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/workflows-py#141
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?