[PR #125] [CLOSED] attach metadata to handlers and allow filtering #143

Closed
opened 2026-02-16 02:16:43 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/run-llama/workflows-py/pull/125
Author: @logan-markewich
Created: 10/6/2025
Status: Closed

Base: mainHead: logan/handler_metadata


📝 Commits (3)

  • 38500c6 attach metadata to handlers and allow filtering
  • ed3a72f fix and add tests
  • 97cf3e5 reuse handler metadata on server

📊 Changes

7 files changed (+221 additions, -35 deletions)

View changed files

📝 src/workflows/server/abstract_workflow_store.py (+2 -1)
📝 src/workflows/server/server.py (+171 -14)
📝 src/workflows/server/sqlite_workflow_store.py (+40 -18)
📝 tests/server/test_handler_serialization.py (+1 -0)
📝 tests/server/test_server.py (+0 -1)
📝 tests/server/test_server_endpoints.py (+5 -1)
📝 tests/server/test_sqlite_workflow_store.py (+2 -0)

📄 Description

Initial stab at attaching arbitrary metadata to handlers

  • metadata is assigned when calling run()
  • if continuing a run/session, it will re-use existing metadata (or overwrite)
  • the list handlers endpoint now accepts basic filtering params

Concerns

  • this technically expands the db for persisted workflows. Do we need to worry about migrations? (sqlite is fine as is imo)
  • is there a better way to expose the filters?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/workflows-py/pull/125 **Author:** [@logan-markewich](https://github.com/logan-markewich) **Created:** 10/6/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `logan/handler_metadata` --- ### 📝 Commits (3) - [`38500c6`](https://github.com/run-llama/workflows-py/commit/38500c67cd2e007120cf95b34dadea8545483a41) attach metadata to handlers and allow filtering - [`ed3a72f`](https://github.com/run-llama/workflows-py/commit/ed3a72f4b91490dbb306fb9989dc0eec7e7120e1) fix and add tests - [`97cf3e5`](https://github.com/run-llama/workflows-py/commit/97cf3e5c63f0ce298324b252dff0d2ba27a87315) reuse handler metadata on server ### 📊 Changes **7 files changed** (+221 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `src/workflows/server/abstract_workflow_store.py` (+2 -1) 📝 `src/workflows/server/server.py` (+171 -14) 📝 `src/workflows/server/sqlite_workflow_store.py` (+40 -18) 📝 `tests/server/test_handler_serialization.py` (+1 -0) 📝 `tests/server/test_server.py` (+0 -1) 📝 `tests/server/test_server_endpoints.py` (+5 -1) 📝 `tests/server/test_sqlite_workflow_store.py` (+2 -0) </details> ### 📄 Description Initial stab at attaching arbitrary metadata to handlers - metadata is assigned when calling run() - if continuing a run/session, it will re-use existing metadata (or overwrite) - the list handlers endpoint now accepts basic filtering params Concerns - this technically expands the db for persisted workflows. Do we need to worry about migrations? (sqlite is fine as is imo) - is there a better way to expose the filters? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:16:43 -05:00
yindo closed this issue 2026-02-16 02:16:43 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/workflows-py#143