run-llama/workflows-py
1
0
Fork 0
mirror of https://github.com/run-llama/workflows-py.git synced 2026-07-21 04:05:25 -04:00
Code Issues 18 Packages Projects Releases 10 Wiki Activity

[PR #150] [MERGED] Fix workflow client send event #166

New Issue
Closed
opened 2026-02-16 02:16:47 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 02:16:47 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/workflows-py/pull/150
Author: @adrianlyjak
Created: 10/17/2025
Status: ✅ Merged
Merged: 10/17/2025
Merged by: @adrianlyjak

Base: main ← Head: adrian/fix-send-event

📝 Commits (3)

  • 08f1bfa Ensure client sends old string format, and that the server accepts dict or string format for _post_event
  • 925afba nicer error
  • 004d300 add error test

📊 Changes

6 files changed (+120 additions, -14 deletions)

View changed files

📝 pyproject.toml (+1 -1)
📝 src/workflows/client/client.py (+38 -9)
📝 src/workflows/server/server.py (+5 -1)
📝 tests/client/test_client.py (+43 -0)
📝 tests/server/test_server_endpoints.py (+31 -1)
📝 uv.lock (+2 -2)

📄 Description

sadly, I made a last minute cleanup change to the workflow client before merging it in, and didn't realize I broke send event functionality.

The client started sending dicts, and the server only accepts stringified events, and there was no unit test coverage.

  • Updated the client to send events as serialized strings
  • Updated the server to support dicts
  • Added test coverage to both
  • Add response body to error messages on the client to make debugging easier on client integrations

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/workflows-py/pull/150 **Author:** [@adrianlyjak](https://github.com/adrianlyjak) **Created:** 10/17/2025 **Status:** ✅ Merged **Merged:** 10/17/2025 **Merged by:** [@adrianlyjak](https://github.com/adrianlyjak) **Base:** `main` ← **Head:** `adrian/fix-send-event` --- ### 📝 Commits (3) - [`08f1bfa`](https://github.com/run-llama/workflows-py/commit/08f1bfa9a03b62f284dc32424a41a9552757b92a) Ensure client sends old string format, and that the server accepts dict or string format for _post_event - [`925afba`](https://github.com/run-llama/workflows-py/commit/925afba248e33fc5259279af4c3c26ed82219678) nicer error - [`004d300`](https://github.com/run-llama/workflows-py/commit/004d300b668c99141a5aca541c9ec80ca391f03e) add error test ### 📊 Changes **6 files changed** (+120 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `pyproject.toml` (+1 -1) 📝 `src/workflows/client/client.py` (+38 -9) 📝 `src/workflows/server/server.py` (+5 -1) 📝 `tests/client/test_client.py` (+43 -0) 📝 `tests/server/test_server_endpoints.py` (+31 -1) 📝 `uv.lock` (+2 -2) </details> ### 📄 Description sadly, I made a last minute cleanup change to the workflow client before merging it in, and didn't realize I broke send event functionality. The client started sending dicts, and the server only accepts stringified events, and there was no unit test coverage. - Updated the client to send events as serialized strings - Updated the server to support dicts - Added test coverage to both - Add response body to error messages on the client to make debugging easier on client integrations --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:16:47 -05:00
yindo closed this issue 2026-02-16 02:16:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/workflows-py#166
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?