run-llama/workflows-py
1
0
Fork 0
mirror of https://github.com/run-llama/workflows-py.git synced 2026-07-21 04:05:25 -04:00
Code Issues 18 Packages Projects Releases 10 Wiki Activity

[PR #153] [MERGED] handlers list improvement #169

New Issue
Closed
opened 2026-02-16 02:16:48 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 02:16:48 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/workflows-py/pull/153
Author: @zhaotai
Created: 10/21/2025
Status: ✅ Merged
Merged: 10/22/2025
Merged by: @zhaotai

Base: main ← Head: terry/handlers

📝 Commits (7)

📊 Changes

17 files changed (+856 additions, -214 deletions)

View changed files

📝 src/workflows/server/__init__.py (+1 -1)
📝 src/workflows/server/abstract_workflow_store.py (+8 -12)
📝 src/workflows/server/memory_workflow_store.py (+19 -12)
📝 src/workflows/server/server.py (+178 -135)
➕ src/workflows/server/sqlite/__init__.py (+0 -0)
➕ src/workflows/server/sqlite/migrate.py (+59 -0)
➕ src/workflows/server/sqlite/migrations/0001_init.sql (+9 -0)
➕ src/workflows/server/sqlite/migrations/0002_extend_handlers.sql (+9 -0)
➕ src/workflows/server/sqlite/migrations/__init__.py (+0 -0)
📝 src/workflows/server/sqlite/sqlite_workflow_store.py (+32 -9)
📝 tests/client/test_client.py (+31 -1)
📝 tests/server/test_handler_serialization.py (+3 -0)
➕ tests/server/test_memory_workflow_store.py (+386 -0)
➕ tests/server/test_migrations.py (+93 -0)
📝 tests/server/test_server_endpoints.py (+3 -2)
📝 tests/server/test_server_persistence.py (+24 -41)
📝 tests/server/test_sqlite_workflow_store.py (+1 -1)

📄 Description

  • Always return handlers from db so that we can still get full list even after server restarts.
  • Move _stream_events to _WorkflowHandler to centralize persistence.
  • Add metadata to persistence data model.

Remaining issues:

  • After complete, handler should be removed from memory
  • Events seem not stored in db. Need to persist events as well.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/workflows-py/pull/153 **Author:** [@zhaotai](https://github.com/zhaotai) **Created:** 10/21/2025 **Status:** ✅ Merged **Merged:** 10/22/2025 **Merged by:** [@zhaotai](https://github.com/zhaotai) **Base:** `main` ← **Head:** `terry/handlers` --- ### 📝 Commits (7) - [`e293f13`](https://github.com/run-llama/workflows-py/commit/e293f13dd05a2043cdeeb472f3dc910dce6c058a) fix handlers list - [`2573a6a`](https://github.com/run-llama/workflows-py/commit/2573a6a4935a8856f889874e5221362ccec06f93) fix lint - [`d6e6b87`](https://github.com/run-llama/workflows-py/commit/d6e6b87d526e7ae521d7986dc3d3bd7261c1ccfd) Add sqlite migrations (#155) - [`77ab081`](https://github.com/run-llama/workflows-py/commit/77ab081e5067291672a1e60f3464ac1642ddfbfa) move memory store to sever/ - [`600aa69`](https://github.com/run-llama/workflows-py/commit/600aa692a65aaa5d8ffef3368dbd28ef022310e8) addd store - [`e46b682`](https://github.com/run-llama/workflows-py/commit/e46b682878fdce9aa2c6c21319df37aa3c63c37e) resolve comment - [`afae075`](https://github.com/run-llama/workflows-py/commit/afae07501ec0444b991595d7367e80f3fd1ef9f8) fix lint ### 📊 Changes **17 files changed** (+856 additions, -214 deletions) <details> <summary>View changed files</summary> 📝 `src/workflows/server/__init__.py` (+1 -1) 📝 `src/workflows/server/abstract_workflow_store.py` (+8 -12) 📝 `src/workflows/server/memory_workflow_store.py` (+19 -12) 📝 `src/workflows/server/server.py` (+178 -135) ➕ `src/workflows/server/sqlite/__init__.py` (+0 -0) ➕ `src/workflows/server/sqlite/migrate.py` (+59 -0) ➕ `src/workflows/server/sqlite/migrations/0001_init.sql` (+9 -0) ➕ `src/workflows/server/sqlite/migrations/0002_extend_handlers.sql` (+9 -0) ➕ `src/workflows/server/sqlite/migrations/__init__.py` (+0 -0) 📝 `src/workflows/server/sqlite/sqlite_workflow_store.py` (+32 -9) 📝 `tests/client/test_client.py` (+31 -1) 📝 `tests/server/test_handler_serialization.py` (+3 -0) ➕ `tests/server/test_memory_workflow_store.py` (+386 -0) ➕ `tests/server/test_migrations.py` (+93 -0) 📝 `tests/server/test_server_endpoints.py` (+3 -2) 📝 `tests/server/test_server_persistence.py` (+24 -41) 📝 `tests/server/test_sqlite_workflow_store.py` (+1 -1) </details> ### 📄 Description * Always return handlers from db so that we can still get full list even after server restarts. * Move `_stream_events` to `_WorkflowHandler` to centralize persistence. * Add metadata to persistence data model. ### Remaining issues: * After complete, handler should be removed from memory * Events seem not stored in db. Need to persist events as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:16:48 -05:00
yindo closed this issue 2026-02-16 02:16:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/workflows-py#169
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?