run-llama/workflows-py
1
0
Fork 0
mirror of https://github.com/run-llama/workflows-py.git synced 2026-08-24 20:01:34 -04:00
Code Issues 18 Packages Projects Releases 10 Wiki Activity

[PR #186] [MERGED] validate that workflow is not cleared until events are consumed #199

New Issue
Closed
opened 2026-02-16 02:16:54 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 02:16:54 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/workflows-py/pull/186
Author: @adrianlyjak
Created: 11/1/2025
Status: ✅ Merged
Merged: 11/1/2025
Merged by: @adrianlyjak

Base: main ← Head: adrian/events-after-completion

📝 Commits (3)

  • 2b72842 validate that workflow is not cleared until events are consumed
  • 32b5571 version bump
  • c974a9c move completion check to function located with status union

📊 Changes

5 files changed (+53 additions, -5 deletions)

View changed files

📝 pyproject.toml (+1 -1)
📝 src/workflows/protocol/__init__.py (+4 -0)
📝 src/workflows/server/server.py (+8 -2)
📝 tests/server/test_server_endpoints.py (+39 -1)
📝 uv.lock (+1 -1)

📄 Description

Events were not retrievable for workflows that complete very fast, the events endpoint was returning a 204, despite there being unconsumed events

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/workflows-py/pull/186 **Author:** [@adrianlyjak](https://github.com/adrianlyjak) **Created:** 11/1/2025 **Status:** ✅ Merged **Merged:** 11/1/2025 **Merged by:** [@adrianlyjak](https://github.com/adrianlyjak) **Base:** `main` ← **Head:** `adrian/events-after-completion` --- ### 📝 Commits (3) - [`2b72842`](https://github.com/run-llama/workflows-py/commit/2b72842c749764d0d11eba88856619f2f13307b1) validate that workflow is not cleared until events are consumed - [`32b5571`](https://github.com/run-llama/workflows-py/commit/32b5571462c327730e52d059fe52263e986df825) version bump - [`c974a9c`](https://github.com/run-llama/workflows-py/commit/c974a9c366d77d2b6f8ac01e22feb18b78cb6acd) move completion check to function located with status union ### 📊 Changes **5 files changed** (+53 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `pyproject.toml` (+1 -1) 📝 `src/workflows/protocol/__init__.py` (+4 -0) 📝 `src/workflows/server/server.py` (+8 -2) 📝 `tests/server/test_server_endpoints.py` (+39 -1) 📝 `uv.lock` (+1 -1) </details> ### 📄 Description Events were not retrievable for workflows that complete very fast, the events endpoint was returning a 204, despite there being unconsumed events --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:16:54 -05:00
yindo closed this issue 2026-02-16 02:16:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/workflows-py#199
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?