run-llama/workflows-py
1
0
Fork 0
mirror of https://github.com/run-llama/workflows-py.git synced 2026-07-20 19:57:02 -04:00
Code Issues 18 Packages Projects Releases 10 Wiki Activity

[PR #381] [MERGED] fix span handling and span hierarchy propagation #382

New Issue
Closed
opened 2026-02-16 02:17:24 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 02:17:24 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/workflows-py/pull/381
Author: @logan-markewich
Created: 2/13/2026
Status: ✅ Merged
Merged: 2/13/2026
Merged by: @logan-markewich

Base: main ← Head: logan/fix-spans

📝 Commits (2)

  • df626ae fix span handling and span hierarchy propagation
  • b818f2f changeset

📊 Changes

5 files changed (+140 additions, -40 deletions)

View changed files

➕ .changeset/afraid-terms-kick.md (+5 -0)
📝 packages/llama-index-workflows/src/workflows/plugins/basic.py (+9 -1)
📝 packages/llama-index-workflows/src/workflows/runtime/types/plugin.py (+1 -1)
📝 packages/llama-index-workflows/src/workflows/runtime/types/step_function.py (+39 -23)
📝 packages/llama-index-workflows/src/workflows/workflow.py (+86 -15)

📄 Description

The switch from workflow handler being an asyncio future to an awaitable caused a few bugs

  • async context being lost
  • the llama-index-instrumentation code not being setup to handle Awaitable types

Fixes: https://github.com/run-llama/workflows-py/issues/380

We could move awaitable handling into the instrumentation package, but I'd rather ensure its fixed here first

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/workflows-py/pull/381 **Author:** [@logan-markewich](https://github.com/logan-markewich) **Created:** 2/13/2026 **Status:** ✅ Merged **Merged:** 2/13/2026 **Merged by:** [@logan-markewich](https://github.com/logan-markewich) **Base:** `main` ← **Head:** `logan/fix-spans` --- ### 📝 Commits (2) - [`df626ae`](https://github.com/run-llama/workflows-py/commit/df626aea83cbb5fbbb5e024a9ca172ffb144743c) fix span handling and span hierarchy propagation - [`b818f2f`](https://github.com/run-llama/workflows-py/commit/b818f2f4e6369cb7528841b8f6f5434779c93d70) changeset ### 📊 Changes **5 files changed** (+140 additions, -40 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/afraid-terms-kick.md` (+5 -0) 📝 `packages/llama-index-workflows/src/workflows/plugins/basic.py` (+9 -1) 📝 `packages/llama-index-workflows/src/workflows/runtime/types/plugin.py` (+1 -1) 📝 `packages/llama-index-workflows/src/workflows/runtime/types/step_function.py` (+39 -23) 📝 `packages/llama-index-workflows/src/workflows/workflow.py` (+86 -15) </details> ### 📄 Description The switch from workflow handler being an asyncio future to an awaitable caused a few bugs - async context being lost - the llama-index-instrumentation code not being setup to handle `Awaitable` types Fixes: https://github.com/run-llama/workflows-py/issues/380 We could move awaitable handling into the instrumentation package, but I'd rather ensure its fixed here first --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:17:24 -05:00
yindo closed this issue 2026-02-16 02:17:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/workflows-py#382
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?