run-llama/workflows-py
1
0
Fork 0
mirror of https://github.com/run-llama/workflows-py.git synced 2026-07-21 04:05:25 -04:00
Code Issues 18 Packages Projects Releases 10 Wiki Activity

[PR #30] [MERGED] properly move and support clear method #61

New Issue
Closed
opened 2026-02-16 02:16:26 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 02:16:26 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/run-llama/workflows-py/pull/30
Author: @logan-markewich
Created: 7/23/2025
Status: ✅ Merged
Merged: 7/23/2025
Merged by: @logan-markewich

Base: main ← Head: logan/clear_method

📝 Commits (2)

  • 22d0a90 properly move and support clear method
  • 1c613c2 use set_state for consistency

📊 Changes

3 files changed (+24 additions, -4 deletions)

View changed files

📝 src/workflows/context/context.py (+5 -3)
📝 src/workflows/context/state_store.py (+8 -1)
📝 tests/test_state_manager.py (+11 -0)

📄 Description

Fixes https://github.com/run-llama/workflows-py/issues/27

We deprecated the old clear() method, but
a) provided no (easy) alternative
b) had incorrect docstrings and deprecation warnings pointing to the wrong methods

I also updated some errors slightly, to better reflect issues when your state cls does not have default fields (I ran into this when writing the test)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/run-llama/workflows-py/pull/30 **Author:** [@logan-markewich](https://github.com/logan-markewich) **Created:** 7/23/2025 **Status:** ✅ Merged **Merged:** 7/23/2025 **Merged by:** [@logan-markewich](https://github.com/logan-markewich) **Base:** `main` ← **Head:** `logan/clear_method` --- ### 📝 Commits (2) - [`22d0a90`](https://github.com/run-llama/workflows-py/commit/22d0a9022c7a647757d70f1b0f7c9c7ac25275c7) properly move and support clear method - [`1c613c2`](https://github.com/run-llama/workflows-py/commit/1c613c22aa7060b2747a51a16f2d075f924a1c2f) use set_state for consistency ### 📊 Changes **3 files changed** (+24 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/workflows/context/context.py` (+5 -3) 📝 `src/workflows/context/state_store.py` (+8 -1) 📝 `tests/test_state_manager.py` (+11 -0) </details> ### 📄 Description Fixes https://github.com/run-llama/workflows-py/issues/27 We deprecated the old `clear()` method, but a) provided no (easy) alternative b) had incorrect docstrings and deprecation warnings pointing to the wrong methods I also updated some errors slightly, to better reflect issues when your state cls does not have default fields (I ran into this when writing the test) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 02:16:26 -05:00
yindo closed this issue 2026-02-16 02:16:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
good first issue
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: run-llama/workflows-py#61
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?