asarium
f819db3ac5
More string const correctness fixes
2017-01-04 00:12:41 +01:00
Fabian Woltermann
add8662737
Converts AI Info flags
2016-08-22 16:39:42 +02:00
Fabian Woltermann
127976cd74
Weapon info flags conversion ( #851 )
2016-08-18 23:17:41 -07:00
Fabian Woltermann
98f72f9378
Finishes converting the remaining ship-related flags ( #843 )
2016-08-17 05:49:40 -07:00
Fabian Woltermann
770fce8de5
Bitset flags -- take 2 ( #775 )
...
This introduces a new mechanism for handling bit flags. Instead of using an int (or two, or three) to write bits into, this uses the std::bitset in a wrapper class that accepts an enum class as input. This means that certain classes of errors we've had a few of in the engine, where a coder used the wrong set of flags or checked them against the wrong variable (SF_STEALTH vs SIF_STEALTH, for example) can now be detected at a compiler level rather than not at all.
2016-08-12 16:13:50 -07:00
asarium
ddacb8cf32
Revert "Fix for Coverity 1093600: Negative array index read"
...
This reverts commit 2aa569c1e7#386 hud_squadmsg_is_target_order_valid actually doesn't properly catch cases where the target_objnum may be -1.
2015-10-24 14:16:31 +02:00
MageKing17
89a6d69e08
Voice recognition cleanup based on Mantis #2373 patch.
...
* Frees cpAudio pointer in VOICEREC_deinit()
* Validates that the ship/wing can actually take orders, and validates that it can take the specific order in question before trying to send it.
* Reports the confidence of the voice match if DEBUG_ON is set.
* Various commenting changes based on the patch.
Not included: using confidence to discard voice matches that fall below a certain confidence level. I haven't noticed a tendency towards spurious matches, and I didn't want to introduce this without additional data, especially when it might cause problems for people with different accents (and ESPECIALLY without a setting to tweak the threshold value, which the original patch did not have; it was hardcoded at 90%).
2015-09-23 14:10:02 -07:00
Echelon9
47af1ff851
Simplify duplicative hud/ includes.
2015-06-22 20:24:30 +10:00
Echelon9
c5493bb480
Scripted sort and uniq on (internal) project includes. Improves search time and as a by product removed a number of duplicative includes.
2015-06-22 20:24:30 +10:00
asarium
2aa569c1e7
Fix for Coverity 1093600: Negative array index read
...
hud_squadmsg_is_target_order_valid already checks if ainfo->target_objnum is less than zero so that check is not needed
2015-05-02 23:14:59 +02:00
MageKing17
ed11f9a1c1
Fix objnum/instance confusion in comm menu.
...
Could cause orders to be grayed out for the wrong ship, due to it happening to have an objnum matching the instance of the ship you were ordering.
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@11305 387891d4-d844-0410-90c0-e4c51a9137d3
2015-04-17 06:07:54 +10:00
MageKing17
b14b590ab1
Adding "interceptable", "turret interceptable", and "fighter interceptable" weapon flags.
...
These allow munitions to be attacked by the AI without needing to set the "bomb" flag; "turret interceptable" means it can be attacked by turrets, "fighter interceptable" means it can be shot down by fighters, and "interceptable" sets both flags simultaneously. Requested by Rheyah.
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@11171 387891d4-d844-0410-90c0-e4c51a9137d3
2014-11-10 17:45:58 +10:00
Echelon9
1484f93590
Fix Coverity 1093599 Negative array index read in hud_query_order_issued()
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@11002 387891d4-d844-0410-90c0-e4c51a9137d3
2014-08-17 18:50:11 +10:00
Goober5000
df73bacb9e
Mantis #3004 : standardize checks for whether ships can depart to docking bays, and whether departure goals are achievable, and whether a ship can be commanded to depart; also fix the default behavior if a ship attempts to warp out but is unable to
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@10428 387891d4-d844-0410-90c0-e4c51a9137d3
2014-02-20 18:27:34 +10:00
Goober5000
dbe5f61dd6
following up from r10000 and r10004, fix the hud squad message display for support ship aborts (and in the process optimize things slightly)
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@10406 387891d4-d844-0410-90c0-e4c51a9137d3
2014-02-20 18:27:34 +10:00
Echelon9
b6b3a24e05
General clean up of commented out #ifndef NDEBUG blocks
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@10166 387891d4-d844-0410-90c0-e4c51a9137d3
2013-12-03 21:12:49 +10:00
Goober5000
c17fd1af7d
fix somebody's spelling
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@10001 387891d4-d844-0410-90c0-e4c51a9137d3
2013-11-10 18:28:55 +10:00
Goober5000
4bd10888ff
make localization more robust with additional checks on string length, more consting, and stronger typing and make XSTR const, since we don't want to modify the strings it translates and then CONST ALL THE THINGS
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9809 387891d4-d844-0410-90c0-e4c51a9137d3
2013-09-26 18:51:34 +10:00
Goober5000
107a61ea13
for Mantis #2097 , straighten out the departure code so that goals to warp cause warping, and comm departures use whatever departure method is specified
2013-01-13 03:03:25 +00:00
The_E
2ab5c72111
PVS Studio fix: "!none_valid" is always true
2012-11-03 09:33:54 +00:00
chief1983
4e5d3e2e57
Fix all the 'no newline at end of file' warnings I saw thrown by gcc on FreeBSD.
2012-11-02 17:30:17 +00:00
Swifty
9c3ef3c636
Added Bottom Background Offset: to Squad Message gauge.
2012-09-10 06:14:06 +00:00
Echelon9
5c9b9044e0
PVS Studio fix: V619 The array 'Players' is being utilized as a pointer to single object. hudsquadmsg.cpp 2595
2012-07-19 14:38:01 +00:00
Echelon9
79da099645
GCC warning: variable set but not used (related to HUD)
2012-06-13 14:50:57 +00:00
karajorma
998c7eb207
Add a SEXP allowing the FREDder to change the orders a player can give to a ship.
2012-05-09 05:09:40 +00:00
Echelon9
f2856015ad
PVS-Studio fixes: Resolve some warnings about use of pointers before checking for a null pointer
2012-03-04 08:51:59 +00:00
Swifty
dd1c4a436c
Fixed Mantis 2413. hud-set-color changes to the HUD will no longer reset when pausing or entering options menu. Introduced Color entry fields for hud_gauges.tbl.
2012-02-06 10:01:01 +00:00
Swifty
3affb86b52
Removed configOverride from HudGauge class since we don't even use it.
2012-02-05 03:41:31 +00:00
Goober5000
9ab3a0728f
tie scramble-messages and unscramble-messages into the communications subsystem status so that they will affect all aspects of communications in a consistent way (squadmsg menu, dashed text, etc.)
...
also make hud_communications_state() be a pure function, i.e. one without side effects
also fixes Mantis #2577
2012-01-21 22:08:38 +00:00
Echelon9
dc4371680a
Clear a whole set of LLVM warnings - some of these would have caused memory fubars, so should marginally improve stability
2012-01-15 08:08:15 +00:00
Goober5000
8dac846455
fix Mantis #2474
2011-07-22 05:55:04 +00:00
Goober5000
b9a1eca909
improved version of hud_squadmsg_wing_valid(); fixes Mantis #2415
2011-03-11 07:21:27 +00:00
Goober5000
315bd423dc
rename subsystem type fields so as to better distinguish them
...
some consistency checks
add "no aggregate" flag to exclude a subsystem from aggregate hitpoint calculations
2011-02-14 08:33:23 +00:00
Zacam
09fad95070
Antipodes 7 Merge: HUD Overhaul, by Swifty.
2010-12-12 20:34:15 +00:00
Echelon9
b7c1dcff02
Fix for reinforcement menu bug - Mantis 2246
2010-07-25 05:04:14 +00:00
karajorma
61af589c21
Swap the engage enemies messages over.
2010-05-28 06:09:53 +00:00
karajorma
a2afa2b67a
Switch to using the Macros for Multiplayer modes whenever possible.
2010-04-27 13:42:59 +00:00
portej05
98f337f701
safe_strings - from Antipodes build #1
2009-07-27 16:06:24 +00:00
portej05
6a8d45c93d
Replace most instances of std::vector with SCP_vector. Memory is now all run through vm_malloc and vm_free.
...
Watch it go up AND down in mission.
2009-07-11 07:07:57 +00:00
Goober5000
b6e4ccfd05
remove the three additional options from possible squad msgs for support ships; but thanks to WMC's feature they can be added for mods
...
synchronize comments on the comm menu and flags
2009-07-01 03:47:54 +00:00
portej05
719825f80d
The big CVS comment removal. This chops approx. 3.5mb off a full checkout.
...
I've tested this through compiling and through hand checking.
Normalises line endings in ALL files to \n.
2009-06-20 08:08:20 +00:00
karajorma
9abc540362
Plug a memory leak.
2009-06-19 18:43:20 +00:00
karajorma
8bdc2c1a9f
Portej05's second set of preFAST fixes.
2009-05-24 21:38:22 +00:00
karajorma
a4e623db23
Portej05's preFAST warning fixes.
2009-05-17 11:50:48 +00:00
karajorma
b33f468e38
Fix Mantis 1913 (Characters after # are visible in the wings and reinforcements comms menu)
2009-05-12 21:53:12 +00:00
karajorma
e2f1229d79
Nope. That won't fix the error. Reverting.
2009-05-04 13:43:48 +00:00
karajorma
bdb1569898
Maybe fix a crash in the voice recognition code. Maybe fix a lock when going into the option menu while respawning.
2009-05-01 17:48:15 +00:00
karajorma
5dcf9f7880
Fix Mantis 1898 (Names with a # are not truncated correctly in the message menu).
2009-03-12 20:25:09 +00:00
karajorma
3b6e62805f
Fix Mantis 1545 & 1754 (Order SEXP doesn't work with wings or destroy subsystems properly)
...
Add the Query-Orders SEXP
Deprecate the Order SEXP
2008-08-31 21:04:44 +00:00
karajorma
bfe417ff2f
Add builtin messages for support ships back into TvT missions.
2008-08-10 10:37:20 +00:00
asarium