Echelon9
62b9833bf0
Fix Coverity 1093638, 1093640 and 1093667: Out-of-bounds access in tcp_client.cpp
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@10736 387891d4-d844-0410-90c0-e4c51a9137d3
2014-06-02 18:29:59 +10:00
chief1983
5664773a29
Allow game_settings.tbl to define the FS2NetD port, so TCs can work out of the box on *nix, etc.
...
http://www.hard-light.net/forums/index.php?topic=86317.0
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@10242 387891d4-d844-0410-90c0-e4c51a9137d3
2013-12-22 19:05:15 +10:00
Goober5000
8179453ffa
fix Mantis #2955 : crash when trying to join multiplayer server, caused by trying to memcpy an integer into a ushort (also add some sanity asserts)
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@10117 387891d4-d844-0410-90c0-e4c51a9137d3
2013-11-25 19:29:36 +10:00
niffiwan
93992f55ff
Coverity 1093668: Out-of-bounds access in fs2netd/tcp_client.cpp
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9970 387891d4-d844-0410-90c0-e4c51a9137d3
2013-10-27 13:51:49 +10:00
niffiwan
a2b7935a15
remove gcc warnings [-Wunused-but-set-variable] in fs2netd/fs2netd_client.cpp
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9898 387891d4-d844-0410-90c0-e4c51a9137d3
2013-10-07 20:02:31 +10:00
niffiwan
02afed1d78
Coverity: more out-of-bounds fixes
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9897 387891d4-d844-0410-90c0-e4c51a9137d3
2013-10-07 20:02:31 +10:00
niffiwan
e68d8097cd
Fix waaay too short char * var for hostname
...
(this was a buffer overrun for every fs2netd game until coverity complained)
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9889 387891d4-d844-0410-90c0-e4c51a9137d3
2013-10-07 20:02:31 +10:00
niffiwan
b26ec341bd
Coverity: more out-of-bounds errors (& fix mistakes in previous "fixes")
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9879 387891d4-d844-0410-90c0-e4c51a9137d3
2013-10-07 20:02:30 +10:00
niffiwan
019c18fab4
Coverity: fix some out-of-bounds access/read/write issues
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9876 387891d4-d844-0410-90c0-e4c51a9137d3
2013-10-07 20:02:30 +10:00
niffiwan
62d06cfcd9
Coverity multiple CID: fix potential not null terminated strings
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9842 387891d4-d844-0410-90c0-e4c51a9137d3
2013-09-29 22:12:22 +10:00
Goober5000
8e096f5c15
remove bad use of memcpy by assigning player class using an actual assign() method (part 2)
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9832 387891d4-d844-0410-90c0-e4c51a9137d3
2013-09-28 11:47:23 +10:00
Goober5000
52edd5b112
remove bad use of memcpy by assigning player class using an actual assign() method
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9831 387891d4-d844-0410-90c0-e4c51a9137d3
2013-09-28 11:47:23 +10:00
Goober5000
fe934190ac
clarify that some structs should now be treated as classes change shockwave_create_info back to being a struct fix some missing shockwave_create_info initialization
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9817 387891d4-d844-0410-90c0-e4c51a9137d3
2013-09-26 18:51:35 +10:00
Goober5000
7248acc004
use a copy method rather than memcpy to clone stats (Mantis #2922 )
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9813 387891d4-d844-0410-90c0-e4c51a9137d3
2013-09-26 18:51:35 +10:00
Goober5000
886018d28f
here a const, there a const, everywhere a const const
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9801 387891d4-d844-0410-90c0-e4c51a9137d3
2013-09-20 19:46:41 +10:00
Goober5000
7f90f5c674
make MAX_MEDALS dynamic
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9799 387891d4-d844-0410-90c0-e4c51a9137d3
2013-09-20 19:27:03 +10:00
Goober5000
138e6b853f
yeesh... a veritable cascade of const-correctness
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk/fs2_open@9783 387891d4-d844-0410-90c0-e4c51a9137d3
2013-09-13 20:18:32 +10:00
karajorma
ac6796f5af
Add all the strings that had no translation.
...
git-svn-id: svn://svn.icculus.org/fs2open/trunk@9600 387891d4-d844-0410-90c0-e4c51a9137d3
2013-03-30 15:36:18 +10:00
Zacam
593be42e66
*drum roll* Pilot Code! Originated by taylor. Additional direct work by: The E, niffiwan, CommanderDJ, Pyro3D, Echelon9 (PVS-Studio), Karajorma and Eli2. (If I missed you, don't kill me.)
...
MASSIVE thanks to Mjn.Mixael and Blue Planet for tireless constant testing.
(It's still not perfect, but it probably wouldn't be where it is at without them)
Spans a lot from initial commit to AP Branch in r6835.
git-svn-id: svn://svn.icculus.org/fs2open/trunk@9561 387891d4-d844-0410-90c0-e4c51a9137d3
2013-03-18 20:26:06 +10:00
Goober5000
a916633b46
onlyjob's spelling fixes, per Mantis #2777
2013-01-13 09:50:08 +00:00
karajorma
a4489e6b97
Fix Mantis 1818 (PXO Login fails ambiguously if you don't have a password or username)
2012-12-21 07:15:07 +00:00
Echelon9
6d4f266e52
Use SCP_* types to access STL types wherever possible. This allows more complete memory monitoring
2011-10-03 09:06:56 +00:00
The_E
124138ae07
PVS Studio related: Mark false alarms as such
2011-09-04 10:14:17 +00:00
Echelon9
80a027a400
PVS-Studio fix: V803 Decreased performance. In case 'tvs' is iterator it's more effective to use prefix form of increment. Replace iterator++ with ++iterator.
...
For further discussion see, http://www.viva64.com/en/b/0093/
The scenarios where it will improve performance are under Debug builds. This improvement will however allow quicker use of other profiling tools that need to run on Debug builds.
Note. Code with size_t does not see the performance improvement comparison to iterators due to absence of array overrun check.
2011-08-28 08:31:25 +00:00
Echelon9
8531488d1b
PVS-Studio fix: Remove duplicate if...then conditional within fs2netd_get_pilot_info()
2011-08-10 13:45:14 +00:00
The_E
7f5c3d343e
Valathil's code cleanup patch.
2011-07-20 18:04:43 +00:00
chief1983
7192a2d8fe
More compatibility fixes for Solaris
2010-11-02 21:20:09 +00:00
Zacam
3e613ff431
Let see how unreachable all this really was.
2010-10-25 03:48:01 +00:00
Zacam
0050b48e80
Clears up the rest of the type conversion warnings listed in MSVC.
2010-10-25 03:26:03 +00:00
taylor
25987a680d
various FS2NetD fixes:
...
- increase sleep time during reconnect
- better handling of disconnects from connection errors
- proper disconnect in case of login failure
- log stats request calls
- don't try to read stats from packet when there aren't any to read
- allow proper connection resetting with standalone
- change auto-reconnect timeout from 30 minutes to 5
- count server traffic among activity instead of just client traffic
- reduce uneccessary client->server traffic
2010-08-03 08:22:02 +00:00
taylor
de43cc3488
spew table/mission crcs to CSV
2009-10-21 11:12:36 +00:00
taylor
85920f2151
fix resetting of mission stats when reconnect of FS2NetD happens
2009-08-25 01:09:30 +00:00
portej05
98f337f701
safe_strings - from Antipodes build #1
2009-07-27 16:06:24 +00:00
taylor
737496d65c
bump buffer to allow for more tables (99 minimum) during validation
2009-07-22 02:21:24 +00:00
portej05
6a8d45c93d
Replace most instances of std::vector with SCP_vector. Memory is now all run through vm_malloc and vm_free.
...
Watch it go up AND down in mission.
2009-07-11 07:07:57 +00:00
portej05
719825f80d
The big CVS comment removal. This chops approx. 3.5mb off a full checkout.
...
I've tested this through compiling and through hand checking.
Normalises line endings in ALL files to \n.
2009-06-20 08:08:20 +00:00
taylor
3abccfa76c
sync up to current FS2NetD code (fixes so many little problems/issues that it's not even funny)
2008-11-09 05:08:19 +00:00
taylor
ee57fa59ca
make sure that we reset the state properly after an ident failure (Mantis #1735 )
2008-10-07 16:28:22 +00:00
taylor
27f2f168dc
fix fs2netd shutdown/cleanup code to work better (gets rid of various little issues)
2008-10-06 05:52:25 +00:00
taylor
beafe688bb
don't really need to bother with MAX_SERVERS any longer since it's ultimately dynamic
2008-10-06 05:51:20 +00:00
taylor
18b2922455
a fix/workaround for Mantis #1692
...
bunch of standalone fixage for error reporting and various little signon issues
fix heartbeats for standalone servers
make proper use of +pxo in multi.cfg for standalone so that games can show up in the lobby
client-side fix for getting pilot stats in lobby (Mantis #1652 )
2008-10-05 13:31:35 +00:00
taylor
de28613166
add separate standalone options for setting FS2NetD login/password (gets around FS2NetD server game listing issue)
2008-10-05 13:24:06 +00:00
taylor
6c255cf1c9
fix HB being sent after server disconnect (made games show up for up to 10 minutes after they had ended)
...
make the chat channel count update more than once, since that didn't appear to work very well
fix compile error with GCC 4.3
2008-07-10 05:10:31 +00:00
taylor
0c1d218fb4
fix compiling on F9 (per the standard, limits.h isn't implicitly included)
2008-06-19 04:36:26 +00:00
taylor
14d88eef33
make table crc spew use the proper table list
2008-05-03 04:46:42 +00:00
taylor
f7422e1aee
add missing break statement to get rid of unidentified packet message
2008-05-03 04:45:17 +00:00
taylor
8103398fbf
some stats fixage
2008-05-03 04:44:22 +00:00
taylor
2899799bfa
add a timeout for getting pilot info (part of Mantis #1652 )
2008-04-03 03:35:26 +00:00
taylor
acae6f5c18
bah, that wasn't supposed to hit just yet
2008-03-21 04:47:13 +00:00
taylor
6aa46ca8d2
update to newest FS2NetD client code
2008-03-20 21:29:41 +00:00