Echelon9
f95628f94d
Documentation: Missionweaponchoice.cpp and related changes. Removed a few redundant functions.
2012-01-22 06:47:55 +00:00
Echelon9
dc4371680a
Clear a whole set of LLVM warnings - some of these would have caused memory fubars, so should marginally improve stability
2012-01-15 08:08:15 +00:00
Zacam
6c702a11e6
svn:eol-type set to LF.
2012-01-13 18:37:09 +00:00
karajorma
a15a260245
Change the define to one that is a little less confusing.
2012-01-11 01:46:50 +00:00
karajorma
28db28427b
Not that it matters much since it's that's what it's ending up as anyway but since the variable that uses it was switched to unsigned we might as well change this.
2012-01-11 01:44:24 +00:00
The_E
07b03ff2b3
Fix for Mantis 2550: Text in multiplayer is rendered outside the textbox if custom fonts are in use
2011-12-18 16:00:26 +00:00
Echelon9
19ae6528e0
Cases of commented out Int3() indicate areas of old, redundant code.
2011-11-17 11:07:53 +00:00
Echelon9
77c852e15a
A few further changes for Windows support under the new jump_nodes STL refactor
2011-10-03 13:26:03 +00:00
Echelon9
6d4f266e52
Use SCP_* types to access STL types wherever possible. This allows more complete memory monitoring
2011-10-03 09:06:56 +00:00
Echelon9
5dfb30dfce
PVS-Studio fix: V507 Pointer to local array 'title_str' is stored outside the scope of this array. Such a pointer will become invalid.
2011-10-01 06:54:43 +00:00
Zacam
206279c5fd
Sync Drift: Apparently still some lingering ifdefs for OEM/Multiplayer_Beta and non-AP specific things not having made it to trunk for some reason.
2011-09-25 08:26:45 +00:00
Echelon9
e3195a82d6
Code cleanup: We should be really careful with using these scoring struct elements, as the types were changed from ushort to int at some point.
2011-09-25 02:42:27 +00:00
Echelon9
8e1c689f32
PVS-Studio fix: V581 The conditional expressions of the 'if' operators situated alongside each other are identical. Check lines: 2056, 2061 (multiteamselect.cpp)
2011-09-23 20:28:06 +00:00
Echelon9
2866b4fb3b
PVS-Studio fix: V581 The conditional expressions of the 'if' operators situated alongside each other are identical. Check lines: 2039, 2044 (multiteamselect.cpp)
2011-09-23 20:27:25 +00:00
Zacam
9678d18bc3
Part One: Synchronization pass of Trunk and Antipodes Differences.
...
Whitespace/tab mostly.
aicode does have a change of an Int3 to an Assertion.
bmpman has an update to bm_next_handle.
2011-09-09 09:37:45 +00:00
Echelon9
6de5b02e77
Documentation: Code clean up of psnet2.cpp
2011-09-07 12:28:18 +00:00
Echelon9
9086c95131
PVS-Studio fix (courtesy of niffiwan): V512 A call of the 'memcpy' function will lead to underflow of the buffer (psnet2.cpp)
2011-09-07 11:58:47 +00:00
Zacam
c946bc4a45
PVS-Studio fix (courtesy of niffiwan): V512 - A call of the 'memcpy' function will lead to overflow of the buffer '& ip_addr.sin_addr'.
2011-09-07 10:00:03 +00:00
Echelon9
6d245f7bc2
PVS-Studio fix: V524 It is odd that the body of 'multi_xfer_reset' function is fully equivalent to the body of 'multi_xfer_close' function (multi_xfer.cpp, line 185).
...
Remove duplicate, unused function
2011-09-06 12:29:56 +00:00
Echelon9
7d56f961e5
PVS-Studio fix (courtesy of niffiwan): V568It's odd that the argument of sizeof() operator is the '(short) method' expression.
2011-09-05 12:49:37 +00:00
The_E
d283d5800d
Another false alarm from PVS Studio
2011-09-04 12:33:00 +00:00
The_E
790dba1d3d
PVS Studio related: Mark false alarms as such
2011-09-04 09:35:08 +00:00
Echelon9
e3c100d5fa
Documentation: A few documentation fixes
2011-09-03 09:06:00 +00:00
Goober5000
2ce8ca62cf
PVS-Studio fix: V804 Decreased performance. The 'strlen' function is called twice in the specified expression to calculate length of the same string.
2011-09-03 01:32:07 +00:00
Echelon9
4201582786
Let's have another go at this one... around we go again
2011-09-01 13:08:32 +00:00
karajorma
7df5137ac4
Fix a mismatch.
2011-08-31 14:06:19 +00:00
Echelon9
3063b2cd85
Undo my rather silly patch, apply niffiwan's patch as a temporary measure (at least).
2011-08-31 13:48:23 +00:00
Echelon9
9be05a4d7f
PVS-Studio fix: V523 The 'then' statement is equivalent to the 'else' statement (psnet2.cpp).
...
This one was particular bad as it code have lead to remotely induced crashes over the network with oversize packets.
2011-08-31 13:12:46 +00:00
The_E
0525e871d0
PVS Studio related: Mark false alarms as such.
2011-08-30 17:46:49 +00:00
The_E
724f1be9d3
Removing the RELEASE_REAL define from ye olde ✌️ days. We really don't need it anymore.
2011-08-30 17:46:03 +00:00
Echelon9
3453cc9c70
PVS-Studio fix: V576 Incorrect format. Consider checking the [third] actual argument of the 'sprintf' function. The SIGNED integer type argument is expected.
...
Fixes a number of this class of issue with sprintf formats.
2011-08-30 15:39:29 +00:00
karajorma
7ca92457b4
PVS-Studio fix: V512 A call of the 'memset' function will lead to underflow of the buffer 'type'.
...
Never really would matter but it's a waste of memory declaring an int buffer and then only using 1/4 of it
2011-08-30 11:50:23 +00:00
Goober5000
2ef9fa11b6
add fire-beam-at-coordinates, which is as awesome as it sounds
2011-08-30 07:29:57 +00:00
Goober5000
3ce69f150a
waypoints and waypoint paths now have dynamic limits
2011-08-30 03:35:42 +00:00
karajorma
caff640862
Documentation for the Multiplayer SEXP system.
2011-08-30 00:18:32 +00:00
Echelon9
9c0edf2d64
Documentation: Code cleanup in multi_obj.cpp
2011-08-28 09:36:18 +00:00
Echelon9
66dd978878
PVS-Studio fix: V519 The 'num_users' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 2296, 2297 (multi_pxo.cpp)
2011-08-28 09:34:09 +00:00
Echelon9
91f01706fd
PVS-Studio fix: V519 The 'player_index' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1389, 1392 (multi_obj.cpp)
2011-08-28 09:32:55 +00:00
Echelon9
34084aebe6
PVS-Studio fix: V501 There are identical sub-expressions '(stricmp (szCmd, "372") == 0)' to the left and to the right of the '||' operator.
...
and
V501 There are identical sub-expressions '(stricmp (szCmd, "375") == 0)' to the left and to the right of the '||' operator.
2011-08-28 07:27:53 +00:00
Echelon9
9fa25a9ae4
PVS-Studio fix: V802 On 32-bit platform, structure size can be reduced from 50 to 48 bytes by rearranging the fields according to their sizes in decreasing order.
2011-08-28 07:08:40 +00:00
Goober5000
3b2b76206f
add infrastructure and parsing support for mission forks (vs. mission loops)
...
mission fork interface art and selection logic still needs to be written
2011-08-27 03:57:16 +00:00
Echelon9
a248a37d58
PVS-Studio: Fix V805. Decreased performance. It is inefficient to identify an empty string by using 'strlen(str) > 0' construct
2011-08-24 13:37:01 +00:00
karajorma
56f758967a
Fix several SEXPs for multiplayer use. This should fix Mantis issues 2401, 2483 and 2382.
...
In addition, fix a bug caused by SEXPs that do a callback but don't send any data.
2011-08-24 08:37:11 +00:00
Goober5000
b1ad28efdb
add an option to fire-beam to force the beam to fire
...
combine fighter_beam flag into flags field
2011-08-21 01:11:24 +00:00
karajorma
4dfa577114
Add options to send objects, shorts and ushorts via the multiplayer SEXP system.
2011-08-19 08:09:50 +00:00
Echelon9
555a9033de
Documentation: General clean-up and function documentation
2011-08-18 16:47:54 +00:00
karajorma
77745bdb75
Doh, missed one!
2011-08-18 07:56:31 +00:00
karajorma
1a577f6473
Fixes and clean up for the multiplayer SEXP packet system.
...
- Make the system more robust against accidental attempts to write data to the packet without proper initialisation.
- Improve the error messages and function names to make clear the difference between the packet the game actually sends and the abstracted packets the coder seems to create and send in sexp.cpp
- Add a convenience methods to deal with SEXPs that don't need to write any data.
2011-08-18 07:48:59 +00:00
karajorma
df0722f929
Fixes for the multiplayer SEXP packet to prevent errors caused by the coder taking too little data out of the packet before reporting that they are done.
2011-08-18 05:24:27 +00:00
Echelon9
5b60b84cfd
PVS-Studio: The '&' operator is applied to bool type value. You've probably forgotten to include parentheses or intended to use the '&&' operator. In process_event_update_packet()
2011-08-11 14:56:43 +00:00
Echelon9